Re: RFR: 8087112: HTTP API and HTTP/1.1 implementation
On 30/09/15 17:34, Michael McMahon wrote: Hi, A new revision of the API can be seen at: http://cr.openjdk.java.net/~michaelm/8087112/04/ The main changes are: - package name change. Moved to own package java.net.httpclient - proxy setting uses ProxySelector (a static factory method will be added to ProxySelector for setting a simple fixed address for all proxies). Using ProxySelector gives access to system default proxies. - HttpResponseBodyProcessor uses flow control based on Flow api. - miscellaneous doc cleanups/clarifications Thanks, Michael Also, an explicit timeout is added and a TimeoutException thrown when responses are not received within specified time. Michael
Re: RFR: 8087112: HTTP API and HTTP/1.1 implementation
Hi, A new revision of the API can be seen at: http://cr.openjdk.java.net/~michaelm/8087112/04/ The main changes are: - package name change. Moved to own package java.net.httpclient - proxy setting uses ProxySelector (a static factory method will be added to ProxySelector for setting a simple fixed address for all proxies). Using ProxySelector gives access to system default proxies. - HttpResponseBodyProcessor uses flow control based on Flow api. - miscellaneous doc cleanups/clarifications Thanks, Michael
Re: [9] RFR 8137174: NTLM impl should use doPrivileged when it reads system properties
This looks ok to me Artem. -Chris On 30/09/15 11:11, Artem Smotrakov wrote: Hello, Please review this small fix which updates NTLM implementation to use doPrivileged() methods when it reads system properties. Currently it requires property permissions to read "ntlm.debug" and "ntlm.version" system properties. Also added a test which runs NTLM auth if security manager is set. Webrev: http://cr.openjdk.java.net/~asmotrak/8137174/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8137174 Artem
[9] RFR 8137174: NTLM impl should use doPrivileged when it reads system properties
Hello, Please review this small fix which updates NTLM implementation to use doPrivileged() methods when it reads system properties. Currently it requires property permissions to read "ntlm.debug" and "ntlm.version" system properties. Also added a test which runs NTLM auth if security manager is set. Webrev: http://cr.openjdk.java.net/~asmotrak/8137174/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8137174 Artem
Re: RFR: 8135305: InetAddress.isReachable reports true when loopback interface is specified
Looks fine to me Rob - Michael On 25/09/15 13:54, Rob McKenna wrote: Good point. I'll remove that pre-push. -Rob On 25/09/15 11:57, Mark Sheppard wrote: Hi Rob, looks fine ... the "him" variable in the Java_java_net_Inet4AddressImpl_isReachable0 would appear not to be used now, so could probably be removed with its call on memset ? regards Mark On 24/09/2015 15:45, Rob McKenna wrote: Please ignore the formatting errors. Thats either a problem with hg diff or webrev, but its fixed in the repo. -Rob On 24/09/15 15:43, Rob McKenna wrote: Hi folks, The recent change to isReachable (8133015: InetAddress.isReachable(tmout) returning wrong value on Windows for IPv6 - http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/59ff6cd9535d) neglected to take the specified interface into account for ipv4. This change ensures that isReachable returns false for external hosts when the loopback interface is specified. http://cr.openjdk.java.net/~robm/8135305/webrev.01/ -Rob
