Re: A new proposal to add methods to HttpsURLConnection to access SSLSession
On 11/8/18 4:06 PM, Xuelei Fan wrote: To make sure the SecureCacheResponse class work, two new tests are added (DefaultCacheResponse for default implementation, DummyCacheResponse for a test implementation): http://cr.openjdk.java.net/~xuelei/8212261/webrev.04/ I think you mean http://cr.openjdk.java.net/~xuelei/8212261/webrev.05/ Looks good. --Sean Thanks, Xuelei On 11/8/2018 7:03 AM, Sean Mullan wrote: On 11/7/18 7:22 PM, Xuelei Fan wrote: On 11/7/2018 1:30 PM, Sean Mullan wrote: https://bugs.openjdk.java.net/browse/JDK-8213161 http://cr.openjdk.java.net/~xuelei/8212261/webrev.03/ I didn't see a test for SecureCacheResponse - is it possible? JDK does not have the reference implementation of SecureCacheResponse. Ah, I see. I am sure there is a good reason, but why doesn't it have an implementation? You could also add a test case for IllegalStateExc. Added in the same test file. lines 108-113 of HttpsSession.java should be indented 4 more spaces. Otherwise looks ok to me. Updated. New webrev: http://cr.openjdk.java.net/~xuelei/8212261/webrev.04/ Looks good. --Sean
Re: RFR [12] 8210493: Bind to node- or linklocal ipv6 multicast address fails
Alan, Chris, Thanks for reviewing this change. However, before the push I tested it again and found out that there is a small number of Linux machines on which both tests fail. The only thing I found to be in common between these machines was the version of the Linux kernel. Machines with the 3.10.0 kernel on board failed these tests. The converse is also true. That is, if these tests failed, the machine's kernel was 3.10.0. I understand that there might be no causal relationship between those facts. For example, it could be the case that machines with this kernel are configured (e.g. network) differently. However, from what I've seen (`ifconfig` and `sysctl` output) it doesn't seem to be the case. Unless there are better suggestions I propose to skip these tests on 3.10.0 kernels. http://cr.openjdk.java.net/~prappo/8210493/webrev.02/ What do you think? -Pavel
RFR 8213189: Make restricted headers in HTTP Client configurable and remove Date by default
Could I get the following change reviewed please? We've reduced the number of restricted headers to the minimum and made those settable via a networking property (with health warning) http://cr.openjdk.java.net/~michaelm/8213189/webrev.1/ This change will require a CSR for the new property. Thanks, Michael
RFR 8213616 URLPermission with query or fragment behaves incorrectly
Could i get the following small change reviewed please? http://cr.openjdk.java.net/~michaelm/8213616/webrev.1/ Thanks, Michael
Re: RFR 8213189: Make restricted headers in HTTP Client configurable and remove Date by default
Hi Michael, This looks good to me. best regards, -- daniel On 09/11/2018 15:46, Michael McMahon wrote: Could I get the following change reviewed please? We've reduced the number of restricted headers to the minimum and made those settable via a networking property (with health warning) http://cr.openjdk.java.net/~michaelm/8213189/webrev.1/ This change will require a CSR for the new property. Thanks, Michael
