RE: RFR (13) [testbug]: 8227422: sun/net/www/protocol/file/DirPermissionDenied.java failed on Windows 2016 because DirPermissionDenied directory has no read permission
> > > On 11/07/2019 06:03, Frank Yuan wrote: > > Hi Daniel > > > > I have filed another bughttps://bugs.openjdk.java.net/browse/JDK-8227566 > > to refine the bug. > > Thanks Frank! > > > And, I tested on Windows 7, the expected exception is raised... I will test > > on more platform. > > Good to know - in our test system though no windows machine ever > threw the exception... > > You have my review then. > Then I will push this patch, since JDK-8227566 will not solved in a short time. Thanks Frank > best regards, > > -- daniel > > > > > Thanks > > Frank
Re: RFR: 8227587: Add internal privileged System.loadLibrary
Hi Roger, On 2019-07-11 16:10, Roger Riggs wrote: Hi Claes, JavaLangAccess.java: 316: Add @param tag done. System.java: 2282, 2287 Runtime.loadLibrary0 makes a second check for a security manager. Is there any potential gain by calling ClassLoader.loadLibrary directly? None of the internal uses would have a separatorChar. Most of the gain comes from not having to load one-off PA classes or lambdas, but of course avoiding the indexOf and a few indirections are marginally helpful to startup. We should at least assert that the library names are sane, though. I expect most of the files need a copyright update. The script in /make/scripts/update_copyright_year.sh should do the work for modified files. Fixed copyrights and updated in place: http://cr.openjdk.java.net/~redestad/8227587/open.00 Thanks! /Claes
Re: RFR: 8227587: Add internal privileged System.loadLibrary
Hi Claes, JavaLangAccess.java: 316: Add @param tag System.java: 2282, 2287 Runtime.loadLibrary0 makes a second check for a security manager. Is there any potential gain by calling ClassLoader.loadLibrary directly? None of the internal uses would have a separatorChar. I expect most of the files need a copyright update. The script in /make/scripts/update_copyright_year.sh should do the work for modified files. Roger On 7/11/19 9:43 AM, Claes Redestad wrote: Hi, by adding a method to load libraries with privileges to JavaLangAccess, we can simplify a slew of places where we are currently implementing adhoc privileged actions. This is a tiny but measurable gain on a range of startup tests. Webrev: http://cr.openjdk.java.net/~redestad/8227587/open.00 Bug: https://bugs.openjdk.java.net/browse/JDK-8227587 Testing: tier1-3 Thanks! /Claes
RFR: 8227587: Add internal privileged System.loadLibrary
Hi, by adding a method to load libraries with privileges to JavaLangAccess, we can simplify a slew of places where we are currently implementing adhoc privileged actions. This is a tiny but measurable gain on a range of startup tests. Webrev: http://cr.openjdk.java.net/~redestad/8227587/open.00 Bug: https://bugs.openjdk.java.net/browse/JDK-8227587 Testing: tier1-3 Thanks! /Claes
Re: RFR (13) [testbug]: 8227422: sun/net/www/protocol/file/DirPermissionDenied.java failed on Windows 2016 because DirPermissionDenied directory has no read permission
On 11/07/2019 06:03, Frank Yuan wrote: Hi Daniel I have filed another bughttps://bugs.openjdk.java.net/browse/JDK-8227566 to refine the bug. Thanks Frank! And, I tested on Windows 7, the expected exception is raised... I will test on more platform. Good to know - in our test system though no windows machine ever threw the exception... You have my review then. best regards, -- daniel Thanks Frank
