Integrated: 8202343: Disable TLS 1.0 and 1.1

2020-11-19 Thread Sean Mullan
On Mon, 16 Nov 2020 20:18:16 GMT, Sean Mullan  wrote:

> This change disables the TLSv1 and TLSv1.1 protocols by adding them to the 
> jdk.tls.disabledAlgorithms security property in the java.security file. These 
> protocols use weak algorithms and are being deprecated by the IETF. They 
> should be disabled by default to improve the default security configuration 
> of the JDK. See the CSR for more rationale: 
> https://bugs.openjdk.java.net/browse/JDK-8254713
> 
> The fix mostly involves changes to existing tests that for one reason or 
> another depend on the TLSv1 and TLSv1.1 protocols being enabled. There is a 
> new test specifically for this issue: 
> test/jdk/sun/security/ssl/SSLContextImpl/SSLContextDefault.java

This pull request has now been integrated.

Changeset: 3a4b90f0
Author:Sean Mullan 
URL:   https://git.openjdk.java.net/jdk/commit/3a4b90f0
Stats: 396 lines in 21 files changed: 273 ins; 97 del; 26 mod

8202343: Disable TLS 1.0 and 1.1

Reviewed-by: xuelei, dfuchs, coffeys

-

PR: https://git.openjdk.java.net/jdk/pull/1235


Integrated: 8252304: Seed an HttpRequest.Builder from an existing HttpRequest

2020-11-19 Thread Patrick Concannon
On Wed, 4 Nov 2020 14:51:07 GMT, Patrick Concannon  
wrote:

> Hi,
> 
> Could someone please review our code for JDK-8252304: 'Seed an 
> HttpRequest.Builder from an existing HttpRequest'?
> 
> This RFR proposes a new factory method for creating a new `HttpRequest` 
> builder from an existing `HttpRequest`.
> This method can be used to build a new request equivalent to the given 
> request, but with different attributes. For instance, it will allow the user 
> to take an existing request and add or change a particular header, provide a 
> new `URI`, etc.
> 
> 
> Kind regards,
> Patrick & Chris

This pull request has now been integrated.

Changeset: 9fe2d31d
Author:Patrick Concannon 
URL:   https://git.openjdk.java.net/jdk/commit/9fe2d31d
Stats: 518 lines in 3 files changed: 516 ins; 0 del; 2 mod

8252304: Seed an HttpRequest.Builder from an existing HttpRequest

Co-authored-by: Chris Hegarty 
Reviewed-by: chegar, dfuchs, michaelm

-

PR: https://git.openjdk.java.net/jdk/pull/1059


Re: RFR: 8252304: Seed an HttpRequest.Builder from an existing HttpRequest [v11]

2020-11-19 Thread Michael McMahon
On Wed, 18 Nov 2020 17:45:25 GMT, Patrick Concannon  
wrote:

>> Hi,
>> 
>> Could someone please review our code for JDK-8252304: 'Seed an 
>> HttpRequest.Builder from an existing HttpRequest'?
>> 
>> This RFR proposes a new factory method for creating a new `HttpRequest` 
>> builder from an existing `HttpRequest`.
>> This method can be used to build a new request equivalent to the given 
>> request, but with different attributes. For instance, it will allow the user 
>> to take an existing request and add or change a particular header, provide a 
>> new `URI`, etc.
>> 
>> 
>> Kind regards,
>> Patrick & Chris
>
> Patrick Concannon has updated the pull request with a new target base due to 
> a merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains 19 additional 
> commits since the last revision:
> 
>  - 8252304: Changed wording of first and second sentence of API spec for 
> newBuilder
>  - Merge remote-tracking branch 'origin/master' into JDK-8252304
>  - 8252304: Fixed typo in newBuilder example; updated filter test cases to 
> check for value to remove
>  - Merge remote-tracking branch 'origin/master' into JDK-8252304
>  - 8252304: Added more test cases to check header filter
>  - Merge remote-tracking branch 'origin/master' into JDK-8252304
>  - Merge remote-tracking branch 'origin/master' into JDK-8252304
>  - 8252304: BiPredicate parameter added to newBuilder
>  - Merge remote-tracking branch 'origin/master' into JDK-8252304
>  - Merge remote-tracking branch 'origin/master' into JDK-8252304
>  - ... and 9 more: 
> https://git.openjdk.java.net/jdk/compare/1c179945...b1378a35

Marked as reviewed by michaelm (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/1059