Re: RFR: 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager installed [v2]
On Wed, 27 Jan 2021 18:59:00 GMT, Claes Redestad wrote: >> 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager >> installed > > Claes Redestad has updated the pull request incrementally with two additional > commits since the last revision: > > - Copyrights > - Same for Windows Marked as reviewed by mullan (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2263
Re: RFR: 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager installed [v2]
On Wed, 27 Jan 2021 18:59:00 GMT, Claes Redestad wrote: >> 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager >> installed > > Claes Redestad has updated the pull request incrementally with two additional > commits since the last revision: > > - Copyrights > - Same for Windows Windows changes LGTM too. - Marked as reviewed by dfuchs (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2263
Re: RFR: 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager installed [v2]
> 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager > installed Claes Redestad has updated the pull request incrementally with two additional commits since the last revision: - Copyrights - Same for Windows - Changes: - all: https://git.openjdk.java.net/jdk/pull/2263/files - new: https://git.openjdk.java.net/jdk/pull/2263/files/09e4ff9e..81d3a4d0 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2263&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2263&range=00-01 Stats: 6 lines in 2 files changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/jdk/pull/2263.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2263/head:pull/2263 PR: https://git.openjdk.java.net/jdk/pull/2263
Re: RFR: 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager installed [v2]
On Wed, 27 Jan 2021 16:57:25 GMT, Sean Mullan wrote: > Will you make the same change to > `src/java.base/windows/classes/sun/net/www/protocol/jar/JarFileFactory.java`? Good catch. Let's keep things consistent. :-) - PR: https://git.openjdk.java.net/jdk/pull/2263
Re: RFR: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl [v6]
On Wed, 27 Jan 2021 17:46:03 GMT, Xue-Lei Andrew Fan wrote: >> Changes requested by rhalade (Reviewer). > > For the CSR request, I updated the component to security-libs/javax.net.ssl, > add 17 as one of the fix versions, and added myself as reviewer. Thank you. I will change the status of the CSR to proposed. - PR: https://git.openjdk.java.net/jdk/pull/2057
Re: RFR: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl [v6]
On Wed, 13 Jan 2021 18:46:10 GMT, Rajan Halade wrote: >> Clive Verghese has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains four commits: >> >> - Update copyright year >> - Add error handling guidelines >> - Fix bugids and use server port passed as a parameter >> - 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl > > Changes requested by rhalade (Reviewer). For the CSR request, I updated the component to security-libs/javax.net.ssl, add 17 as one of the fix versions, and added myself as reviewer. - PR: https://git.openjdk.java.net/jdk/pull/2057
Re: RFR: 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager installed
On Wed, 27 Jan 2021 15:10:16 GMT, Michael McMahon wrote: >> 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager >> installed > > Marked as reviewed by michaelm (Reviewer). Will you make the same change to `src/java.base/windows/classes/sun/net/www/protocol/jar/JarFileFactory.java`? - PR: https://git.openjdk.java.net/jdk/pull/2263
Re: RFR: 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager installed
On Wed, 27 Jan 2021 14:47:08 GMT, Claes Redestad wrote: > 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager > installed Marked as reviewed by michaelm (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2263
Re: RFR: 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager installed
On Wed, 27 Jan 2021 14:54:33 GMT, Alan Bateman wrote: >> 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager >> installed > > Should be okay as the side effect of getPermission is not observable. Make > sure to run all the tests before integrating. @AlanBateman @dfuch thanks for reviewing. Waiting for a tier1+2 test run before integration. - PR: https://git.openjdk.java.net/jdk/pull/2263
Re: RFR: 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager installed
On Wed, 27 Jan 2021 14:47:08 GMT, Claes Redestad wrote: > 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager > installed Looks reasonable to me. Make sure to run jdk-tier2 (or jdk_core) just in case :-) - Marked as reviewed by dfuchs (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2263
Re: RFR: 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager installed
On Wed, 27 Jan 2021 14:47:08 GMT, Claes Redestad wrote: > 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager > installed Should be okay as the side effect of getPermission is not observable. Make sure to run all the tests before integrating. - Marked as reviewed by alanb (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2263
RFR: 8260520: Avoid getting permissions in JarFileFactory when no SecurityManager installed
8260520: Avoid getting permissions in JarFileFactory when no SecurityManager installed - Commit messages: - Avoid getting permissions when there's no SM installed Changes: https://git.openjdk.java.net/jdk/pull/2263/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2263&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8260520 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk/pull/2263.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2263/head:pull/2263 PR: https://git.openjdk.java.net/jdk/pull/2263
