Re: RFR: 8273616: Fix trivial doc typos in the java.base module [v2]

2021-09-10 Thread Iris Clark 
On Fri, 10 Sep 2021 23:20:11 GMT, Pavel Rappo  wrote:

>> 8273616: Fix trivial doc typos in the java.base module
>
> Pavel Rappo has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Revert two fixes

Marked as reviewed by iris (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/5475

Re: RFR: 8273616: Fix trivial doc typos in the java.base module [v2]

2021-09-10 Thread Pavel Rappo 
> 8273616: Fix trivial doc typos in the java.base module

Pavel Rappo has updated the pull request incrementally with one additional 
commit since the last revision:

  Revert two fixes

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5475/files
  - new: https://git.openjdk.java.net/jdk/pull/5475/files/b90d1556..9a9deee1

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=5475=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=5475=00-01

  Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5475.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5475/head:pull/5475

PR: https://git.openjdk.java.net/jdk/pull/5475

Re: RFR: 8273616: Fix trivial doc typos in the java.base module [v2]

2021-09-10 Thread Pavel Rappo 
On Fri, 10 Sep 2021 21:52:36 GMT, John R Rose  wrote:

>> Pavel Rappo has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Revert two fixes
>
> src/java.base/share/classes/java/nio/channels/FileChannel.java line 567:
> 
>> 565:  *  If {@code true} then this method is required to force 
>> changes
>> 566:  *  to both the file's content and metadata to be written to
>> 567:  *  storage; otherwise, it needs only force content changes 
>> to be
> 
> (same as previous comment:  the suggested fix makes the English *less* 
> correct)

Reverted both in 9a9deee; thanks.

-

PR: https://git.openjdk.java.net/jdk/pull/5475

Re: RFR: 8273616: Fix trivial doc typos in the java.base module

2021-09-10 Thread Florent Guillaume 
On Fri, 10 Sep 2021 21:51:45 GMT, John R Rose  wrote:

>> 8273616: Fix trivial doc typos in the java.base module
>
> src/java.base/share/classes/java/nio/channels/AsynchronousFileChannel.java 
> line 399:
> 
>> 397:  *  If {@code true} then this method is required to force 
>> changes
>> 398:  *  to both the file's content and metadata to be written to
>> 399:  *  storage; otherwise, it needs only force content changes 
>> to be
> 
> This is a correct though rare use of subjunctive mood:  One need not change 
> it.
> However, if be desired that we change the mood to indicative, I suggest s/it 
> need only force/it only needs to force/.

(_it need only force_ is not really subjunctive mood, but rather usage as a 
modal auxiliary, see https://english.stackexchange.com/a/297235)

-

PR: https://git.openjdk.java.net/jdk/pull/5475

Re: RFR: 8273616: Fix trivial doc typos in the java.base module

2021-09-10 Thread John R Rose 
On Fri, 10 Sep 2021 21:16:19 GMT, Pavel Rappo  wrote:

> 8273616: Fix trivial doc typos in the java.base module

Approved, except for two changes commented above: the original "it need only 
force" is correct usage, and "it needs only force" is not good usage, but "it 
only needs to force" would be clearer and also correct.

src/java.base/share/classes/java/nio/channels/AsynchronousFileChannel.java line 
399:

> 397:  *  If {@code true} then this method is required to force 
> changes
> 398:  *  to both the file's content and metadata to be written to
> 399:  *  storage; otherwise, it needs only force content changes 
> to be

This is a correct though rare use of subjunctive mood:  One need not change it.
However, if be desired that we change the mood to indicative, I suggest s/it 
need only force/it only needs to force/.

src/java.base/share/classes/java/nio/channels/FileChannel.java line 567:

> 565:  *  If {@code true} then this method is required to force 
> changes
> 566:  *  to both the file's content and metadata to be written to
> 567:  *  storage; otherwise, it needs only force content changes 
> to be

(same as previous comment:  the suggested fix makes the English *less* correct)

-

Marked as reviewed by jrose (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5475

RFR: 8273616: Fix trivial doc typos in the java.base module

2021-09-10 Thread Pavel Rappo 
8273616: Fix trivial doc typos in the java.base module

-

Commit messages:
 - Initial commit

Changes: https://git.openjdk.java.net/jdk/pull/5475/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=5475=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8273616
  Stats: 55 lines in 34 files changed: 0 ins; 0 del; 55 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5475.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5475/head:pull/5475

PR: https://git.openjdk.java.net/jdk/pull/5475

Re: RFR: 8270553: Tests should not use (real, in-use, routable) 1.1.1.1 as dummy IP value [v2]

2021-09-10 Thread Daniel Fuchs 
On Fri, 6 Aug 2021 19:50:48 GMT, Jonathan Dowland  wrote:

>> The tests `test/jdk/java/net/HttpURLConnection/HttpURLConWithProxy.java` 
>> uses the IP address "1.1.1.1" as a value. I think at the time the address 
>> was picked, the assumption was the address was not valid / not routable. 
>> Since April 2018 the address is part of CloudFlare's "Free" DNS product: 
>> . (this test was originally written 
>> in 2016, before the service was launched)
>> 
>> I've verified using local packet captures that running the test does result 
>> in IP traffic being sent to 1.1.1.1. (Several other tests in JDK use 1.1.1.1 
>> as a placeholder IP. I've checked them all and none of the others connect 
>> out to the IP like this one)
>>  
>> This PR substitutes that IP address value (and two others) for ones from a 
>> reserved IP range (240.0.0.0/4 according to RFC 6761) which will not result 
>> in runners of the test suit inadvertently sending IP packets to the 
>> CloudFlare service. 
>> 
>> This could be invalidated again if that address range is allocated at some 
>> point in the future. A more future-proof fix would be to bind to random 
>> ports on localhost for each dummy proxy (as done for the target HTTP server 
>> in the test already). I can do that if preferred.
>> 
>> 
>
> Jonathan Dowland has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains one additional 
> commit since the last revision:
> 
>   8270553: Tests should not use (real, in-use, routable) 1.1.1.1 as dummy IP 
> value

Hi Jonathan, this should be ready to integrate so please enter /integrate in a 
new comment and then it can be sponsored.

-

PR: https://git.openjdk.java.net/jdk/pull/4806

RFR: 8233674: JarURLConnection.getJarFile throws Exception if some process is holding the file

2021-09-10 Thread Masanori Yano 
Could you please review the 8233674 bug fixes?
This problem is caused by the antivirus software opening the file for a short 
time, so CreateFile() should be retried.

-

Commit messages:
 - 8233674: JarURLConnection.getJarFile throws Exception if some process is 
holding the file

Changes: https://git.openjdk.java.net/jdk/pull/5460/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=5460=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8233674
  Stats: 299 lines in 3 files changed: 261 ins; 12 del; 26 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5460.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5460/head:pull/5460

PR: https://git.openjdk.java.net/jdk/pull/5460