Integrated: 8260428: Drop support for pre JDK 1.4 DatagramSocketImpl implementations
On Mon, 11 Oct 2021 09:42:12 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my changes (and CSR) to drop support for pre JDK > 1.4 `DatagramSocketImpl` implementations? > > These changes propose to drop support for `DatagramSocketImpls` that were > compiled with JDK 1.3 or older, which do not have support for connected > sockets, for peeking at received datagrams, and for joining and leaving a > group at a specific interface. This support is legacy, and should be > relatively safe to remove as such implementations do not compile with JDK 1.4 > or newer. > > Finally, with this set of proposed changes, if you have an `oldImpl`, and > don’t use connect, then the methods `joinGroup` and `leaveGroup` will throw > `NoSuchMethodError`. However, the current behaviour in `DatagramSocketImpl` > is to throw an `UnsupportedOperationsException` for a method not implemented. > Should this set of changes update the `joinGroup` and `leaveGroup` methods in > order to preserve this behaviour? > > CSR: https://bugs.openjdk.java.net/browse/JDK-8274633 > > Kind regards, > > Patrick This pull request has now been integrated. Changeset: 97715440 Author:Patrick Concannon URL: https://git.openjdk.java.net/jdk/commit/977154400be786c500f36ba14188bff79db57075 Stats: 290 lines in 3 files changed: 197 ins; 78 del; 15 mod 8260428: Drop support for pre JDK 1.4 DatagramSocketImpl implementations Reviewed-by: alanb, dfuchs, vtewari - PR: https://git.openjdk.java.net/jdk/pull/5887
Re: RFR: 8275534: com.sun.net.httpserver.BasicAuthenticator should check whether "realm" is a quoted string [v2]
On Mon, 1 Nov 2021 13:12:51 GMT, Julia Boes wrote: >> This change ensures that the realm string passed to the BasicAuthenticator >> constructor is a quoted-string, as per RFC7230 [1]. A Utils class is added >> to jdk.httpserver/sun.net.httpserver that holds the new isQuotedString() >> method and the pre-existing isValidName() method (previously in ServerImpl.) >> Two tests are included: >> - BasicAuthenticatorRealm.java to check that Latin-1 chars in the realm >> string are transported correctly, >> - BasicAuthenticatorExceptionCheck.java to check realm strings with escaped >> quotes. >> >> Testing: tier 1-3. >> >> [1] https://datatracker.ietf.org/doc/html/rfc7230 > > Julia Boes has updated the pull request incrementally with one additional > commit since the last revision: > > address PR comments > * change method name to isQuotedStringContent > * update api note and throws declaration LGTM - Marked as reviewed by michaelm (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6117
Re: RFR: 8275534: com.sun.net.httpserver.BasicAuthenticator should check whether "realm" is a quoted string [v2]
On Mon, 1 Nov 2021 13:12:51 GMT, Julia Boes wrote: >> This change ensures that the realm string passed to the BasicAuthenticator >> constructor is a quoted-string, as per RFC7230 [1]. A Utils class is added >> to jdk.httpserver/sun.net.httpserver that holds the new isQuotedString() >> method and the pre-existing isValidName() method (previously in ServerImpl.) >> Two tests are included: >> - BasicAuthenticatorRealm.java to check that Latin-1 chars in the realm >> string are transported correctly, >> - BasicAuthenticatorExceptionCheck.java to check realm strings with escaped >> quotes. >> >> Testing: tier 1-3. >> >> [1] https://datatracker.ietf.org/doc/html/rfc7230 > > Julia Boes has updated the pull request incrementally with one additional > commit since the last revision: > > address PR comments > * change method name to isQuotedStringContent > * update api note and throws declaration Marked as reviewed by dfuchs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6117
Re: RFR: 8275534: com.sun.net.httpserver.BasicAuthenticator should check whether "realm" is a quoted string [v2]
> This change ensures that the realm string passed to the BasicAuthenticator > constructor is a quoted-string, as per RFC7230 [1]. A Utils class is added to > jdk.httpserver/sun.net.httpserver that holds the new isQuotedString() method > and the pre-existing isValidName() method (previously in ServerImpl.) > Two tests are included: > - BasicAuthenticatorRealm.java to check that Latin-1 chars in the realm > string are transported correctly, > - BasicAuthenticatorExceptionCheck.java to check realm strings with escaped > quotes. > > Testing: tier 1-3. > > [1] https://datatracker.ietf.org/doc/html/rfc7230 Julia Boes has updated the pull request incrementally with one additional commit since the last revision: address PR comments * change method name to isQuotedStringContent * update api note and throws declaration - Changes: - all: https://git.openjdk.java.net/jdk/pull/6117/files - new: https://git.openjdk.java.net/jdk/pull/6117/files/6cb5ce86..556330d5 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=6117&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=6117&range=00-01 Stats: 16 lines in 2 files changed: 3 ins; 2 del; 11 mod Patch: https://git.openjdk.java.net/jdk/pull/6117.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6117/head:pull/6117 PR: https://git.openjdk.java.net/jdk/pull/6117
Re: RFR: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI [v10]
On Fri, 29 Oct 2021 16:17:46 GMT, Aleksei Efimov wrote: >> This change implements a new service provider interface for host name and >> address resolution, so that java.net.InetAddress API can make use of >> resolvers other than the platform's built-in resolver. >> >> The following API classes are added to `java.net.spi` package to facilitate >> this: >> - `InetAddressResolverProvider` - abstract class defining a service, and >> is, essentially, a factory for `InetAddressResolver` resolvers. >> - `InetAddressResolverProvider.Configuration ` - an interface describing the >> platform's built-in configuration for resolution operations that could be >> used to bootstrap a resolver construction, or to implement partial >> delegation of lookup operations. >> - `InetAddressResolver` - an interface that defines methods for the >> fundamental forward and reverse lookup operations. >> - `InetAddressResolver.LookupPolicy` - a class whose instances describe the >> characteristics of one forward lookup operation. >> >> More details in [JEP-418](https://openjdk.java.net/jeps/418). >> >> Testing: new and existing `tier1:tier3` tests > > Aleksei Efimov has updated the pull request incrementally with one additional > commit since the last revision: > > Replace 'system' with 'the system-wide', move comment section Marked as reviewed by michaelm (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5822
Re: RFR: 8260428: Drop support for pre JDK 1.4 DatagramSocketImpl implementations [v4]
> Hi, > > Could someone please review my changes (and CSR) to drop support for pre JDK > 1.4 `DatagramSocketImpl` implementations? > > These changes propose to drop support for `DatagramSocketImpls` that were > compiled with JDK 1.3 or older, which do not have support for connected > sockets, for peeking at received datagrams, and for joining and leaving a > group at a specific interface. This support is legacy, and should be > relatively safe to remove as such implementations do not compile with JDK 1.4 > or newer. > > Finally, with this set of proposed changes, if you have an `oldImpl`, and > don’t use connect, then the methods `joinGroup` and `leaveGroup` will throw > `NoSuchMethodError`. However, the current behaviour in `DatagramSocketImpl` > is to throw an `UnsupportedOperationsException` for a method not implemented. > Should this set of changes update the `joinGroup` and `leaveGroup` methods in > order to preserve this behaviour? > > CSR: https://bugs.openjdk.java.net/browse/JDK-8274633 > > Kind regards, > > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Merge remote-tracking branch 'origin/master' into JDK-8260428 - Merge remote-tracking branch 'origin/master' into JDK-8260428 - 8260428: Corrected javadoc typos; combined declaration and initialization of variables in DSI; refactored dummy impls in test - Merge remote-tracking branch 'origin/master' into JDK-8260428 - 8260428: Drop support for pre JDK 1.4 DatagramSocketImpl implementations - Changes: - all: https://git.openjdk.java.net/jdk/pull/5887/files - new: https://git.openjdk.java.net/jdk/pull/5887/files/0a920f65..61d1c8ea Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5887&range=03 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5887&range=02-03 Stats: 18461 lines in 524 files changed: 14207 ins; 2238 del; 2016 mod Patch: https://git.openjdk.java.net/jdk/pull/5887.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5887/head:pull/5887 PR: https://git.openjdk.java.net/jdk/pull/5887
