Re: RFR: 8277868: Use Comparable.compare() instead of surrogate code

2021-11-26 Thread Daniel Fuchs
On Fri, 26 Nov 2021 12:46:59 GMT, Сергей Цыпанов  wrote:

> Instead of something like
> 
> long x;
> long y;
> return (x < y) ? -1 : ((x == y) ? 0 : 1);
> 
> we can use `return Long.compare(x, y);`
> 
> All replacements are done with IDE.

Changes to java.net look good. Please obtain approval from reviewers in the 
other areas before integrating.

-

PR: https://git.openjdk.java.net/jdk/pull/6575


RFR: 8277868: Use Comparable.compare() instead of surrogate code

2021-11-26 Thread Сергей Цыпанов
Instead of something like

long x;
long y;
return (x < y) ? -1 : ((x == y) ? 0 : 1);

we can use `return Long.compare(x, y);`

All replacements are done with IDE.

-

Commit messages:
 - 8277868: Use Comparable.compare() instead of surrogate code

Changes: https://git.openjdk.java.net/jdk/pull/6575/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6575&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8277868
  Stats: 70 lines in 12 files changed: 2 ins; 44 del; 24 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6575.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6575/head:pull/6575

PR: https://git.openjdk.java.net/jdk/pull/6575


Re: RFR: 8276166: Remove dead code from MimeTable and MimeEntry

2021-11-26 Thread Сергей Цыпанов
On Fri, 29 Oct 2021 11:20:57 GMT, Сергей Цыпанов  wrote:

> There are unused methods/constructors in mentioned classes that can be safely 
> removed.

Let's wait a bit

-

PR: https://git.openjdk.java.net/jdk/pull/6169


Re: RFR: 8277459: Add jwebserver tool [v3]

2021-11-26 Thread Michael McMahon
On Wed, 24 Nov 2021 17:29:40 GMT, Julia Boes  wrote:

>> This change introduces jwebserver, a dedicated JDK tool for the Simple Web 
>> Server. 
>> 
>> A description is provided in a follow-up comment.
>
> Julia Boes has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   fix whitespace error, add missing code tag

LGTM

-

Marked as reviewed by michaelm (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6497