Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal [v3]

2021-12-01 Thread Stuart Marks 
On Wed, 1 Dec 2021 19:23:59 GMT, Brent Christian  wrote:

>> Here are the code changes for the "Deprecate finalizers in the standard Java 
>> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code 
>> review.
>> 
>> This change makes the indicated deprecations, and updates the API spec for 
>> JEP 421. It also updates the relevant @SuppressWarning annotations.
>> 
>> The CSR has been approved.
>> An automated test build+test run passes cleanly (FWIW :D ).
>
> Brent Christian has updated the pull request with a new target base due to a 
> merge or a rebase. The pull request now contains 33 commits:
> 
>  - Merge branch 'master' into 8276447
>  - Merge branch 'master' into 8276447
>  - merge
>  - @SuppressWarnings(removal) in Windows CKey.java
>  - Add jls tag to runFinalization methods
>  - Update wording of Object.finalize, new paragraph is now bold
>  - update Object.finalize javadoc
>  - update Object.finalize JavaDoc and @deprecated tag
>  - Update Object.finalize deprecation message
>  - Indicate that runFinalizers does nothing if finalization is disabled or 
> removed
>  - ... and 23 more: 
> https://git.openjdk.java.net/jdk/compare/0dfb3a70...8cde0674

Marked as reviewed by smarks (Reviewer).

src/jdk.jconsole/share/classes/sun/tools/jconsole/SummaryTab.java line 116:

> 114: StringBuilder buf;
> 115: 
> 116: @SuppressWarnings("deprecation")

Item for future cleanup: refactor the call to 
`getObjectPendingFinalizationCount()` at line 219 (!) into a local variable 
declaration, and then move the warnings suppression to that declaration. This 
reduces the scope of warnings suppression.

-

PR: https://git.openjdk.java.net/jdk/pull/6465

Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal [v3]

2021-12-01 Thread Brent Christian 
> Here are the code changes for the "Deprecate finalizers in the standard Java 
> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code 
> review.
> 
> This change makes the indicated deprecations, and updates the API spec for 
> JEP 421. It also updates the relevant @SuppressWarning annotations.
> 
> The CSR has been approved.
> An automated test build+test run passes cleanly (FWIW :D ).

Brent Christian has updated the pull request with a new target base due to a 
merge or a rebase. The pull request now contains 33 commits:

 - Merge branch 'master' into 8276447
 - Merge branch 'master' into 8276447
 - merge
 - @SuppressWarnings(removal) in Windows CKey.java
 - Add jls tag to runFinalization methods
 - Update wording of Object.finalize, new paragraph is now bold
 - update Object.finalize javadoc
 - update Object.finalize JavaDoc and @deprecated tag
 - Update Object.finalize deprecation message
 - Indicate that runFinalizers does nothing if finalization is disabled or 
removed
 - ... and 23 more: https://git.openjdk.java.net/jdk/compare/0dfb3a70...8cde0674

-

Changes: https://git.openjdk.java.net/jdk/pull/6465/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6465&range=02
  Stats: 194 lines in 62 files changed: 54 ins; 38 del; 102 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6465.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6465/head:pull/6465

PR: https://git.openjdk.java.net/jdk/pull/6465

Re: RFR: JDK-8276447 Deprecate finalization-related methods for removal [v2]

2021-12-01 Thread Brent Christian 
> Here are the code changes for the "Deprecate finalizers in the standard Java 
> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code 
> review.
> 
> This change makes the indicated deprecations, and updates the API spec for 
> JEP 421. It also updates the relevant @SuppressWarning annotations.
> 
> The CSR has been approved.
> An automated test build+test run passes cleanly (FWIW :D ).

Brent Christian has updated the pull request with a new target base due to a 
merge or a rebase. The pull request now contains 32 commits:

 - Merge branch 'master' into 8276447
 - merge
 - @SuppressWarnings(removal) in Windows CKey.java
 - Add jls tag to runFinalization methods
 - Update wording of Object.finalize, new paragraph is now bold
 - update Object.finalize javadoc
 - update Object.finalize JavaDoc and @deprecated tag
 - Update Object.finalize deprecation message
 - Indicate that runFinalizers does nothing if finalization is disabled or 
removed
 - Fix @since on @Deprecated for java.lang.Enum
 - ... and 22 more: https://git.openjdk.java.net/jdk/compare/a363b7b9...e4986a48

-

Changes: https://git.openjdk.java.net/jdk/pull/6465/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6465&range=01
  Stats: 194 lines in 62 files changed: 54 ins; 38 del; 102 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6465.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6465/head:pull/6465

PR: https://git.openjdk.java.net/jdk/pull/6465

Re: RFR: 8278028: [test-library] Warnings cleanup of the test library

2021-12-01 Thread Daniel Fuchs 
On Wed, 1 Dec 2021 14:47:54 GMT, Roger Riggs  wrote:

> Compilation warnings of the test library introduce noise in test output and 
> should be addressed or suppressed. 
> Changes include:
>  - SuppressWarnings("deprecation") and SuppressWarnings("removal")
>  - Adding type parameters to Raw types
>  - Adding a hashCode method where equals was already present

Changes look reasonable to me but since I am not familiar with all those files 
it might be best to get at least one additional reviewer.

-

Marked as reviewed by dfuchs (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6638

RFR: 8278028: [test-library] Warnings cleanup of the test library

2021-12-01 Thread Roger Riggs 
Compilation warnings of the test library introduce noise in test output and 
should be addressed or suppressed. 
Changes include:
 - SuppressWarnings("deprecation") and SuppressWarnings("removal")
 - Adding type parameters to Raw types
 - Adding a hashCode method where equals was already present

-

Commit messages:
 - 8278028: [test-library] Warnings cleanup of the test library

Changes: https://git.openjdk.java.net/jdk/pull/6638/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6638&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8278028
  Stats: 23 lines in 14 files changed: 10 ins; 1 del; 12 mod
  Patch: https://git.openjdk.java.net/jdk/pull/6638.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/6638/head:pull/6638

PR: https://git.openjdk.java.net/jdk/pull/6638

Integrated: 8277459: Add jwebserver tool

2021-12-01 Thread Julia Boes 
On Mon, 22 Nov 2021 09:43:19 GMT, Julia Boes  wrote:

> This change introduces jwebserver, a dedicated JDK tool for the Simple Web 
> Server. 
> 
> A description is provided in a follow-up comment.

This pull request has now been integrated.

Changeset: f505396c
Author:Julia Boes 
URL:   
https://git.openjdk.java.net/jdk/commit/f505396cccdd00a284b516dee1e314d1bf285f9e
Stats: 682 lines in 17 files changed: 587 ins; 27 del; 68 mod

8277459: Add jwebserver tool

Reviewed-by: michaelm, dfuchs, ihse

-

PR: https://git.openjdk.java.net/jdk/pull/6497