Re: [jdk10] (XXS) RFR 8189631 : Missing space in the javadoc for InetAddress.createNameService()

2017-11-14 Thread Bradford Wetmore 

+1.

Brad


On 11/14/2017 11:47 AM, Roger Riggs wrote:

+1, Reviewed

Roger


On 11/14/2017 2:45 PM, Ivan Gerasimov wrote:

Hello!

A typo in the javadoc:

--- a/src/java.base/share/classes/java/net/InetAddress.java
+++ b/src/java.base/share/classes/java/net/InetAddress.java
@@ -1133,7 +1133,7 @@
 /**
  * Create an instance of the NameService interface based on
- * the setting of the {@codejdk.net.hosts.file} system property.
+ * the setting of the {@code jdk.net.hosts.file} system property.
  *
  * The default NameService is the PlatformNameService, which 
typically

  * delegates name and address resolution calls to the underlying


Would you approve the fix?

Re: [jdk10] (XXS) RFR 8189631 : Missing space in the javadoc for InetAddress.createNameService()

2017-11-14 Thread Roger Riggs 

+1, Reviewed

Roger


On 11/14/2017 2:45 PM, Ivan Gerasimov wrote:

Hello!

A typo in the javadoc:

--- a/src/java.base/share/classes/java/net/InetAddress.java
+++ b/src/java.base/share/classes/java/net/InetAddress.java
@@ -1133,7 +1133,7 @@
 /**
  * Create an instance of the NameService interface based on
- * the setting of the {@codejdk.net.hosts.file} system property.
+ * the setting of the {@code jdk.net.hosts.file} system property.
  *
  * The default NameService is the PlatformNameService, which 
typically

  * delegates name and address resolution calls to the underlying


Would you approve the fix?

[jdk10] (XXS) RFR 8189631 : Missing space in the javadoc for InetAddress.createNameService()

2017-11-14 Thread Ivan Gerasimov 

Hello!

A typo in the javadoc:

--- a/src/java.base/share/classes/java/net/InetAddress.java
+++ b/src/java.base/share/classes/java/net/InetAddress.java
@@ -1133,7 +1133,7 @@
 /**
  * Create an instance of the NameService interface based on
- * the setting of the {@codejdk.net.hosts.file} system property.
+ * the setting of the {@code jdk.net.hosts.file} system property.
  *
  * The default NameService is the PlatformNameService, which 
typically

  * delegates name and address resolution calls to the underlying


Would you approve the fix?

--
With kind regards,
Ivan Gerasimov