Re: 8150234: Windows 10 App Containers disallow access to ICMP calls

2016-04-05 Thread Chris Hegarty
I think this is fine Rob.

-Chris.

On 29 Mar 2016, at 15:38, Rob McKenna  wrote:

> Hi folks,
> 
> Looking for a review for this change.
> 
> Basically https://bugs.openjdk.java.net/browse/JDK-8135305 abandoned the old 
> TCP echo isReachable check in favour of Windows' ICMP calls on supported 
> platforms. Unfortunately it turns out that Windows 10's new App Containers 
> don't actually allow access to these calls. This fix adds a check to see if 
> access to those calls is allowed on those supported platforms and if not, 
> falls back to the old TCP method.
> 
> http://cr.openjdk.java.net/~robm/8150234/webrev.01/
> 
>-Rob



8150234: Windows 10 App Containers disallow access to ICMP calls

2016-03-29 Thread Rob McKenna
Hi folks,

Looking for a review for this change.

Basically https://bugs.openjdk.java.net/browse/JDK-8135305 abandoned the old 
TCP echo isReachable check in favour of Windows' ICMP calls on supported 
platforms. Unfortunately it turns out that Windows 10's new App Containers 
don't actually allow access to these calls. This fix adds a check to see if 
access to those calls is allowed on those supported platforms and if not, falls 
back to the old TCP method.

http://cr.openjdk.java.net/~robm/8150234/webrev.01/

-Rob