Re: Code Review 6973030: NTLM proxy authentication fails with https

2010-08-03 Thread Chris Hegarty



On 07/30/10 14:44, Michael McMahon wrote:

Chris Hegarty wrote:

Michael,

Send the Proxy-Connection: keep-alive header with HTTP CONNECT
requests for compatibility with HTTP/1.0 proxies such as Squid. This
is required for NTLM authentication.

Webrev:
http://cr.openjdk.java.net/~chegar/6973030/webrev.00/webrev/

Thanks,
-Chris.

Looks fine to me.


Michael, I updated an existing test to verify that the Proxy-Connection 
header is being sent. Can you please take a quick look?


Updated Webrev:
  http://cr.openjdk.java.net/~chegar/6973030/webrev.01/webrev/

Thanks,
-Chris.



- Michael.


Re: Code Review 6973030: NTLM proxy authentication fails with https

2010-08-03 Thread Michael McMahon

Chris Hegarty wrote:



On 07/30/10 14:44, Michael McMahon wrote:

Chris Hegarty wrote:

Michael,

Send the Proxy-Connection: keep-alive header with HTTP CONNECT
requests for compatibility with HTTP/1.0 proxies such as Squid. This
is required for NTLM authentication.

Webrev:
http://cr.openjdk.java.net/~chegar/6973030/webrev.00/webrev/

Thanks,
-Chris.

Looks fine to me.


Michael, I updated an existing test to verify that the 
Proxy-Connection header is being sent. Can you please take a quick look?


Updated Webrev:
  http://cr.openjdk.java.net/~chegar/6973030/webrev.01/webrev/

Thanks,
-Chris.


looks fine.

Thanks,
Michael.


- Michael.




Re: Code Review 6973030: NTLM proxy authentication fails with https

2010-07-30 Thread Michael McMahon

Chris Hegarty wrote:

Michael,

Send the Proxy-Connection: keep-alive header with HTTP CONNECT 
requests for compatibility with HTTP/1.0 proxies such as Squid. This 
is required for NTLM authentication.


Webrev:
  http://cr.openjdk.java.net/~chegar/6973030/webrev.00/webrev/

Thanks,
-Chris.

Looks fine to me.

- Michael.


Code Review 6973030: NTLM proxy authentication fails with https

2010-07-29 Thread Chris Hegarty

Michael,

Send the Proxy-Connection: keep-alive header with HTTP CONNECT 
requests for compatibility with HTTP/1.0 proxies such as Squid. This is 
required for NTLM authentication.


Webrev:
  http://cr.openjdk.java.net/~chegar/6973030/webrev.00/webrev/

Thanks,
-Chris.