Re: Code Review Request: 7154502: IAE: Illegal character(s) in message header field from HttpURLConnection.checkMessageHeader

2012-06-21 Thread Chris Hegarty 
This change looks fine to me.

-Chris

On 21 Jun 2012, at 18:53, Kurchi Subhra Hazra  
wrote:

> Hi,
> 
>   Currently HttpURLConnection.setRequestProperty() does not
> document that it can throw an IllegalArgumentException. However, this method 
> does
> throw an IAE if the key or value contains illegal characters. The same applies
> for HttpURLConnection.addRequestProperty(), and this webrev tries to address 
> this
> issue.
> 
> Bug: http://bugs.sun.com/view_bug.do?bug_id=7154502
> Webrev: http://cr.openjdk.java.net/~khazra/7154502/webrev.00/
> 
> Thanks,
> Kurchi
> 
>

Code Review Request: 7154502: IAE: Illegal character(s) in message header field from HttpURLConnection.checkMessageHeader

2012-06-21 Thread Kurchi Subhra Hazra 

Hi,

   Currently HttpURLConnection.setRequestProperty() does not
document that it can throw an IllegalArgumentException. However, this method 
does
throw an IAE if the key or value contains illegal characters. The same applies
for HttpURLConnection.addRequestProperty(), and this webrev tries to address 
this
issue.

Bug: http://bugs.sun.com/view_bug.do?bug_id=7154502
Webrev: http://cr.openjdk.java.net/~khazra/7154502/webrev.00/

Thanks,
Kurchi