Re: Code review: 7200720: crash in net.dll during NTLM authentication
Michael, NTLMAuthentication.java: 1. Copyright year should be either fixed or not changed 2. I think it's better to remove bug id from comments and replace comment like // MMM 7200720 ?? to something better. NTLMAuthSequence.c 1. Copyright ... Otherwise looks good for me. -Dmitry On 2012-11-28 17:47, Michael McMahon wrote: > On 23/11/12 16:16, Alan Bateman wrote: >> On 23/11/2012 15:59, Michael McMahon wrote: >>> Could I get the following change reviewed please? >>> There was a crash caused by accessing freed memory when >>> authentication was repeated in the same HttpURLConnection instance/ >>> >>> http://cr.openjdk.java.net/~michaelm/7200720/webrev.1/ >> I haven't reviewed the changes but I notice this changes the build >> slightly so I just wonder if you've checked the new build. >> >> -Alan > > just checked the new build on Linux and it's fine. > There are a couple of other fixes that will follow this one > related to this problem. But, I'd like to go ahead and push this one first > if possible > > - Michael -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * Give Rabbit time, and he'll always get the answer
Re: Code review: 7200720: crash in net.dll during NTLM authentication
I'm ok with this change. -Chris. On 23/11/2012 15:59, Michael McMahon wrote: Could I get the following change reviewed please? There was a crash caused by accessing freed memory when authentication was repeated in the same HttpURLConnection instance/ http://cr.openjdk.java.net/~michaelm/7200720/webrev.1/ Thanks Michael
Re: Code review: 7200720: crash in net.dll during NTLM authentication
On 28/11/2012 13:47, Michael McMahon wrote: just checked the new build on Linux and it's fine. There are a couple of other fixes that will follow this one related to this problem. But, I'd like to go ahead and push this one first if possible - Michael Thanks for checking. I don't have cycles at the moment to review this but hopefully Max or Chris will at they are familiar with this code. -Alan
Re: Code review: 7200720: crash in net.dll during NTLM authentication
On 23/11/12 16:16, Alan Bateman wrote: On 23/11/2012 15:59, Michael McMahon wrote: Could I get the following change reviewed please? There was a crash caused by accessing freed memory when authentication was repeated in the same HttpURLConnection instance/ http://cr.openjdk.java.net/~michaelm/7200720/webrev.1/ I haven't reviewed the changes but I notice this changes the build slightly so I just wonder if you've checked the new build. -Alan just checked the new build on Linux and it's fine. There are a couple of other fixes that will follow this one related to this problem. But, I'd like to go ahead and push this one first if possible - Michael
Re: Code review: 7200720: crash in net.dll during NTLM authentication
On 23/11/12 16:16, Alan Bateman wrote: On 23/11/2012 15:59, Michael McMahon wrote: Could I get the following change reviewed please? There was a crash caused by accessing freed memory when authentication was repeated in the same HttpURLConnection instance/ http://cr.openjdk.java.net/~michaelm/7200720/webrev.1/ I haven't reviewed the changes but I notice this changes the build slightly so I just wonder if you've checked the new build. -Alan Ah right, the makefile change is not essential, but I will check it with the new build - Michael
Re: Code review: 7200720: crash in net.dll during NTLM authentication
On 23/11/2012 15:59, Michael McMahon wrote: Could I get the following change reviewed please? There was a crash caused by accessing freed memory when authentication was repeated in the same HttpURLConnection instance/ http://cr.openjdk.java.net/~michaelm/7200720/webrev.1/ I haven't reviewed the changes but I notice this changes the build slightly so I just wonder if you've checked the new build. -Alan
Code review: 7200720: crash in net.dll during NTLM authentication
Could I get the following change reviewed please? There was a crash caused by accessing freed memory when authentication was repeated in the same HttpURLConnection instance/ http://cr.openjdk.java.net/~michaelm/7200720/webrev.1/ Thanks Michael
