Re: Code review: 8003948 (jdk8)

2012-12-10 Thread Dmitry Samersoff 
Michael,

150  It might be better to use regionMatches here

162 Is it intentional to always don't copy keys[0]/value[0] ?

   Actually I would prefer to have this code better readable,
   something like -

157 if ( !  ){
   keys[j]=keys[j];
   value[j]=value[j];
   ++j
}

-Dmitry



On 2012-12-10 18:30, Michael McMahon wrote:
> Could I get the following change reviewed please?
> 
> http://cr.openjdk.java.net/~michaelm/8003948/webrev.1/
> 
> We need to filter out extraneous authentication headers when doing
> ntlm authentication with MS web servers and proxies.
> 
> Thanks
> Michael


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer

Re: Code review: 8003948 (jdk8)

2012-12-10 Thread Michael McMahon 

Thanks!

On 10/12/12 14:50, Chris Hegarty wrote:

On 10/12/2012 14:34, Weijun Wang wrote:

Looks fine.


+1

-Chris



-Max

On 12/10/2012 10:30 PM, Michael McMahon wrote:

Could I get the following change reviewed please?

http://cr.openjdk.java.net/~michaelm/8003948/webrev.1/

We need to filter out extraneous authentication headers when doing
ntlm authentication with MS web servers and proxies.

Thanks
Michael

Re: Code review: 8003948 (jdk8)

2012-12-10 Thread Chris Hegarty 

On 10/12/2012 14:34, Weijun Wang wrote:

Looks fine.


+1

-Chris



-Max

On 12/10/2012 10:30 PM, Michael McMahon wrote:

Could I get the following change reviewed please?

http://cr.openjdk.java.net/~michaelm/8003948/webrev.1/

We need to filter out extraneous authentication headers when doing
ntlm authentication with MS web servers and proxies.

Thanks
Michael

Re: Code review: 8003948 (jdk8)

2012-12-10 Thread Weijun Wang 

Looks fine.

-Max

On 12/10/2012 10:30 PM, Michael McMahon wrote:

Could I get the following change reviewed please?

http://cr.openjdk.java.net/~michaelm/8003948/webrev.1/

We need to filter out extraneous authentication headers when doing
ntlm authentication with MS web servers and proxies.

Thanks
Michael

Code review: 8003948 (jdk8)

2012-12-10 Thread Michael McMahon 

Could I get the following change reviewed please?

http://cr.openjdk.java.net/~michaelm/8003948/webrev.1/

We need to filter out extraneous authentication headers when doing
ntlm authentication with MS web servers and proxies.

Thanks
Michael