Re: RFR: 8135305: InetAddress.isReachable reports true when loopback interface is specified

2015-09-30 Thread Michael McMahon 

Looks fine to me Rob

- Michael

On 25/09/15 13:54, Rob McKenna wrote:

Good point. I'll remove that pre-push.

-Rob

On 25/09/15 11:57, Mark Sheppard wrote:


Hi Rob,
looks fine ...  the "him" variable in the

Java_java_net_Inet4AddressImpl_isReachable0

would appear not to be used now, so could probably be removed with its
call on memset ?

regards
Mark

On 24/09/2015 15:45, Rob McKenna wrote:

Please ignore the formatting errors. Thats either a problem with hg
diff or webrev, but its fixed in the repo.

-Rob

On 24/09/15 15:43, Rob McKenna wrote:

Hi folks,

The recent change to isReachable (8133015:
InetAddress.isReachable(tmout) returning wrong value on Windows for 
IPv6

- http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/59ff6cd9535d) neglected
to take the specified interface into account for ipv4.

This change ensures that isReachable returns false for external hosts
when the loopback interface is specified.

http://cr.openjdk.java.net/~robm/8135305/webrev.01/

 -Rob

Re: RFR: 8135305: InetAddress.isReachable reports true when loopback interface is specified

2015-09-25 Thread Mark Sheppard 


Hi Rob,
   looks fine ...  the "him" variable in the

Java_java_net_Inet4AddressImpl_isReachable0

would appear not to be used now, so could probably be removed with its  
call on memset ?


regards
Mark

On 24/09/2015 15:45, Rob McKenna wrote:
Please ignore the formatting errors. Thats either a problem with hg 
diff or webrev, but its fixed in the repo.


-Rob

On 24/09/15 15:43, Rob McKenna wrote:

Hi folks,

The recent change to isReachable (8133015:
InetAddress.isReachable(tmout) returning wrong value on Windows for IPv6
- http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/59ff6cd9535d) neglected
to take the specified interface into account for ipv4.

This change ensures that isReachable returns false for external hosts
when the loopback interface is specified.

http://cr.openjdk.java.net/~robm/8135305/webrev.01/

 -Rob

Re: RFR: 8135305: InetAddress.isReachable reports true when loopback interface is specified

2015-09-25 Thread Rob McKenna 

Good point. I'll remove that pre-push.

-Rob

On 25/09/15 11:57, Mark Sheppard wrote:


Hi Rob,
looks fine ...  the "him" variable in the

Java_java_net_Inet4AddressImpl_isReachable0

would appear not to be used now, so could probably be removed with its
call on memset ?

regards
Mark

On 24/09/2015 15:45, Rob McKenna wrote:

Please ignore the formatting errors. Thats either a problem with hg
diff or webrev, but its fixed in the repo.

-Rob

On 24/09/15 15:43, Rob McKenna wrote:

Hi folks,

The recent change to isReachable (8133015:
InetAddress.isReachable(tmout) returning wrong value on Windows for IPv6
- http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/59ff6cd9535d) neglected
to take the specified interface into account for ipv4.

This change ensures that isReachable returns false for external hosts
when the loopback interface is specified.

http://cr.openjdk.java.net/~robm/8135305/webrev.01/

 -Rob

RFR: 8135305: InetAddress.isReachable reports true when loopback interface is specified

2015-09-24 Thread Rob McKenna 

Hi folks,

The recent change to isReachable (8133015: 
InetAddress.isReachable(tmout) returning wrong value on Windows for IPv6 
- http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/59ff6cd9535d) neglected 
to take the specified interface into account for ipv4.


This change ensures that isReachable returns false for external hosts 
when the loopback interface is specified.


http://cr.openjdk.java.net/~robm/8135305/webrev.01/

-Rob

Re: RFR: 8135305: InetAddress.isReachable reports true when loopback interface is specified

2015-09-24 Thread Rob McKenna 
Please ignore the formatting errors. Thats either a problem with hg diff 
or webrev, but its fixed in the repo.


-Rob

On 24/09/15 15:43, Rob McKenna wrote:

Hi folks,

The recent change to isReachable (8133015:
InetAddress.isReachable(tmout) returning wrong value on Windows for IPv6
- http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/59ff6cd9535d) neglected
to take the specified interface into account for ipv4.

This change ensures that isReachable returns false for external hosts
when the loopback interface is specified.

http://cr.openjdk.java.net/~robm/8135305/webrev.01/

 -Rob