Re: RFR: 8146526: Improve java.net.URI$Parser startup characteristics

2016-01-06 Thread Claes Redestad 

On 2016-01-06 08:43, Alan Bateman wrote:

On 05/01/2016 22:47, Claes Redestad wrote:

Hi,

please review this patch to cleanup URI$Parser to help URI 
construction when run with the interpreter, mostly by inlining 
wrapping methods:


Bug: https://bugs.openjdk.java.net/browse/JDK-8146526

Webrev: http://cr.openjdk.java.net/~redestad/8146526/webrev.01

This looks good to me.


Thanks for looking at this, Alan and Chris!

/Claes

Re: RFR: 8146526: Improve java.net.URI$Parser startup characteristics

2016-01-05 Thread Alan Bateman 

On 05/01/2016 22:47, Claes Redestad wrote:

Hi,

please review this patch to cleanup URI$Parser to help URI 
construction when run with the interpreter, mostly by inlining 
wrapping methods:


Bug: https://bugs.openjdk.java.net/browse/JDK-8146526

Webrev: http://cr.openjdk.java.net/~redestad/8146526/webrev.01

This looks good to me.

-Alan

Re: RFR: 8146526: Improve java.net.URI$Parser startup characteristics

2016-01-05 Thread Chris Hegarty 
On 5 Jan 2016, at 22:47, Claes Redestad  wrote:

> Hi,
> 
> please review this patch to cleanup URI$Parser to help URI construction when 
> run with the interpreter, mostly by inlining wrapping methods:
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8146526
> 
> Webrev: http://cr.openjdk.java.net/~redestad/8146526/webrev.01

This looks like a nice straight forward cleanup/change. Thanks Claes.

> This is motivated by Jigsaw where URIs might be created unconditionally 
> during startup, and this trivial patch is extracted from an experiment to 
> address observed inefficiencies in java.net.URI[1]. Around half the 
> improvement detailed in [1] can be attributed to this patch, while it does 
> not impact compiled code performance.

Good to hear.

-Chris.

> Thanks!
> 
> /Claes
> 
> [1]http://cr.openjdk.java.net/~redestad/scratch/URIParserBench.java

RFR: 8146526: Improve java.net.URI$Parser startup characteristics

2016-01-05 Thread Claes Redestad 

Hi,

please review this patch to cleanup URI$Parser to help URI construction 
when run with the interpreter, mostly by inlining wrapping methods:


Bug: https://bugs.openjdk.java.net/browse/JDK-8146526

Webrev: http://cr.openjdk.java.net/~redestad/8146526/webrev.01

This is motivated by Jigsaw where URIs might be created unconditionally 
during startup, and this trivial patch is extracted from an experiment 
to address observed inefficiencies in java.net.URI[1]. Around half the 
improvement detailed in [1] can be attributed to this patch, while it 
does not impact compiled code performance.


Thanks!

/Claes

[1]http://cr.openjdk.java.net/~redestad/scratch/URIParserBench.java