Re: RFR: 8154238: Drop code to support Windows XP in windows socket impl
On 18/04/16 11:09, Claes Redestad wrote: On 04/18/2016 12:06 PM, Chris Hegarty wrote: On 18/04/16 11:01, Alan Bateman wrote: On 18/04/2016 10:45, Chris Hegarty wrote: The changes look fine. Maybe the bug description should be updated a before pushing, it looks like it affects only legacy networking code and not NIO. Maybe "... and async channels" ? The changes to the NIO code look okay but probably should be split into their own issue for tracking purposes. That works for me. -Chris. New webrev only with the PlainSocket changes: http://cr.openjdk.java.net/~redestad/8154238/webrev.02/ Looks fine. -Chris I'll file a bug and send out a RFR for the other changes shortly /Claes
Re: RFR: 8154238: Drop code to support Windows XP in windows socket impl
On 04/18/2016 12:06 PM, Chris Hegarty wrote: On 18/04/16 11:01, Alan Bateman wrote: On 18/04/2016 10:45, Chris Hegarty wrote: The changes look fine. Maybe the bug description should be updated a before pushing, it looks like it affects only legacy networking code and not NIO. Maybe "... and async channels" ? The changes to the NIO code look okay but probably should be split into their own issue for tracking purposes. That works for me. -Chris. New webrev only with the PlainSocket changes: http://cr.openjdk.java.net/~redestad/8154238/webrev.02/ I'll file a bug and send out a RFR for the other changes shortly /Claes
Re: RFR: 8154238: Drop code to support Windows XP in windows socket impl
On 18/04/16 11:01, Alan Bateman wrote: On 18/04/2016 10:45, Chris Hegarty wrote: The changes look fine. Maybe the bug description should be updated a before pushing, it looks like it affects only legacy networking code and not NIO. Maybe "... and async channels" ? The changes to the NIO code look okay but probably should be split into their own issue for tracking purposes. That works for me. -Chris.
Re: RFR: 8154238: Drop code to support Windows XP in windows socket impl
On 04/18/2016 12:01 PM, Alan Bateman wrote: On 18/04/2016 10:45, Chris Hegarty wrote: The changes look fine. Maybe the bug description should be updated a before pushing, it looks like it affects only legacy networking code and not NIO. Maybe "... and async channels" ? The changes to the NIO code look okay but probably should be split into their own issue for tracking purposes. Ah, now I get what Chris meant. Sure. I'll break those off to a separate bug. /Claes
Re: RFR: 8154238: Drop code to support Windows XP in windows socket impl
On 04/18/2016 11:45 AM, Chris Hegarty wrote: On 14/04/16 13:49, Claes Redestad wrote: Hi, more code in the Windows socket implementation that can be dropped Bug: https://bugs.openjdk.java.net/browse/JDK-8154238 Webrev: http://cr.openjdk.java.net/~redestad/8154238/webrev.01/ The changes look fine. Thanks Chris! Maybe the bug description should be updated a before pushing, it looks like it affects only legacy networking code and not NIO. Maybe "... and async channels" ? Not sure where you saw NIO mentioned. Does "Drop code to support Windows XP in windows socket and async channel impls" sound better? Thanks! /Claes
Re: RFR: 8154238: Drop code to support Windows XP in windows socket impl
On 18/04/2016 10:45, Chris Hegarty wrote: The changes look fine. Maybe the bug description should be updated a before pushing, it looks like it affects only legacy networking code and not NIO. Maybe "... and async channels" ? The changes to the NIO code look okay but probably should be split into their own issue for tracking purposes. -Alan
Re: RFR: 8154238: Drop code to support Windows XP in windows socket impl
On 14/04/16 13:49, Claes Redestad wrote: Hi, more code in the Windows socket implementation that can be dropped Bug: https://bugs.openjdk.java.net/browse/JDK-8154238 Webrev: http://cr.openjdk.java.net/~redestad/8154238/webrev.01/ The changes look fine. Maybe the bug description should be updated a before pushing, it looks like it affects only legacy networking code and not NIO. Maybe "... and async channels" ? -Chris.
RFR: 8154238: Drop code to support Windows XP in windows socket impl
Hi, more code in the Windows socket implementation that can be dropped Bug: https://bugs.openjdk.java.net/browse/JDK-8154238 Webrev: http://cr.openjdk.java.net/~redestad/8154238/webrev.01/ Thanks! /Claes
