Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v5]
On Fri, 2 Jul 2021 16:14:25 GMT, Brian Burkhalter wrote:
>> Please review this change to the Unix implementations of
>> `sun.nio.ch.sctp.Sctp*ChannelImpl#kill()` to close the socket if `state ==
>> ChannelState.UNINITIALIZED`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8269481: In test use othervm mode and an automatically allocated port
test/jdk/com/sun/nio/sctp/SctpMultiChannel/CloseDescriptors.java line 92:
> 90: if (nfds > 3) {
> 91: String msg =
> 92: String.format("Number of open descriptors (%d) > 2%n",
> nfds);
Hello Brian,
The if condition checks for `> 3` whereas the error message states `> 2`.
Should the error message be changed? Also, I see that there's a `MAX_DESC`
constant in this test, but from what I can see isn't used anywhere? Perhaps
that's the constant you wanted to use in this if block and the error message?
-
PR: https://git.openjdk.java.net/jdk/pull/4621
Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v5]
On Fri, 2 Jul 2021 16:14:25 GMT, Brian Burkhalter wrote: >> Please review this change to the Unix implementations of >> `sun.nio.ch.sctp.Sctp*ChannelImpl#kill()` to close the socket if `state == >> ChannelState.UNINITIALIZED`. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8269481: In test use othervm mode and an automatically allocated port Sure, no problem. - PR: https://git.openjdk.java.net/jdk/pull/4621
Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v5]
On Fri, 2 Jul 2021 16:14:25 GMT, Brian Burkhalter wrote: >> Please review this change to the Unix implementations of >> `sun.nio.ch.sctp.Sctp*ChannelImpl#kill()` to close the socket if `state == >> ChannelState.UNINITIALIZED`. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8269481: In test use othervm mode and an automatically allocated port Thanks for the update. You should probably wait for Chris as he had comments on this too. - Marked as reviewed by alanb (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4621
Re: RFR: 8269481: SctpMultiChannel never releases own file descriptor [v5]
> Please review this change to the Unix implementations of > `sun.nio.ch.sctp.Sctp*ChannelImpl#kill()` to close the socket if `state == > ChannelState.UNINITIALIZED`. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8269481: In test use othervm mode and an automatically allocated port - Changes: - all: https://git.openjdk.java.net/jdk/pull/4621/files - new: https://git.openjdk.java.net/jdk/pull/4621/files/676c0f0a..8ca5b5c0 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=4621=04 - incr: https://webrevs.openjdk.java.net/?repo=jdk=4621=03-04 Stats: 23 lines in 1 file changed: 5 ins; 8 del; 10 mod Patch: https://git.openjdk.java.net/jdk/pull/4621.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4621/head:pull/4621 PR: https://git.openjdk.java.net/jdk/pull/4621
