Re: RFR: 8273655: content-types.properties files are missing some common types [v2]
On Thu, 16 Sep 2021 15:28:36 GMT, Julia Boes wrote: >> This change adds some common types to the content-type.properties files, >> notably .js, .css, and .jar, as well as some others. >> >> The duplicated entry for .zip is removed from the Windows properties file. > > Julia Boes has updated the pull request incrementally with one additional > commit since the last revision: > > address PR comments and refactor test Marked as reviewed by dfuchs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5506
Re: RFR: 8273655: content-types.properties files are missing some common types [v2]
On Thu, 16 Sep 2021 15:28:36 GMT, Julia Boes wrote: >> This change adds some common types to the content-type.properties files, >> notably .js, .css, and .jar, as well as some others. >> >> The duplicated entry for .zip is removed from the Windows properties file. > > Julia Boes has updated the pull request incrementally with one additional > commit since the last revision: > > address PR comments and refactor test Marked as reviewed by bpb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5506
Re: RFR: 8273655: content-types.properties files are missing some common types [v2]
On Thu, 16 Sep 2021 18:06:53 GMT, Phil Race wrote: > I don't understand why these files are platform-specific. > And if each platform port does need one, where is the one for macOS ? I'm not an expert in the area, it's probably down to historic reasons? The Unix version would be for all Unix varieties, unless a more specific source file is provided (thanks to @Michael-Mc-Mahon). - PR: https://git.openjdk.java.net/jdk/pull/5506
Re: RFR: 8273655: content-types.properties files are missing some common types [v2]
On Thu, 16 Sep 2021 15:28:36 GMT, Julia Boes wrote: >> This change adds some common types to the content-type.properties files, >> notably .js, .css, and .jar, as well as some others. >> >> The duplicated entry for .zip is removed from the Windows properties file. > > Julia Boes has updated the pull request incrementally with one additional > commit since the last revision: > > address PR comments and refactor test I don't understand why these files are platform-specific. And if each platform port does need one, where is the one for macOS ? - PR: https://git.openjdk.java.net/jdk/pull/5506
Re: RFR: 8273655: content-types.properties files are missing some common types [v2]
On Thu, 16 Sep 2021 15:28:36 GMT, Julia Boes wrote: >> This change adds some common types to the content-type.properties files, >> notably .js, .css, and .jar, as well as some others. >> >> The duplicated entry for .zip is removed from the Windows properties file. > > Julia Boes has updated the pull request incrementally with one additional > commit since the last revision: > > address PR comments and refactor test @anthonyvdotbe Thanks for the comments, I incorporated them with one exception: I didn't add typescript (.ts) as it conflicts with MPEG transport stream on several platforms. A note on the test: I refactored it slightly to account for platform-specific type detection, for example in the case of .js, which is mapped to `application/javascript` on linux-aarch64 rather than `text/javascript`. The reason for this deviation is that the test uses `Files.probeContentType`, which only falls back to the content-types.properties file if no file type detector is installed. Testing: tier1-3 all clear. - PR: https://git.openjdk.java.net/jdk/pull/5506
Re: RFR: 8273655: content-types.properties files are missing some common types [v2]
> This change adds some common types to the content-type.properties files, > notably .js, .css, and .jar, as well as some others. > > The duplicated entry for .zip is removed from the Windows properties file. Julia Boes has updated the pull request incrementally with one additional commit since the last revision: address PR comments and refactor test - Changes: - all: https://git.openjdk.java.net/jdk/pull/5506/files - new: https://git.openjdk.java.net/jdk/pull/5506/files/63565c5b..c7512889 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5506&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5506&range=00-01 Stats: 179 lines in 3 files changed: 70 ins; 45 del; 64 mod Patch: https://git.openjdk.java.net/jdk/pull/5506.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5506/head:pull/5506 PR: https://git.openjdk.java.net/jdk/pull/5506
