Re: RFR: 8280161: com/sun/net/httpserver/simpleserver/jwebserver/MaxRequestTimeTest.java fails with SSLException [v2]
On Thu, 20 Jan 2022 09:20:25 GMT, Julia Boes wrote: >> Small test-only fix that generalizes the expected exception type from >> SSLHandshakeException to SSLException (a super class of the former). >> >> Testing: tier 1-3 and repeated runs of test in question all clear > > Julia Boes has updated the pull request incrementally with one additional > commit since the last revision: > > address PR comment: remove bug id in test Marked as reviewed by dfuchs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7144
Re: RFR: 8280161: com/sun/net/httpserver/simpleserver/jwebserver/MaxRequestTimeTest.java fails with SSLException [v2]
On Wed, 19 Jan 2022 17:16:30 GMT, Daniel Fuchs wrote: >> Julia Boes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> address PR comment: remove bug id in test > > test/jdk/com/sun/net/httpserver/simpleserver/jwebserver/MaxRequestTimeTest.java > line 26: > >> 24: /* >> 25: * @test >> 26: * @bug 8278398 8280161 > > No need to add 8280161 since 8280161 is marked as noreg-self. In principle we > only list bugs whose fix contain code changes that can be verified by the > test. Makes sense, thanks for picking up on that. - PR: https://git.openjdk.java.net/jdk/pull/7144
Re: RFR: 8280161: com/sun/net/httpserver/simpleserver/jwebserver/MaxRequestTimeTest.java fails with SSLException [v2]
> Small test-only fix that generalizes the expected exception type from > SSLHandshakeException to SSLException (a super class of the former). > > Testing: tier 1-3 and repeated runs of test in question all clear Julia Boes has updated the pull request incrementally with one additional commit since the last revision: address PR comment: remove bug id in test - Changes: - all: https://git.openjdk.java.net/jdk/pull/7144/files - new: https://git.openjdk.java.net/jdk/pull/7144/files/4fd75abe..6565fcef Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7144&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7144&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/7144.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7144/head:pull/7144 PR: https://git.openjdk.java.net/jdk/pull/7144
Re: RFR: 8280161: com/sun/net/httpserver/simpleserver/jwebserver/MaxRequestTimeTest.java fails with SSLException
On Wed, 19 Jan 2022 17:01:22 GMT, Julia Boes wrote: > Small test-only fix that generalizes the expected exception type from > SSLHandshakeException to SSLException (a super class of the former). > > Testing: tier 1-3 and repeated runs of test in question all clear LGTM - just remove 8280161 from the @bug tag list. test/jdk/com/sun/net/httpserver/simpleserver/jwebserver/MaxRequestTimeTest.java line 26: > 24: /* > 25: * @test > 26: * @bug 8278398 8280161 No need to add 8280161 since 8280161 is marked as noreg-self. In principle we only list bugs whose fix contain code changes that can be verified by the test. - Marked as reviewed by dfuchs (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7144
RFR: 8280161: com/sun/net/httpserver/simpleserver/jwebserver/MaxRequestTimeTest.java fails with SSLException
Small test-only fix that generalizes the expected exception type from SSLHandshakeException to SSLException (a super class of the former). Testing: tier 1-3 and repeated runs of test in question all clear - Commit messages: - initial commit Changes: https://git.openjdk.java.net/jdk/pull/7144/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7144&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8280161 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk/pull/7144.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7144/head:pull/7144 PR: https://git.openjdk.java.net/jdk/pull/7144
