Re: RFR: 8287237: (fs) Files.probeContentType returns null if filename contains hash mark on Linux [v4]

2022-06-01 Thread Brian Burkhalter 
On Wed, 1 Jun 2022 07:28:11 GMT, Vyom Tewari  wrote:

> Looks ok, i tested on centos 7 and it is working as expected.

To really verify it you would have to suppress `~/.mime.types` and 
`/etc/mime.types` before running the test.

-

PR: https://git.openjdk.java.net/jdk/pull/8909

Re: RFR: 8287237: (fs) Files.probeContentType returns null if filename contains hash mark on Linux [v4]

2022-06-01 Thread Vyom Tewari 
On Tue, 31 May 2022 18:29:30 GMT, Brian Burkhalter  wrote:

>> Modify `sun.net.www.MimeTable.findByFileName(String)` to attempt to find the 
>> file extension in the entire file name if it is not found in the portion of 
>> the name preceding the optional fragment beginning with a hash (`#`).
>
> Brian Burkhalter has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8287237: Simplify code a bit

Looks ok, i tested on centos 7 and it is working as expected.

-

Marked as reviewed by vtewari (Committer).

PR: https://git.openjdk.java.net/jdk/pull/8909

Re: RFR: 8287237: (fs) Files.probeContentType returns null if filename contains hash mark on Linux [v4]

2022-05-31 Thread Jaikiran Pai 
On Tue, 31 May 2022 18:29:30 GMT, Brian Burkhalter  wrote:

>> Modify `sun.net.www.MimeTable.findByFileName(String)` to attempt to find the 
>> file extension in the entire file name if it is not found in the portion of 
>> the name preceding the optional fragment beginning with a hash (`#`).
>
> Brian Burkhalter has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8287237: Simplify code a bit

Thank you for the changes, Brian. The current PR looks fine to me.

-

Marked as reviewed by jpai (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8909

Re: RFR: 8287237: (fs) Files.probeContentType returns null if filename contains hash mark on Linux [v4]

2022-05-31 Thread Roger Riggs 
On Tue, 31 May 2022 18:29:30 GMT, Brian Burkhalter  wrote:

>> Modify `sun.net.www.MimeTable.findByFileName(String)` to attempt to find the 
>> file extension in the entire file name if it is not found in the portion of 
>> the name preceding the optional fragment beginning with a hash (`#`).
>
> Brian Burkhalter has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8287237: Simplify code a bit

LGTM

-

Marked as reviewed by rriggs (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8909

Re: RFR: 8287237: (fs) Files.probeContentType returns null if filename contains hash mark on Linux [v4]

2022-05-31 Thread Brian Burkhalter 
> Modify `sun.net.www.MimeTable.findByFileName(String)` to attempt to find the 
> file extension in the entire file name if it is not found in the portion of 
> the name preceding the optional fragment beginning with a hash (`#`).

Brian Burkhalter has updated the pull request incrementally with one additional 
commit since the last revision:

  8287237: Simplify code a bit

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8909/files
  - new: https://git.openjdk.java.net/jdk/pull/8909/files/7c877f9e..b9eb7bbb

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=8909=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=8909=02-03

  Stats: 12 lines in 1 file changed: 0 ins; 4 del; 8 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8909.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8909/head:pull/8909

PR: https://git.openjdk.java.net/jdk/pull/8909