Re: RFR - 8087190: Regression in sun.net.util.IPAddressUtil.isIPv4LiteralAddress(String)

2015-08-25 Thread Chris Hegarty 
Looks good to me too.

-Chris.

On 23 Aug 2015, at 21:04, Claes Redestad claes.redes...@oracle.com wrote:

 Looks good to me.
 
 /Claes (not a Reviewer)
 
 On 2015-08-21 21:49, Rob McKenna wrote:
 Hi folks, looking for a review for this simple change.
 
 The change for https://bugs.openjdk.java.net/browse/JDK-8040747 initialised 
 each octet to 0. This meant that ... was translated to 0.0.0.0 before 
 checking the validity of the address.
 
 This small change remedies that.
 
 http://cr.openjdk.java.net/~robm/8087190/webrev.01/
 
 I just noticed that I neglected to add 8087190 to the @bug tag of 
 textToNumericFormat.java. I'll do that pre-push.
 
-Rob

RFR - 8087190: Regression in sun.net.util.IPAddressUtil.isIPv4LiteralAddress(String)

2015-08-21 Thread Rob McKenna 

Hi folks, looking for a review for this simple change.

The change for https://bugs.openjdk.java.net/browse/JDK-8040747 
initialised each octet to 0. This meant that ... was translated to 
0.0.0.0 before checking the validity of the address.


This small change remedies that.

http://cr.openjdk.java.net/~robm/8087190/webrev.01/

I just noticed that I neglected to add 8087190 to the @bug tag of 
textToNumericFormat.java. I'll do that pre-push.


-Rob