Re: RFR 8157811 [9] Additional minor fixes and cleanups in Networking native code

[Dmitry Samersoff]

Chris,

Looks good for me!

On 2016-05-25 16:22, Chris Hegarty wrote:
> Thanks. I included it, though it may not show in the webrev ( white space 
> change )
> 
> I generalise the issue to cover a few other minor issues.
> 
> Webrev updated in-place:
>   http://cr.openjdk.java.net/~chegar/8157811/
> 
> -Chris.
> 
>> On 25 May 2016, at 13:59, Langer, Christoph  wrote:
>>
>> Hi Chris,
>>
>> looks nice, I had seen some of these places, too.
>>
>> Here is another one which you could add:
>>
>> --- a/src/java.base/unix/native/libnet/NetworkInterface.c   Tue May 24 
>> 10:14:41 2016 -0700
>> +++ b/src/java.base/unix/native/libnet/NetworkInterface.c   Wed May 25 
>> 14:56:31 2016 +0200
>> @@ -1829,7 +1829,7 @@
>> strncpy(if2.lifr_name, ifname, sizeof(if2.lifr_name) - 1);
>>
>> if (ioctl(sock, SIOCGLIFFLAGS, (char *)) < 0) {
>> - return -1;
>> +return -1;
>> }
>>
>> *flags = if2.lifr_flags;
>>
>> Best regards
>> Christoph
>>
>>> -Original Message-
>>> From: net-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of Chris
>>> Hegarty
>>> Sent: Mittwoch, 25. Mai 2016 11:50
>>> To: OpenJDK Network Dev list 
>>> Subject: RFR 8157811 [9] Additional minor fixes and cleanups in
>>> NetworkInterface.c
>>>
>>> As a follow up to JDK-8156521, and when comparing against the
>>> version of this file in jdk8u-dev a few minor issues were noticed.
>>>
>>> There is a free of a memory structure that was missed somehow
>>> in the 9 version of this file ( it is already in the 8 version ). The
>>> remaining few changes are just some minor cleanup.
>>>
>>> http://cr.openjdk.java.net/~chegar/8157811/
>>> https://bugs.openjdk.java.net/browse/JDK-8157811
>>>
>>> -Chris.
> 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.

Re: RFR 8157811 [9] Additional minor fixes and cleanups in Networking native code

[Chris Hegarty]

Thanks. I included it, though it may not show in the webrev ( white space 
change )

I generalise the issue to cover a few other minor issues.

Webrev updated in-place:
  http://cr.openjdk.java.net/~chegar/8157811/

-Chris.

> On 25 May 2016, at 13:59, Langer, Christoph  wrote:
> 
> Hi Chris,
> 
> looks nice, I had seen some of these places, too.
> 
> Here is another one which you could add:
> 
> --- a/src/java.base/unix/native/libnet/NetworkInterface.c   Tue May 24 
> 10:14:41 2016 -0700
> +++ b/src/java.base/unix/native/libnet/NetworkInterface.c   Wed May 25 
> 14:56:31 2016 +0200
> @@ -1829,7 +1829,7 @@
> strncpy(if2.lifr_name, ifname, sizeof(if2.lifr_name) - 1);
> 
> if (ioctl(sock, SIOCGLIFFLAGS, (char *)) < 0) {
> - return -1;
> +return -1;
> }
> 
> *flags = if2.lifr_flags;
> 
> Best regards
> Christoph
> 
>> -Original Message-
>> From: net-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of Chris
>> Hegarty
>> Sent: Mittwoch, 25. Mai 2016 11:50
>> To: OpenJDK Network Dev list 
>> Subject: RFR 8157811 [9] Additional minor fixes and cleanups in
>> NetworkInterface.c
>> 
>> As a follow up to JDK-8156521, and when comparing against the
>> version of this file in jdk8u-dev a few minor issues were noticed.
>> 
>> There is a free of a memory structure that was missed somehow
>> in the 9 version of this file ( it is already in the 8 version ). The
>> remaining few changes are just some minor cleanup.
>> 
>> http://cr.openjdk.java.net/~chegar/8157811/
>> https://bugs.openjdk.java.net/browse/JDK-8157811
>> 
>> -Chris.