Re: RFR: 8253100: Fix "no comment" warnings in java.base/java.net [v2]
On Fri, 26 Feb 2021 10:44:04 GMT, Rahul Yadav wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed comment > > LGTM! Ran the changes through `-Xdoclint:missing` and there were no warnings outputted so looks good! - PR: https://git.openjdk.java.net/jdk/pull/2715
Re: RFR: 8253100: Fix "no comment" warnings in java.base/java.net [v2]
On Thu, 25 Feb 2021 11:05:07 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a change that fixes "no comment" warnings generated by >> `javadoc -Xdoclint` for `java.base/java.net` > > Daniel Fuchs has updated the pull request incrementally with one additional > commit since the last revision: > > Fixed comment LGTM! - Marked as reviewed by ryadav (Committer). PR: https://git.openjdk.java.net/jdk/pull/2715
Re: RFR: 8253100: Fix "no comment" warnings in java.base/java.net [v2]
On Thu, 25 Feb 2021 16:59:07 GMT, Naoto Sato wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed comment
>
> src/java.base/share/classes/java/net/InetSocketAddress.java line 326:
>
>> 324: /**
>> 325: * Throws {@code InvalidObjectException}, always.
>> 326: * @throws ObjectStreamException always
>
> Is this correct? Seems to contradict each other.
`InvalidObjectException` is a subclass of `ObjectStreamException`.
-
PR: https://git.openjdk.java.net/jdk/pull/2715
Re: RFR: 8253100: Fix "no comment" warnings in java.base/java.net [v2]
On Thu, 25 Feb 2021 11:05:07 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a change that fixes "no comment" warnings generated by
>> `javadoc -Xdoclint` for `java.base/java.net`
>
> Daniel Fuchs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fixed comment
src/java.base/share/classes/java/net/InetSocketAddress.java line 326:
> 324: /**
> 325: * Throws {@code InvalidObjectException}, always.
> 326: * @throws ObjectStreamException always
Is this correct? Seems to contradict each other.
-
PR: https://git.openjdk.java.net/jdk/pull/2715
Re: RFR: 8253100: Fix "no comment" warnings in java.base/java.net [v2]
> Hi, > > Please find here a change that fixes "no comment" warnings generated by > `javadoc -Xdoclint` for `java.base/java.net` Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision: Fixed comment - Changes: - all: https://git.openjdk.java.net/jdk/pull/2715/files - new: https://git.openjdk.java.net/jdk/pull/2715/files/2f039c6e..ff11d016 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2715&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2715&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/2715.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2715/head:pull/2715 PR: https://git.openjdk.java.net/jdk/pull/2715
Re: RFR: 8253100: Fix "no comment" warnings in java.base/java.net [v2]
On Thu, 25 Feb 2021 09:24:50 GMT, Patrick Concannon wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed comment > > src/java.base/share/classes/java/net/HttpRetryException.java line 48: > >> 46: >> 47: /** >> 48: * the URL to be redirected to. > > Should this begin with a capital 't' like the previous comment above? Good catch. Fixed. - PR: https://git.openjdk.java.net/jdk/pull/2715
