Re: RFR: 8282536: java.net.InetAddress should be a sealed class [v3]
> The following fix seals the `java.net.InetAddress` class and permits only two > implementations - `java.net.Inet4Address` and `java.net.Inet6Address`. > > No issues have been detected by regression and JCK tests. > > Links: [JBS](https://bugs.openjdk.java.net/browse/JDK-8282536) > [CSR](https://bugs.openjdk.java.net/browse/JDK-8282880) Aleksei Efimov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'master' into JDK-8282536_Seal_InetAddress - Cleanup unnessecary class loader checks, remove readObjectNoData - Add qualified Serializable usage with import - 8282536: java.net.InetAddress should be a sealed class - Changes: - all: https://git.openjdk.java.net/jdk/pull/7789/files - new: https://git.openjdk.java.net/jdk/pull/7789/files/f6901f09..44e6ab12 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=7789=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk=7789=01-02 Stats: 10743 lines in 405 files changed: 6113 ins; 2397 del; 2233 mod Patch: https://git.openjdk.java.net/jdk/pull/7789.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7789/head:pull/7789 PR: https://git.openjdk.java.net/jdk/pull/7789
Re: RFR: 8282536: java.net.InetAddress should be a sealed class [v2]
On Mon, 14 Mar 2022 16:45:24 GMT, Aleksei Efimov wrote: >> The following fix seals the `java.net.InetAddress` class and permits only >> two implementations - `java.net.Inet4Address` and `java.net.Inet6Address`. >> >> No issues have been detected by regression and JCK tests. >> >> Links: [JBS](https://bugs.openjdk.java.net/browse/JDK-8282536) >> [CSR](https://bugs.openjdk.java.net/browse/JDK-8282880) > > Aleksei Efimov has updated the pull request incrementally with one additional > commit since the last revision: > > Cleanup unnessecary class loader checks, remove readObjectNoData Marked as reviewed by michaelm (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7789
Re: RFR: 8282536: java.net.InetAddress should be a sealed class
On Fri, 11 Mar 2022 16:47:46 GMT, Aleksei Efimov wrote: > The following fix seals the `java.net.InetAddress` class and permits only two > implementations - `java.net.Inet4Address` and `java.net.Inet6Address`. > > No issues have been detected by regression and JCK tests. > > Links: [JBS](https://bugs.openjdk.java.net/browse/JDK-8282536) > [CSR](https://bugs.openjdk.java.net/browse/JDK-8282880) With only two sub-classes allowed the `InetAddress` code can be further cleaned-up by removing class loader checks. Pushed as f6901f098fe. Regression/JCK tests discovered no issues related to this change. - PR: https://git.openjdk.java.net/jdk/pull/7789
Re: RFR: 8282536: java.net.InetAddress should be a sealed class [v2]
> The following fix seals the `java.net.InetAddress` class and permits only two > implementations - `java.net.Inet4Address` and `java.net.Inet6Address`. > > No issues have been detected by regression and JCK tests. > > Links: [JBS](https://bugs.openjdk.java.net/browse/JDK-8282536) > [CSR](https://bugs.openjdk.java.net/browse/JDK-8282880) Aleksei Efimov has updated the pull request incrementally with one additional commit since the last revision: Cleanup unnessecary class loader checks, remove readObjectNoData - Changes: - all: https://git.openjdk.java.net/jdk/pull/7789/files - new: https://git.openjdk.java.net/jdk/pull/7789/files/2096e6b8..f6901f09 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=7789=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=7789=00-01 Stats: 23 lines in 2 files changed: 0 ins; 21 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/7789.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7789/head:pull/7789 PR: https://git.openjdk.java.net/jdk/pull/7789
Re: RFR: 8282536: java.net.InetAddress should be a sealed class
On Fri, 11 Mar 2022 16:47:46 GMT, Aleksei Efimov wrote: > The following fix seals the `java.net.InetAddress` class and permits only two > implementations - `java.net.Inet4Address` and `java.net.Inet6Address`. > > No issues have been detected by regression and JCK tests. > > Links: [JBS](https://bugs.openjdk.java.net/browse/JDK-8282536) > [CSR](https://bugs.openjdk.java.net/browse/JDK-8282880) Marked as reviewed by rriggs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7789
Re: RFR: 8282536: java.net.InetAddress should be a sealed class
On Fri, 11 Mar 2022 16:47:46 GMT, Aleksei Efimov wrote: > The following fix seals the `java.net.InetAddress` class and permits only two > implementations - `java.net.Inet4Address` and `java.net.Inet6Address`. > > No issues have been detected by regression and JCK tests. > > Links: [JBS](https://bugs.openjdk.java.net/browse/JDK-8282536) > [CSR](https://bugs.openjdk.java.net/browse/JDK-8282880) Marked as reviewed by jpai (Committer). - PR: https://git.openjdk.java.net/jdk/pull/7789
Re: RFR: 8282536: java.net.InetAddress should be a sealed class
On Fri, 11 Mar 2022 16:47:46 GMT, Aleksei Efimov wrote: > The following fix seals the `java.net.InetAddress` class and permits only two > implementations - `java.net.Inet4Address` and `java.net.Inet6Address`. > > No issues have been detected by regression and JCK tests. > > Links: [JBS](https://bugs.openjdk.java.net/browse/JDK-8282536) > [CSR](https://bugs.openjdk.java.net/browse/JDK-8282880) LGTM - Marked as reviewed by dfuchs (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7789
