Re: RFR: 8286293: Tests ShortResponseBody and ShortResponseBodyWithRetry should use less resources [v2]
On Mon, 9 May 2022 11:57:30 GMT, Michael McMahon wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >> commits since the last revision: >> >> - Merge branch 'master' into ShortResponseBody >> - 8286293: Tests ShortResponseBody and ShortResponseBodyWithRetry should >> use less resources > > test/jdk/java/net/httpclient/ShortResponseBodyPost.java line 31: > >> 29: * @library /test/lib >> 30: * @build jdk.test.lib.net.SimpleSSLContext ShortResponseBody >> ShortResponseBodyGet >> 31: * @run testng/othervm > > Seems like the build directive should refer to ShortResponseBodyPost instead > of ShortResponseBodyGet Oh! You're right. Updated. - PR: https://git.openjdk.java.net/jdk/pull/8569
Re: RFR: 8286293: Tests ShortResponseBody and ShortResponseBodyWithRetry should use less resources [v2]
On Sat, 7 May 2022 11:46:32 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a simple test fix that re-architecture ShortResponseBody >> for better resource usage. >> The test is split to test GET and POST separately and avoids testing GET >> twice. > > Daniel Fuchs has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge branch 'master' into ShortResponseBody > - 8286293: Tests ShortResponseBody and ShortResponseBodyWithRetry should use > less resources test/jdk/java/net/httpclient/ShortResponseBodyPost.java line 31: > 29: * @library /test/lib > 30: * @build jdk.test.lib.net.SimpleSSLContext ShortResponseBody > ShortResponseBodyGet > 31: * @run testng/othervm Seems like the build directive should refer to ShortResponseBodyPost instead of ShortResponseBodyGet - PR: https://git.openjdk.java.net/jdk/pull/8569
Re: RFR: 8286293: Tests ShortResponseBody and ShortResponseBodyWithRetry should use less resources [v2]
> Hi, > > Please find here a simple test fix that re-architecture ShortResponseBody for > better resource usage. > The test is split to test GET and POST separately and avoids testing GET > twice. Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into ShortResponseBody - 8286293: Tests ShortResponseBody and ShortResponseBodyWithRetry should use less resources - Changes: - all: https://git.openjdk.java.net/jdk/pull/8569/files - new: https://git.openjdk.java.net/jdk/pull/8569/files/b212c007..11959ee8 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=8569=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=8569=00-01 Stats: 109734 lines in 1343 files changed: 97735 ins; 5210 del; 6789 mod Patch: https://git.openjdk.java.net/jdk/pull/8569.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8569/head:pull/8569 PR: https://git.openjdk.java.net/jdk/pull/8569
