Re: RFR: JDK-8175325 - NetworkInterface.getInterfaceAddresses throws NPE when no addresses
Mark, > On 6 Mar 2017, at 23:21, Mark Sheppard wrote: > > tha's true from the Java side. I didn't exhaustively check if is possible > that the bindings could > be returned uninitialized or null from native code - I don't think it is > possible, but I added the > null check, just in case. I agree with Martin’s comment. The null check should be sufficient. … >> There is a side issue here, relating to the synthesis of a NetworkInterface >> for a MulticastSocket >> bound to a wildcard address. This is somewhat dubious semantics, and would >> seem to be worthy of review >> at some stage in the future. Yes, this should be looked at in some more detail in the future. -Chris.
Re: RFR: JDK-8175325 - NetworkInterface.getInterfaceAddresses throws NPE when no addresses
Chris, Martin, thanks for the feedback I'll remove the initialization from the constructor regards Mark On 07/03/2017 15:17, Chris Hegarty wrote: Mark, On 6 Mar 2017, at 23:21, Mark Sheppard wrote: tha's true from the Java side. I didn't exhaustively check if is possible that the bindings could be returned uninitialized or null from native code - I don't think it is possible, but I added the null check, just in case. I agree with Martin’s comment. The null check should be sufficient. … There is a side issue here, relating to the synthesis of a NetworkInterface for a MulticastSocket bound to a wildcard address. This is somewhat dubious semantics, and would seem to be worthy of review at some stage in the future. Yes, this should be looked at in some more detail in the future. -Chris.