Re: [PATCH, RFC] Add Travis and Appveyor CI support
On Thu, May 17, 2018 at 10:57:08AM -0400, Bill Fenner wrote: > On Thu, May 17, 2018 at 9:56 AM, Niels Baggesen via Net-snmp-coders < > net-snmp-coders@lists.sourceforge.net> wrote: > > > Den 17-05-2018 kl. 15:54 skrev Robert Story: > > > >> On Wed, 16 May 2018 07:23:32 -0700 Bart wrote: > >> BVA> This patch makes it possible to enable Travis and Appveyor > >> BVA> continuous integration support. On Travis Net-SNMP is built > >> BVA> with all MIBs, with --disable-set-support, with > >> BVA> --enable-mini-agent, with --enable-minimalist and with > >> BVA> --enable-read-only. All these configurations are built on > >> BVA> Linux and on OS/X. On Appveyor Net-SNMP is built with MSVC and > >> BVA> dynamic libraries, with MSVC and statically linked libraryes, > >> BVA> with MinGW64, with Cygwin32 and with Cygwin64. As one can see > >> BVA> in the scripts in the "ci" directory the to-do items are as > >> BVA> follows: > >> > >> Given that this doesn't affect code and CI support is a good thing: > >> +1 > >> > > > > Another +1 > > > I'm a big fan of automated testing, and I've looked at the scripts and > output. +1 from me too! AOL +1 /MF > -- > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > ___ > Net-snmp-coders mailing list > Net-snmp-coders@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/net-snmp-coders -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: [PATCH, RFC] Add Travis and Appveyor CI support
On Thu, May 17, 2018 at 9:56 AM, Niels Baggesen via Net-snmp-coders < net-snmp-coders@lists.sourceforge.net> wrote: > Den 17-05-2018 kl. 15:54 skrev Robert Story: > >> On Wed, 16 May 2018 07:23:32 -0700 Bart wrote: >> BVA> This patch makes it possible to enable Travis and Appveyor >> BVA> continuous integration support. On Travis Net-SNMP is built >> BVA> with all MIBs, with --disable-set-support, with >> BVA> --enable-mini-agent, with --enable-minimalist and with >> BVA> --enable-read-only. All these configurations are built on >> BVA> Linux and on OS/X. On Appveyor Net-SNMP is built with MSVC and >> BVA> dynamic libraries, with MSVC and statically linked libraryes, >> BVA> with MinGW64, with Cygwin32 and with Cygwin64. As one can see >> BVA> in the scripts in the "ci" directory the to-do items are as >> BVA> follows: >> >> Given that this doesn't affect code and CI support is a good thing: >> +1 >> > > Another +1 I'm a big fan of automated testing, and I've looked at the scripts and output. +1 from me too! Bill -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: [PATCH, RFC] Add Travis and Appveyor CI support
Den 17-05-2018 kl. 15:54 skrev Robert Story: On Wed, 16 May 2018 07:23:32 -0700 Bart wrote: BVA> This patch makes it possible to enable Travis and Appveyor BVA> continuous integration support. On Travis Net-SNMP is built BVA> with all MIBs, with --disable-set-support, with BVA> --enable-mini-agent, with --enable-minimalist and with BVA> --enable-read-only. All these configurations are built on BVA> Linux and on OS/X. On Appveyor Net-SNMP is built with MSVC and BVA> dynamic libraries, with MSVC and statically linked libraryes, BVA> with MinGW64, with Cygwin32 and with Cygwin64. As one can see BVA> in the scripts in the "ci" directory the to-do items are as BVA> follows: Given that this doesn't affect code and CI support is a good thing: +1 Another +1 /Niels -- Niels Baggesen - @home - Århus - Denmark - n...@users.sourceforge.net The purpose of computing is insight, not numbers --- R W Hamming -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: [PATCH, RFC] Add Travis and Appveyor CI support
On Wed, 16 May 2018 07:23:32 -0700 Bart wrote: BVA> This patch makes it possible to enable Travis and Appveyor BVA> continuous integration support. On Travis Net-SNMP is built BVA> with all MIBs, with --disable-set-support, with BVA> --enable-mini-agent, with --enable-minimalist and with BVA> --enable-read-only. All these configurations are built on BVA> Linux and on OS/X. On Appveyor Net-SNMP is built with MSVC and BVA> dynamic libraries, with MSVC and statically linked libraryes, BVA> with MinGW64, with Cygwin32 and with Cygwin64. As one can see BVA> in the scripts in the "ci" directory the to-do items are as BVA> follows: Given that this doesn't affect code and CI support is a good thing: +1 Robert -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
Re: CFV: complete fix for setting engineBoots/Time via cli
Den 17-05-2018 kl. 13:48 skrev Robert Story: A fix in pre2 or pre3 fixed use of -Z command line argument for setting engineBoots/engineTime. The snmptrap app needs to be fixed as well. [PATCH] also fix snmptrap for setting engineBoots and engineTime (e.g. -Z cli arg) An addendum for earlier fix for agent side (commit 988562514b05a2bc01be4) +1 /Niels -- Niels Baggesen - @home - Århus - Denmark - n...@users.sourceforge.net The purpose of computing is insight, not numbers --- R W Hamming -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot ___ Net-snmp-coders mailing list Net-snmp-coders@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
CFV: complete fix for setting engineBoots/Time via cli
A fix in pre2 or pre3 fixed use of -Z command line argument for
setting engineBoots/engineTime. The snmptrap app needs to be fixed
as well.
[PATCH] also fix snmptrap for setting engineBoots and engineTime (e.g. -Z cli
arg)
An addendum for earlier fix for agent side (commit 988562514b05a2bc01be4)
---
apps/snmptrap.c | 8
1 file changed, 8 insertions(+)
diff --git a/apps/snmptrap.c b/apps/snmptrap.c
index b3c5a37a3..b495afb85 100644
--- a/apps/snmptrap.c
+++ b/apps/snmptrap.c
@@ -228,6 +228,14 @@ main(int argc, char *argv[])
goto out;
}
+if (ss->engineBoots != 0 || ss->engineTime != 0) {
+set_enginetime(ss->securityEngineID,
+ ss->securityEngineIDLen,
+ ss->engineBoots,
+ ss->engineTime,
+ TRUE);
+}
+
#ifndef NETSNMP_DISABLE_SNMPV1
if (session.version == SNMP_VERSION_1) {
if (inform) {
--
2.14.3
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
