RE: [maven] Test specs split
Hi Luca, Nice work. Maybe we can do a major update and move javaEE to a specific part of the test spec. (we can also do that for platform specific part). It may simplify the workflow during full test with a few duplication as you mention. Regards Eric -Message d'origine- De : Luca Mambretti Envoyé : dimanche 11 mars 2018 16:45 À : Eric Barboni Cc : netcat Objet : Re: [maven] Test specs split Hi, I've gone ahead and added some labels, the end result is less than optimal IMHO, since now the sanity testing label is outdated, cause it has a mix of se and ee tests, and also points 3 and 7 of the specification are now marked as javaee, since they require EE projects as a base, these should either be duplicated to use both SE and EE projects; otherwise we will lose coverage of the EE related bits, starting the EE server for debugging and checking also the web resources for refactoring, or we should keep them in the SE label and add a note for netcat 9 to use an SE project instead of the EE one and skip/ignore EE bits if necessary. Regards Luca. - Messaggio originale - Da: "Luca Mambretti" A: "Eric Barboni" Cc: "netcat" Inviato: Sabato, 10 marzo 2018 21:22:49 Oggetto: Re: [maven] Test specs split Obviously I've forgot to add that the EE label is already there so only the SE should be added assuming synergy cannot run tests with labels in exclude mode. Regards Luca - Messaggio originale - Da: "Luca Mambretti" A: "Eric Barboni" Cc: "netcat" Inviato: Sabato, 10 marzo 2018 21:20:14 Oggetto: Re: [maven] Test specs split Hi Eric, I've started quick reviewing the mentioned test cases, I also expected nothing or almost nothing would have changed, but there is one thing that bothers me, practically everything relating to java EE is out of scope for this first apache run, so some of the cases cannot be covered unless the java EE modules are pulled from the old repository. I do not think removing these tests to be wise, since they'll have to be rewritten as soon as the EE bits are pulled back in, on the other hand running a full test suite without pulling the EE bits out would involve a lot of skipping on the tester side, to avoid this maybe we could add a SE,EE label to the existing cases to drive the testing during the full run, do you think this would be enough, or it would be better to separate the maven test specification in 2 separate sections SE and EE, it would require a lot more time compared to setting only labels on the existing tests, but it would have the added benefit of splitting up this pretty large test specification in 2 potentially more manageable ones, con would be that something would most probably have to be duplicated. Unfortunately today I've had less time than what I expected so could not cover much of the specification, but I do hope to have a little more time tomorrow so I might be able to at least add labels. Let me know what you think, Regards, Luca - Messaggio originale ----- Da: "Eric Barboni" A: "netcat" Inviato: Mercoledì, 7 marzo 2018 11:18:17 Oggetto: RE: [maven] Test specs split Hi Luca, Sure you can update the wiki [1]. Put the section you do also in the wiki. As far as I know there is no major change done yet on Netbeans 9 for maven side except jdk 9 support. Regards Eric PS: sorry I reply directly an incomplete mail to Luca [1] https://cwiki.apache.org/confluence/display/NETBEANS/NetCAT+9.0+Test+Spec+Reviews -Message d'origine- De : Luca Mambretti Envoyé : mercredi 7 mars 2018 10:01 À : netcat Objet : [maven] Test specs split I can probably set aside a couple of hours to do specs review in the weekend, can I take the first 3 points ? * [ http://netbeans-vm.apache.org/synergy/client/app/#/specification/339/v/2 | Maven projects ] * [ http://netbeans-vm.apache.org/synergy/client/app/#/specification/339/v/2 | Clean, Build, Run, Debug maven project ] * [ http://netbeans-vm.apache.org/synergy/client/app/#/specification/339/v/2 | Run, Debug, Profile, Test single file ] Regards Luca. - To unsubscribe, e-mail: netcat-unsubscr...@netbeans.apache.org For additional commands, e-mail: netcat-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists - To unsubscribe, e-mail: netcat-unsubscr...@netbeans.apache.org For additional commands, e-mail: netcat-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists - To unsubscribe, e-mail: netcat-unsubs
Re: [maven] Test specs split
Hi, I've gone ahead and added some labels, the end result is less than optimal IMHO, since now the sanity testing label is outdated, cause it has a mix of se and ee tests, and also points 3 and 7 of the specification are now marked as javaee, since they require EE projects as a base, these should either be duplicated to use both SE and EE projects; otherwise we will lose coverage of the EE related bits, starting the EE server for debugging and checking also the web resources for refactoring, or we should keep them in the SE label and add a note for netcat 9 to use an SE project instead of the EE one and skip/ignore EE bits if necessary. Regards Luca. - Messaggio originale - Da: "Luca Mambretti" A: "Eric Barboni" Cc: "netcat" Inviato: Sabato, 10 marzo 2018 21:22:49 Oggetto: Re: [maven] Test specs split Obviously I've forgot to add that the EE label is already there so only the SE should be added assuming synergy cannot run tests with labels in exclude mode. Regards Luca - Messaggio originale - Da: "Luca Mambretti" A: "Eric Barboni" Cc: "netcat" Inviato: Sabato, 10 marzo 2018 21:20:14 Oggetto: Re: [maven] Test specs split Hi Eric, I've started quick reviewing the mentioned test cases, I also expected nothing or almost nothing would have changed, but there is one thing that bothers me, practically everything relating to java EE is out of scope for this first apache run, so some of the cases cannot be covered unless the java EE modules are pulled from the old repository. I do not think removing these tests to be wise, since they'll have to be rewritten as soon as the EE bits are pulled back in, on the other hand running a full test suite without pulling the EE bits out would involve a lot of skipping on the tester side, to avoid this maybe we could add a SE,EE label to the existing cases to drive the testing during the full run, do you think this would be enough, or it would be better to separate the maven test specification in 2 separate sections SE and EE, it would require a lot more time compared to setting only labels on the existing tests, but it would have the added benefit of splitting up this pretty large test specification in 2 potentially more manageable ones, con would be that something would most probably have to be duplicated. Unfortunately today I've had less time than what I expected so could not cover much of the specification, but I do hope to have a little more time tomorrow so I might be able to at least add labels. Let me know what you think, Regards, Luca - Messaggio originale - Da: "Eric Barboni" A: "netcat" Inviato: Mercoledì, 7 marzo 2018 11:18:17 Oggetto: RE: [maven] Test specs split Hi Luca, Sure you can update the wiki [1]. Put the section you do also in the wiki. As far as I know there is no major change done yet on Netbeans 9 for maven side except jdk 9 support. Regards Eric PS: sorry I reply directly an incomplete mail to Luca [1] https://cwiki.apache.org/confluence/display/NETBEANS/NetCAT+9.0+Test+Spec+Reviews -Message d'origine- De : Luca Mambretti Envoyé : mercredi 7 mars 2018 10:01 À : netcat Objet : [maven] Test specs split I can probably set aside a couple of hours to do specs review in the weekend, can I take the first 3 points ? * [ http://netbeans-vm.apache.org/synergy/client/app/#/specification/339/v/2 | Maven projects ] * [ http://netbeans-vm.apache.org/synergy/client/app/#/specification/339/v/2 | Clean, Build, Run, Debug maven project ] * [ http://netbeans-vm.apache.org/synergy/client/app/#/specification/339/v/2 | Run, Debug, Profile, Test single file ] Regards Luca. - To unsubscribe, e-mail: netcat-unsubscr...@netbeans.apache.org For additional commands, e-mail: netcat-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists - To unsubscribe, e-mail: netcat-unsubscr...@netbeans.apache.org For additional commands, e-mail: netcat-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists - To unsubscribe, e-mail: netcat-unsubscr...@netbeans.apache.org For additional commands, e-mail: netcat-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists - To unsubscribe, e-mail: netcat-unsubscr...@netbeans.apache.org For additional commands, e-mail: netcat-h...@netbeans.apache.org
Re: [maven] Test specs split
Obviously I've forgot to add that the EE label is already there so only the SE should be added assuming synergy cannot run tests with labels in exclude mode. Regards Luca - Messaggio originale - Da: "Luca Mambretti" A: "Eric Barboni" Cc: "netcat" Inviato: Sabato, 10 marzo 2018 21:20:14 Oggetto: Re: [maven] Test specs split Hi Eric, I've started quick reviewing the mentioned test cases, I also expected nothing or almost nothing would have changed, but there is one thing that bothers me, practically everything relating to java EE is out of scope for this first apache run, so some of the cases cannot be covered unless the java EE modules are pulled from the old repository. I do not think removing these tests to be wise, since they'll have to be rewritten as soon as the EE bits are pulled back in, on the other hand running a full test suite without pulling the EE bits out would involve a lot of skipping on the tester side, to avoid this maybe we could add a SE,EE label to the existing cases to drive the testing during the full run, do you think this would be enough, or it would be better to separate the maven test specification in 2 separate sections SE and EE, it would require a lot more time compared to setting only labels on the existing tests, but it would have the added benefit of splitting up this pretty large test specification in 2 potentially more manageable ones, con would be that something would most probably have to be duplicated. Unfortunately today I've had less time than what I expected so could not cover much of the specification, but I do hope to have a little more time tomorrow so I might be able to at least add labels. Let me know what you think, Regards, Luca - Messaggio originale - Da: "Eric Barboni" A: "netcat" Inviato: Mercoledì, 7 marzo 2018 11:18:17 Oggetto: RE: [maven] Test specs split Hi Luca, Sure you can update the wiki [1]. Put the section you do also in the wiki. As far as I know there is no major change done yet on Netbeans 9 for maven side except jdk 9 support. Regards Eric PS: sorry I reply directly an incomplete mail to Luca [1] https://cwiki.apache.org/confluence/display/NETBEANS/NetCAT+9.0+Test+Spec+Reviews -Message d'origine- De : Luca Mambretti Envoyé : mercredi 7 mars 2018 10:01 À : netcat Objet : [maven] Test specs split I can probably set aside a couple of hours to do specs review in the weekend, can I take the first 3 points ? * [ http://netbeans-vm.apache.org/synergy/client/app/#/specification/339/v/2 | Maven projects ] * [ http://netbeans-vm.apache.org/synergy/client/app/#/specification/339/v/2 | Clean, Build, Run, Debug maven project ] * [ http://netbeans-vm.apache.org/synergy/client/app/#/specification/339/v/2 | Run, Debug, Profile, Test single file ] Regards Luca. - To unsubscribe, e-mail: netcat-unsubscr...@netbeans.apache.org For additional commands, e-mail: netcat-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists - To unsubscribe, e-mail: netcat-unsubscr...@netbeans.apache.org For additional commands, e-mail: netcat-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists - To unsubscribe, e-mail: netcat-unsubscr...@netbeans.apache.org For additional commands, e-mail: netcat-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [maven] Test specs split
Hi Eric, I've started quick reviewing the mentioned test cases, I also expected nothing or almost nothing would have changed, but there is one thing that bothers me, practically everything relating to java EE is out of scope for this first apache run, so some of the cases cannot be covered unless the java EE modules are pulled from the old repository. I do not think removing these tests to be wise, since they'll have to be rewritten as soon as the EE bits are pulled back in, on the other hand running a full test suite without pulling the EE bits out would involve a lot of skipping on the tester side, to avoid this maybe we could add a SE,EE label to the existing cases to drive the testing during the full run, do you think this would be enough, or it would be better to separate the maven test specification in 2 separate sections SE and EE, it would require a lot more time compared to setting only labels on the existing tests, but it would have the added benefit of splitting up this pretty large test specification in 2 potentially more manageable ones, con would be that something would most probably have to be duplicated. Unfortunately today I've had less time than what I expected so could not cover much of the specification, but I do hope to have a little more time tomorrow so I might be able to at least add labels. Let me know what you think, Regards, Luca - Messaggio originale - Da: "Eric Barboni" A: "netcat" Inviato: Mercoledì, 7 marzo 2018 11:18:17 Oggetto: RE: [maven] Test specs split Hi Luca, Sure you can update the wiki [1]. Put the section you do also in the wiki. As far as I know there is no major change done yet on Netbeans 9 for maven side except jdk 9 support. Regards Eric PS: sorry I reply directly an incomplete mail to Luca [1] https://cwiki.apache.org/confluence/display/NETBEANS/NetCAT+9.0+Test+Spec+Reviews -Message d'origine- De : Luca Mambretti Envoyé : mercredi 7 mars 2018 10:01 À : netcat Objet : [maven] Test specs split I can probably set aside a couple of hours to do specs review in the weekend, can I take the first 3 points ? * [ http://netbeans-vm.apache.org/synergy/client/app/#/specification/339/v/2 | Maven projects ] * [ http://netbeans-vm.apache.org/synergy/client/app/#/specification/339/v/2 | Clean, Build, Run, Debug maven project ] * [ http://netbeans-vm.apache.org/synergy/client/app/#/specification/339/v/2 | Run, Debug, Profile, Test single file ] Regards Luca. - To unsubscribe, e-mail: netcat-unsubscr...@netbeans.apache.org For additional commands, e-mail: netcat-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists - To unsubscribe, e-mail: netcat-unsubscr...@netbeans.apache.org For additional commands, e-mail: netcat-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
RE: [maven] Test specs split
Hi Jirka, For the maven NetBeans platform part of testing we will need to get the maven artifact generated for the current version of Apache Netbeans according to git and not to the last hg.netbeans.org mercurial repository. We have the previous artefact in this http://bits.netbeans.org/nexus/ for version 8.2 and previous. Regards Eric -Message d'origine- De : Jiří Kovalský Envoyé : mercredi 7 mars 2018 11:06 À : netcat@netbeans.apache.org; Eric Barboni Objet : Re: [maven] Test specs split Eric, what do you think? -Jirka Dne 7.3.2018 v 10:00 Luca Mambretti napsal(a): > I can probably set aside a couple of hours to do specs review in the weekend, > can I take the first 3 points ? > > > > * [ > https://urldefense.proofpoint.com/v2/url?u=http-3A__netbeans-2Dvm.apache.org_synergy_client_app_-23_specification_339_v_2&d=DwICaQ&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=8_Pz0x0SKeT5e3IehhQKCbQ2xl3tz40jnCU133NrdP4&m=7LxGLriQQwP-EBbkzXGFQEGBjGkwsvbKeuA0RMGXjWY&s=lvgwezaVBsJxNnag6Yx__ws4O2cuIjXpJFilcfNVhXo&e= > | Maven projects ] > * [ > https://urldefense.proofpoint.com/v2/url?u=http-3A__netbeans-2Dvm.apache.org_synergy_client_app_-23_specification_339_v_2&d=DwICaQ&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=8_Pz0x0SKeT5e3IehhQKCbQ2xl3tz40jnCU133NrdP4&m=7LxGLriQQwP-EBbkzXGFQEGBjGkwsvbKeuA0RMGXjWY&s=lvgwezaVBsJxNnag6Yx__ws4O2cuIjXpJFilcfNVhXo&e= > | Clean, Build, Run, Debug maven project ] > * [ > https://urldefense.proofpoint.com/v2/url?u=http-3A__netbeans-2Dvm.apache.org_synergy_client_app_-23_specification_339_v_2&d=DwICaQ&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=8_Pz0x0SKeT5e3IehhQKCbQ2xl3tz40jnCU133NrdP4&m=7LxGLriQQwP-EBbkzXGFQEGBjGkwsvbKeuA0RMGXjWY&s=lvgwezaVBsJxNnag6Yx__ws4O2cuIjXpJFilcfNVhXo&e= > | Run, Debug, Profile, Test single file ] > > Regards > Luca. > - To unsubscribe, e-mail: netcat-unsubscr...@netbeans.apache.org For additional commands, e-mail: netcat-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
RE: [maven] Test specs split
Hi Luca, Sure you can update the wiki [1]. Put the section you do also in the wiki. As far as I know there is no major change done yet on Netbeans 9 for maven side except jdk 9 support. Regards Eric PS: sorry I reply directly an incomplete mail to Luca [1] https://cwiki.apache.org/confluence/display/NETBEANS/NetCAT+9.0+Test+Spec+Reviews -Message d'origine- De : Luca Mambretti Envoyé : mercredi 7 mars 2018 10:01 À : netcat Objet : [maven] Test specs split I can probably set aside a couple of hours to do specs review in the weekend, can I take the first 3 points ? * [ http://netbeans-vm.apache.org/synergy/client/app/#/specification/339/v/2 | Maven projects ] * [ http://netbeans-vm.apache.org/synergy/client/app/#/specification/339/v/2 | Clean, Build, Run, Debug maven project ] * [ http://netbeans-vm.apache.org/synergy/client/app/#/specification/339/v/2 | Run, Debug, Profile, Test single file ] Regards Luca. - To unsubscribe, e-mail: netcat-unsubscr...@netbeans.apache.org For additional commands, e-mail: netcat-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [maven] Test specs split
Eric, what do you think? -Jirka Dne 7.3.2018 v 10:00 Luca Mambretti napsal(a): I can probably set aside a couple of hours to do specs review in the weekend, can I take the first 3 points ? * [ https://urldefense.proofpoint.com/v2/url?u=http-3A__netbeans-2Dvm.apache.org_synergy_client_app_-23_specification_339_v_2&d=DwICaQ&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=8_Pz0x0SKeT5e3IehhQKCbQ2xl3tz40jnCU133NrdP4&m=7LxGLriQQwP-EBbkzXGFQEGBjGkwsvbKeuA0RMGXjWY&s=lvgwezaVBsJxNnag6Yx__ws4O2cuIjXpJFilcfNVhXo&e= | Maven projects ] * [ https://urldefense.proofpoint.com/v2/url?u=http-3A__netbeans-2Dvm.apache.org_synergy_client_app_-23_specification_339_v_2&d=DwICaQ&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=8_Pz0x0SKeT5e3IehhQKCbQ2xl3tz40jnCU133NrdP4&m=7LxGLriQQwP-EBbkzXGFQEGBjGkwsvbKeuA0RMGXjWY&s=lvgwezaVBsJxNnag6Yx__ws4O2cuIjXpJFilcfNVhXo&e= | Clean, Build, Run, Debug maven project ] * [ https://urldefense.proofpoint.com/v2/url?u=http-3A__netbeans-2Dvm.apache.org_synergy_client_app_-23_specification_339_v_2&d=DwICaQ&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=8_Pz0x0SKeT5e3IehhQKCbQ2xl3tz40jnCU133NrdP4&m=7LxGLriQQwP-EBbkzXGFQEGBjGkwsvbKeuA0RMGXjWY&s=lvgwezaVBsJxNnag6Yx__ws4O2cuIjXpJFilcfNVhXo&e= | Run, Debug, Profile, Test single file ] Regards Luca. - To unsubscribe, e-mail: netcat-unsubscr...@netbeans.apache.org For additional commands, e-mail: netcat-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists