Re: [LLC]: Fix TX window scaling
On Tue, Nov 15, Linux Kernel Mailing List wrote: tree 574e979829d3363c16c8c6d1fe624b206d8ce4f9 parent cb422c464bdaeeb3b9ad4539010e357bf1bd1745 author Jochen Friedrich [EMAIL PROTECTED] Tue, 15 Nov 2005 13:57:15 -0800 committer David S. Miller [EMAIL PROTECTED] Tue, 15 Nov 2005 13:57:15 -0800 [LLC]: Fix TX window scaling - if (llc-npta 127) - llc-npta = 127 ; + if (llc-npta ~LLC_2_SEQ_NBR_MODULO) + llc-npta = ~LLC_2_SEQ_NBR_MODULO ; This change causes this: net/llc/llc_c_ac.c: In function `llc_conn_ac_inc_npta_value': net/llc/llc_c_ac.c:998: warning: comparison is always true due to limited range of data type net/llc/llc_c_ac.c:999: warning: large integer implicitly truncated to unsigned type net/llc/llc_c_ac.c: In function `llc_conn_ac_inc_tx_win_size': net/llc/llc_c_ac.c:1089: warning: comparison is always true due to limited range of data type net/llc/llc_c_ac.c:1090: warning: large integer implicitly truncated to unsigned type -- short story of a lazy sysadmin: alias appserv=wotan - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
sky2 prints many hw tcp v4 csum failed
I'm using sky2 driver on 2.6.14-mm2. It works fine, but I got this message repeatedly. hw tcp v4 csum failed I can suppress these messages by # ethtool -K eth0 tx off rx off And, These messages cannot be seen with sk98lin v8.16.2.3 (on 2.6.14-mm2 with a little changes to build it) Motherboard: ASUS Socket 775 P5GDC-V DELUXE Marvell 88E8053 Gigabit Ethernet Controller (Asus) - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [RFT] ip_tables NUMA optimization
Harald Welte a écrit :
I've hand-merged Eric Dumazet's original ip_tables numa optimization
patch to current git head. Also, I've ported it to ip6_tables and
arp_tables.
Since this is 2.6.16 stuff, I don't want to have it applied at this
time, but merely request testers (esp. for the non-ipv4 part).
Thanks,
Hi Harald
Thank you for doing this, since I'm currently too busy with my day job to
update the patch myself.
However I did read your patch and caught one vfree() call wrongly replaced by
a kfree() call in arp_tables.c
@@ -911,6 +930,47 @@ static int get_entries(const struct arpt
return ret;
}
+static void free_table_info(struct arpt_table_info *info)
+{
+ int cpu;
+ for_each_cpu(cpu) {
+ if (info-size = PAGE_SIZE)
+ kfree(info-entries[cpu]);
+ else
+ kfree(info-entries[cpu]);
+ }
+ kfree(info);
It should probably use vfree() like :
+ for_each_cpu(cpu) {
+ if (info-size = PAGE_SIZE)
+ kfree(info-entries[cpu]);
+ else
+ vfree(info-entries[cpu]);
+ }
See you
Eric Dumazet
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: sky2 prints many hw tcp v4 csum failed
On Thu, 17 Nov 2005 20:14:48 +0900 Akinobu Mita [EMAIL PROTECTED] wrote: I'm using sky2 driver on 2.6.14-mm2. It works fine, but I got this message repeatedly. hw tcp v4 csum failed I can suppress these messages by # ethtool -K eth0 tx off rx off And, These messages cannot be seen with sk98lin v8.16.2.3 (on 2.6.14-mm2 with a little changes to build it) Motherboard: ASUS Socket 775 P5GDC-V DELUXE Marvell 88E8053 Gigabit Ethernet Controller (Asus) Most likely, you are actually getting packets with a bad checksum. The kernel complains too much about it, this has been fixed in 2.6.15-rc1 (see Herbert Xu's patch in the netdev mailing list archive). - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: 2.6.15-rc1: NET_CLS_U32 not working?
Christian schrieb: Adrian Bunk schrieb: I'm assuming you are trying to insert the new module in your old kernel? yes, rebuilding the whole kernel (after just enabling NET_CLS_U32 as a module) makes the warnings go away. This is one of the unfortunate but hardly avoidable cases where adding a module requires installing a new kernel. i wonder why/if this is really needed. although not critical, this behaviour is pretty annoying thanks, Christian. -- BOFH excuse #24: network packets travelling uphill (use a carrier pigeon) - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] fix spelling errors in netdev Kconfigs
I ran aspell on the Kconfigs in drivers/net/ and found the following
spelling errors.
Signed-off-by: Jon Mason [EMAIL PROTECTED]
diff -r 971dbac4c501 drivers/net/Kconfig
--- a/drivers/net/Kconfig Wed Nov 16 16:25:28 2005
+++ b/drivers/net/Kconfig Thu Nov 17 08:24:31 2005
@@ -55,7 +55,7 @@
'Trunking' by Sun, 802.3ad by the IEEE, and 'Bonding' in Linux.
The driver supports multiple bonding modes to allow for both high
- perfomance and high availability operation.
+ performance and high availability operation.
Refer to file:Documentation/networking/bonding.txt for more
information.
@@ -687,8 +687,8 @@
depends on NET_VENDOR_3COM (PCI || EISA)
select MII
---help---
- This option enables driver support for a large number of 10mbps and
- 10/100mbps EISA, PCI and PCMCIA 3Com network cards:
+ This option enables driver support for a large number of 10Mbps and
+ 10/100Mbps EISA, PCI and PCMCIA 3Com network cards:
Vortex(Fast EtherLink 3c590/3c592/3c595/3c597) EISA and PCI
Boomerang (EtherLink XL 3c900 or 3c905)PCI
@@ -1010,7 +1010,7 @@
depends on NET_ISA
---help---
If you have a network (Ethernet) card of this type, say Y. This
- driver supports intel i82595{FX,TX} based boards. Note however
+ driver supports Intel i82595{FX,TX} based boards. Note however
that the EtherExpress PRO/100 Ethernet card has its own separate
driver. Please read the Ethernet-HOWTO, available from
http://www.tldp.org/docs.html#howto.
@@ -1196,7 +1196,7 @@
help
Additional receive skb headroom. Note, that driver
will always reserve at least 2 bytes to make IP header
- aligned, so usualy there is no need to add any additional
+ aligned, so usually there is no need to add any additional
headroom.
If unsure, set to 0.
@@ -1911,7 +1911,7 @@
will be called myri_sbus. This is recommended.
config NS83820
- tristate National Semiconduct DP83820 support
+ tristate National Semiconductor DP83820 support
depends on PCI
help
This is a driver for the National Semiconductor DP83820 series
@@ -2459,7 +2459,7 @@
Say Y here if you want to be able to filter the packets passing over
PPP interfaces. This allows you to control which packets count as
activity (i.e. which packets will reset the idle timer or bring up
- a demand-dialled link) and which packets are to be dropped entirely.
+ a demand-dialed link) and which packets are to be dropped entirely.
You need to say Y here if you wish to use the pass-filter and
active-filter options to pppd.
@@ -2647,8 +2647,8 @@
file:Documentation/networking/shaper.txt for more information.
An alternative to this traffic shaper is the experimental
- Class-Based Queueing (CBQ) scheduling support which you get if you
- say Y to QoS and/or fair queueing above.
+ Class-Based Queuing (CBQ) scheduling support which you get if you
+ say Y to QoS and/or fair queuing above.
To set up and configure shaper devices, you need the shapecfg
program, available from ftp://shadow.cabi.net/pub/Linux/ in the
diff -r 971dbac4c501 drivers/net/arcnet/Kconfig
--- a/drivers/net/arcnet/KconfigWed Nov 16 16:25:28 2005
+++ b/drivers/net/arcnet/KconfigThu Nov 17 08:24:31 2005
@@ -68,10 +68,10 @@
packet is stuffed with an extra 4 byte cookie which doesn't
actually appear on the network. After transmit the driver will send
back a packet with protocol byte 0 containing the status of the
- transmition:
+ transmission:
0=no hardware acknowledge
1=excessive nak
- 2=transmition accepted by the reciever hardware
+ 2=transmission accepted by the receiver hardware
Received packets are also stuffed with the extra 4 bytes but it will
be random data.
diff -r 971dbac4c501 drivers/net/irda/Kconfig
--- a/drivers/net/irda/Kconfig Wed Nov 16 16:25:28 2005
+++ b/drivers/net/irda/Kconfig Thu Nov 17 08:24:31 2005
@@ -284,7 +284,7 @@
Say Y here if you want to build support for the USB IrDA FIR Dongle
device driver. To compile it as a module, choose M here: the module
will be called irda-usb. IrDA-USB support the various IrDA USB
- dongles available and most of their pecularities. Those dongles
+ dongles available and most of their peculiarities. Those dongles
plug in the USB port of your computer, are plug and play, and
support SIR and FIR (4Mbps) speeds. On the other hand, those
dongles tend to be less efficient than a FIR chipset.
@@ -361,7 +361,7
Re: TCP burst mitigation in Linux
On Thu, 17 Nov 2005 11:41:55 -0500 (EST) Janardhan Iyengar [EMAIL PROTECTED] wrote: [I am not subscribed to this list, so please Cc me on all responses.] Hello all, I have a few questions I'd like answers to: * Is burst mitigation for TCP is implemented in Linux? By burst mitigation, I mean a mechanism to avoid sudden bursts of packets that may (under several plausible circumstances) be released by a single ack. No, but there have been patches to do it. I can send if interested. Turns out that the rate-halving and congestion window validation that is implemented takes care of this in the normal case. * If so, is it an option? * Is it turned ON by default? thanks in advance, jana --- Janardhan R. Iyengar http://www.cis.udel.edu/~iyengar Protocol Engineering Lab -- CIS -- University Of Delaware --- - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html -- Stephen Hemminger [EMAIL PROTECTED] OSDL http://developer.osdl.org/~shemminger - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: sky2 prints many hw tcp v4 csum failed
On Thu, 17 Nov 2005 18:30:07 +0100 Karsten Keil [EMAIL PROTECTED] wrote: On Thu, Nov 17, 2005 at 07:26:22AM -0800, Stephen Hemminger wrote: On Thu, 17 Nov 2005 20:14:48 +0900 Akinobu Mita [EMAIL PROTECTED] wrote: I'm using sky2 driver on 2.6.14-mm2. It works fine, but I got this message repeatedly. hw tcp v4 csum failed I can suppress these messages by # ethtool -K eth0 tx off rx off And, These messages cannot be seen with sk98lin v8.16.2.3 (on 2.6.14-mm2 with a little changes to build it) Motherboard: ASUS Socket 775 P5GDC-V DELUXE Marvell 88E8053 Gigabit Ethernet Controller (Asus) Most likely, you are actually getting packets with a bad checksum. The kernel complains too much about it, this has been fixed in 2.6.15-rc1 (see Herbert Xu's patch in the netdev mailing list archive). I see the same problem here (I did report it some weeks ago). And no here are no bad checksum packets, since sk98lin do not show this in the same (isolated) enviroment. And if I change the network card to one which is supported by the skge driver (same enviroment), I don't get a single hw tcp v4 csum failed warning. Read the patch, the problem was in the UDP/TCP code, it would print the message on packets with a bad checksum if the device was using the CHECKSUM_HW option. Sk98lin silently drops packets with bad checksum, this is wrong. -- Stephen Hemminger [EMAIL PROTECTED] OSDL http://developer.osdl.org/~shemminger - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] smc91x: fix one source of spurious interrupts
Not only SMC_ACK_INT(IM_TX_EMPTY_INT) in in smc_hardware_send_pkt)
appears to be unnecessary (tested with an SMC91C94 and SMC91C111), but
it seems to trigger spurious interrupts on some machines as well.
Removed.
While at it, let's log any remaining spurious interrupts if any (and
clean usage of the max IRQ loop count value).
Signed-off-by: Nicolas Pitre [EMAIL PROTECTED]
diff --git a/drivers/net/smc91x.c b/drivers/net/smc91x.c
index c91e2e8..1021108 100644
--- a/drivers/net/smc91x.c
+++ b/drivers/net/smc91x.c
@@ -155,6 +155,12 @@ MODULE_LICENSE(GPL);
#define MEMORY_WAIT_TIME 16
/*
+ * The maximum number of processing loops allowed for each call to the
+ * IRQ handler.
+ */
+#define MAX_IRQ_LOOPS 8
+
+/*
* This selects whether TX packets are sent one by one to the SMC91x internal
* memory and throttled until transmission completes. This may prevent
* RX overruns a litle by keeping much of the memory free for RX packets
@@ -684,7 +690,6 @@ static void smc_hardware_send_pkt(unsign
/* queue the packet for TX */
SMC_SET_MMU_CMD(MC_ENQUEUE);
- SMC_ACK_INT(IM_TX_EMPTY_INT);
smc_special_unlock(lp-lock);
dev-trans_start = jiffies;
@@ -1305,7 +1310,7 @@ static irqreturn_t smc_interrupt(int irq
SMC_SET_INT_MASK(0);
/* set a timeout value, so I don't stay here forever */
- timeout = 8;
+ timeout = MAX_IRQ_LOOPS;
do {
status = SMC_GET_INT();
@@ -1372,10 +1377,13 @@ static irqreturn_t smc_interrupt(int irq
/* restore register states */
SMC_SET_PTR(saved_pointer);
SMC_SET_INT_MASK(mask);
-
spin_unlock(lp-lock);
- DBG(3, %s: Interrupt done (%d loops)\n, dev-name, 8-timeout);
+ if (timeout == MAX_IRQ_LOOPS)
+ PRINTK(%s: spurious interrupt (mask = 0x%02x)\n,
+ dev-name, mask);
+ DBG(3, %s: Interrupt done (%d loops)\n,
+ dev-name, MAX_IRQ_LOOPS - timeout);
/*
* We return IRQ_HANDLED unconditionally here even if there was
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Fix oops in r8169 driver
Olaf Kirch [EMAIL PROTECTED] : [...] When rtl8169_init_board didn't find the PCI power state capability, it would bail out but return 0 (success). rtl8169_init_one would then oops trying to dereference the dev pointer which is NULL. And the device is still unusable because rtl8169_init_board failed. Is there any issue with the patch that I posted yesterday ? -- Ueimor - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)
Am Donnerstag 17 November 2005 04:29 schrieb jamal:
1) There are read_only oper state IFF_XXX flags which are sent via
netlink to user space. These are set by the kernel (and not by user
space); they reflect the state of link.
We can avoid a myriad of new IFF_*-flags if we allow a device driver to
specify a function for mapping its internal state to RFC2863, like Thomas
did. The result of that function will then be used as input for the link-oper
mode policy.
I think IFF_RUNNING hasnt changed meaning in that it reflects the
operational DOWN/UP state. We may have to export two new IFF_XXX
operational flags to user space {IFF_DORMANT and IFF_LLD} like i was
suggesting earlier; i cant see any other way to escape exporting those
two if we are to maintain backward compat for IFF_RUNNING.
It's debatable what backward compatibily for IFF_RUNNING means. From the view
of a userspace application like zebra or dhcpcd, IFF_RUNNING should be set
when the interface is actually usable - and that is after the 802.1X
supplicant f.e. has finished and has raised operstate to OPER_UP.
I hope the above is clear - any patch will have to be a mix of the ones
posted so far.
ok, I'll produce a patch then - first version will be available tomorrow
evening.
If we are in agreement, i can post what i think the states are; although
if we are in agreement above i dont see the need to.
I think I have a quite clear idea, but I don't want to keep you from
posting ;-)
Stefan
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Fw: [BUG] kernel 2.6.14.2 breaks IPSEC
Herbert Xu wrote: Andrew Morton [EMAIL PROTECTED] wrote: So far, i've looked into net/ipv4/esp4.c and i can confirm that the correct spi has been selected and inserted into the packet in function esp_output esph-spi = x-id.spi; ( line 97 ). It looks as if the corruption happens later down the stack . Could you test it without netfilter (just flush all your iptables rules)? Thanks, Hello Herbert, i just realized i had forgotten to flush my nat tables :( when i reported it did not change. I just tried again and i was able to pinpoint that nat is indeed the problem. I can have all my other netfilter rules and IPSEC works. When i set the nat rule ( a simple iptables -A POSTROUTING -o eth1 -j MASQUERADE) , then the packets are corrupted . So we now where to look ... I'll try to have a look at the changes between 2.6.13.4 and 2.6.14.2 but since i'm far from an expert, i don't expect much from my search Hope this helps. -- Charles-Edouard Ruault PGP Key ID E4D2B80C - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] TCP highspeed build error
There is a compile error that crept in with the last patch of
TCP patches.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
--- tcp-2.6.orig/net/ipv4/tcp_highspeed.c
+++ tcp-2.6/net/ipv4/tcp_highspeed.c
@@ -111,7 +111,7 @@ static void hstcp_init(struct sock *sk)
}
static void hstcp_cong_avoid(struct sock *sk, u32 adk, u32 rtt,
-u32 in_flight, u32 pkts_acked)
+u32 in_flight, int data_acked)
{
struct tcp_sock *tp = tcp_sk(sk);
struct hstcp *ca = inet_csk_ca(sk);
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Fw: [BUG] kernel 2.6.14.2 breaks IPSEC
On Thu, Nov 17, 2005 at 09:39:58PM +0100, Charles-Edouard Ruault wrote:
i just realized i had forgotten to flush my nat tables :( when i
reported it did not change.
I just tried again and i was able to pinpoint that nat is indeed the
problem.
I can have all my other netfilter rules and IPSEC works. When i set the
nat rule ( a simple iptables -A POSTROUTING -o eth1 -j MASQUERADE) ,
Aha, this is actually expected. Applying SNAT to IPsec at the moment
produces undefined results.
If you really need it, you should apply Patrick McHardy's netfilter
IPsec patches which can be found on patch-o-matic.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
[RFC] TCP CUBIC
I took your CUBIC patches from your BIC web page and ported them from 2.6.13 to the new stuff in 2.6.15. If anyone wants to look or test see: http://developer.osdl.org/shemminger/patches/2.6.15-cubic/ This adds yet another congestion variant, my graphs will run out of colors soon. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] TCP highspeed build error
From: Stephen Hemminger [EMAIL PROTECTED] Date: Thu, 17 Nov 2005 13:01:01 -0800 There is a compile error that crept in with the last patch of TCP patches. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] There is no use of pkts_acked nor data_acked in that hstcp_cong_avoid() function, so how can this mis-named variable result in a build error? :-) - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/1] [NETFILTER] ip_conntrack: fix ftp/irc/tftp helpers on ports = 32768
From: Harald Welte [EMAIL PROTECTED] Date: Tue, 15 Nov 2005 11:03:51 +0100 [NETFILTER] ip_conntrack: fix ftp/irc/tftp helpers on ports = 32768 Since we've converted the ftp/irc/tftp helpers to use the new module_parm_array() some time ago, we ware accidentially using signed data types - thus preventing those modules from being used on ports = 32768. This patch fixes it by using 'ushort' module parameters. Thanks to Jan Nijs for reporting this bug. Signed-off-by: Harald Welte [EMAIL PROTECTED] Applied, thanks. I think this is definitely a 2.6.14-stable candidate? - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [BRIDGE]: recompute features after adding new device
From: Olaf Rempel [EMAIL PROTECTED] Date: Tue, 15 Nov 2005 23:15:31 +0100 On Tue, 15 Nov 2005 22:53:19 +0100 Olaf Rempel [EMAIL PROTECTED] wrote: gnaa, typo. should be br not br0 Your patch won't apply anyways because your email client changes tab characters into spaces. Please fix up the typo, _test_ the patch, and resubmit without mangling the patch whitespace so it can apply properly. Thanks. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [LLC]: Fix TX window scaling
From: Olaf Hering [EMAIL PROTECTED] Date: Thu, 17 Nov 2005 10:06:36 +0100 This change causes this: net/llc/llc_c_ac.c: In function `llc_conn_ac_inc_npta_value': net/llc/llc_c_ac.c:998: warning: comparison is always true due to limited range of data type net/llc/llc_c_ac.c:999: warning: large integer implicitly truncated to unsigned type Thanks for the report, I've fixed it like so: diff-tree 381998241fd1fc635596f4e8ae835f0d64ca1ba2 (from 2fce76afdb067fa3e7f8ee33c9fe366bd65887ea) Author: David S. Miller [EMAIL PROTECTED] Date: Thu Nov 17 15:17:42 2005 -0800 [LLC]: Fix compiler warnings introduced by TX window scaling changes. Noticed by Olaf Hering. The comparisons want a u8 here (the data type on the left-hand branch is a u8 structure member, and the constant on the right-hand branch is ~((u8) 128)), but C turns it into an integer so we get: net/llc/llc_c_ac.c: In function `llc_conn_ac_inc_npta_value': net/llc/llc_c_ac.c:998: warning: comparison is always true due to limited range of data type net/llc/llc_c_ac.c:999: warning: large integer implicitly truncated to unsigned type Fix this up by explicitly recasting the right-hand branch constant into a u8 once more. Signed-off-by: David S. Miller [EMAIL PROTECTED] diff --git a/net/llc/llc_c_ac.c b/net/llc/llc_c_ac.c index 91fb6bc..8169f24 100644 --- a/net/llc/llc_c_ac.c +++ b/net/llc/llc_c_ac.c @@ -995,8 +995,8 @@ static int llc_conn_ac_inc_npta_value(st llc-dec_step = 0; llc-dec_cntr = llc-inc_cntr = 2; ++llc-npta; - if (llc-npta ~LLC_2_SEQ_NBR_MODULO) - llc-npta = ~LLC_2_SEQ_NBR_MODULO ; + if (llc-npta (u8) ~LLC_2_SEQ_NBR_MODULO) + llc-npta = (u8) ~LLC_2_SEQ_NBR_MODULO; } else --llc-inc_cntr; return 0; @@ -1086,8 +1086,8 @@ int llc_conn_ac_inc_tx_win_size(struct s struct llc_sock *llc = llc_sk(sk); llc-k += 1; - if (llc-k ~LLC_2_SEQ_NBR_MODULO) - llc-k = ~LLC_2_SEQ_NBR_MODULO ; + if (llc-k (u8) ~LLC_2_SEQ_NBR_MODULO) + llc-k = (u8) ~LLC_2_SEQ_NBR_MODULO; return 0; } - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[DEBUG INFO]IPv6: sleeping function called from invalid context.
I get follow message when switch to single user mode and the kernel version is 2.6.15-rc1-git5. Regards Nov 18 08:26:23 localhost kernel: Debug: sleeping function called from invalid context at mm/slab.c:2472 Nov 18 08:26:23 localhost kernel: in_atomic():1, irqs_disabled():0 Nov 18 08:26:23 localhost kernel: [c0149d5a] kmem_cache_alloc+0x5a/0x70 Nov 18 08:26:23 localhost kernel: [e0f47336] inet6_dump_fib+0xb6/0x110 [ipv6] Nov 18 08:26:23 localhost kernel: [c02e129c] netlink_dump+0x4c/0x1e0 Nov 18 08:26:23 localhost kernel: [c02e150a] netlink_dump_start+0xda/0x170 Nov 18 08:26:23 localhost kernel: [c02d2d05] rtnetlink_rcv_msg+0x1d5/0x250 Nov 18 08:26:23 localhost kernel: [e0f47280] inet6_dump_fib+0x0/0x110 [ipv6] Nov 18 08:26:23 localhost kernel: [c02d2b30] rtnetlink_rcv_msg+0x0/0x250 Nov 18 08:26:23 localhost kernel: [c02e17ed] netlink_rcv_skb+0x4d/0x90 Nov 18 08:26:23 localhost kernel: [c02d2b30] rtnetlink_rcv_msg+0x0/0x250 Nov 18 08:26:23 localhost kernel: [c02e1860] netlink_run_queue+0x30/0xc0 Nov 18 08:26:23 localhost kernel: [c02d2b03] rtnetlink_rcv+0x23/0x50 Nov 18 08:26:23 localhost kernel: [c02e1092] netlink_data_ready+0x12/0x60 Nov 18 08:26:23 localhost kernel: [c0335414] _spin_unlock_irqrestore+0x14/0x30 Nov 18 08:26:23 localhost kernel: [c02e0284] netlink_sendskb+0x24/0x50 Nov 18 08:26:23 localhost kernel: [c02e0d3c] netlink_sendmsg+0x29c/0x350 Nov 18 08:26:23 localhost kernel: [c02be551] sock_sendmsg+0x111/0x150 Nov 18 08:26:23 localhost kernel: [c01c56f0] avc_lookup+0xc0/0x120 Nov 18 08:26:23 localhost kernel: [c0131f10] autoremove_wake_function+0x0/0x50 Nov 18 08:26:23 localhost kernel: [c02bdfff] move_addr_to_user+0x5f/0x70 Nov 18 08:26:23 localhost kernel: [c02c0628] sys_recvmsg+0x1b8/0x230 Nov 18 08:26:23 localhost kernel: [c013ef94] audit_sockaddr+0x54/0xc0 Nov 18 08:26:23 localhost kernel: [c02bfded] sys_sendto+0x10d/0x150 Nov 18 08:26:23 localhost kernel: [c0141b6d] filemap_nopage+0x30d/0x3e0 Nov 18 08:26:23 localhost kernel: [c0145424] __alloc_pages+0x64/0x310 Nov 18 08:26:23 localhost kernel: [c013db8e] audit_filter_syscall+0x4e/0x130 Nov 18 08:26:23 localhost kernel: [c013db8e] audit_filter_syscall+0x4e/0x130 Nov 18 08:26:23 localhost kernel: [c02c0865] sys_socketcall+0x1c5/0x2a0 Nov 18 08:26:23 localhost kernel: [c0103261] syscall_call+0x7/0xb Nov 18 08:26:23 localhost kernel: Removing netfilter NETLINK layer. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [DEBUG INFO]IPv6: sleeping function called from invalid context.
In article [EMAIL PROTECTED] (at Fri, 18 Nov 2005 08:44:27 +0800), Yan Zheng [EMAIL PROTECTED] says: I get follow message when switch to single user mode and the kernel version is 2.6.15-rc1-git5. : Nov 18 08:26:23 localhost kernel: Debug: sleeping function called from invalid context at mm/slab.c:2472 Nov 18 08:26:23 localhost kernel: in_atomic():1, irqs_disabled():0 Nov 18 08:26:23 localhost kernel: [c0149d5a] kmem_cache_alloc+0x5a/0x70 Nov 18 08:26:23 localhost kernel: [e0f47336] inet6_dump_fib+0xb6/0x110 [ipv6] I remember someone replaced GFP_ATOMIC with GFP_KERNEL... --yoshfuji - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] LSM-IPSec Network Hooks
* Trent Jaeger ([EMAIL PROTECTED]) wrote: Patch with sock callback lock made unconditional. Previous send (earlier today, 11/17) was not the latest patch -- please disregard that patch. Little heavy on KERN_DEBUG printk's. Could you drop them (or perhaps use pr_debug instead)? thanks, -chris - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[2.6 patch] drivers/net/wireless/orinoco.h: extern inline - static inline
extern inline doesn't make much sense.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
drivers/net/wireless/orinoco.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.15-rc1-mm1-full/drivers/net/wireless/orinoco.h.old
2005-11-18 02:38:43.0 +0100
+++ linux-2.6.15-rc1-mm1-full/drivers/net/wireless/orinoco.h2005-11-18
02:38:47.0 +0100
@@ -155,7 +155,7 @@
* SPARC, due to its weird semantics for save/restore flags. extern
* inline should prevent the kernel from linking or module from
* loading if they are not inlined. */
-extern inline int orinoco_lock(struct orinoco_private *priv,
+static inline int orinoco_lock(struct orinoco_private *priv,
unsigned long *flags)
{
spin_lock_irqsave(priv-lock, *flags);
@@ -168,7 +168,7 @@
return 0;
}
-extern inline void orinoco_unlock(struct orinoco_private *priv,
+static inline void orinoco_unlock(struct orinoco_private *priv,
unsigned long *flags)
{
spin_unlock_irqrestore(priv-lock, *flags);
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Issue 0 WAS (Re: Oustanding issues WAS(IRe: Consensus? WAS(RFC 2863)
On Thu, 2005-17-11 at 22:03 -0500, jamal wrote: I will attempt some ascii art shortly. Actually if you agree with it please include it in your patch so it is easier for people to make changes in the future. ok, ascii art is hard - instead in pseudo code (please double check with the RFC); i am sure the states can be optimized, but here goes: switch oper state case NP: - If !stacked goto DOWN else goto LLD case LLD: - If told to go to up goto UP if at least one child is up and mode=default generate netlink event - If told to go to dormant and mode=dormant goto dormant if at least one child is dormant case DOWN: // netlink event when transitioning to UP - if told to transition to UP and mode default, goto UP - if told to transition to UP and mode to dormant, goto to DORMANT case DORMANT - if told to transition to up if stacked goto UP if at least one child is up if !stacked goto UP generate netlink event on transition to UP?? - if told to transition to DOWN if !stacked goto LLD if no children are up or dormant else goto DOWN generate netlink event either going to LLD or DOWN case UP - if told to goto DOWN go there if !stacked else goto LLD if all children are oper down emit netlink event for above transitions - if told to goto to DORMANT goto DORMANT told to is something along the lines of netif_carrier_down/up etc comments: - I think NP state is useless mostly - thats why i left it as immediately transitioning without having to be told to do so. Perhaps some USB netdevices may find use for it; in typical big chasis routers it is used to indicate presence of a network device but absence of hardware. - UP-DORMANT; i am not sure if that transition is needed. - I didnt show UNKNOWN state; it's the default bizare state - And the other important piece is stacking as well defined in section 3.1.14. A stacked interface can never just be down; it can only be LLD instead (because it depends on oper states of its children). Suggestion: we may need a IFF_flag for indicating something is stacked. When this flag is set together with IFF_RUNNING it implies UP; else if IFF_RUNNING is not set it implies it is LLD. cheers, jamal - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[2.6 patch] move some code to net/ipx/af_ipx.c
On Mon, Nov 14, 2005 at 02:57:07AM +0100, Adrian Bunk wrote:
On Fri, Nov 11, 2005 at 02:35:51AM -0600, Matt Mackall wrote:
trivial: drop unused 802.3 code if we compile without IPX
(originally from http://wohnheim.fh-wedel.de/~joern/software/kernel/je/25/)
Signed-off-by: Matt Mackall [EMAIL PROTECTED]
Index: tiny/net/802/Makefile
===
--- tiny.orig/net/802/Makefile 2005-03-15 00:24:59.0 -0600
+++ tiny/net/802/Makefile 2005-03-15 00:25:48.0 -0600
@@ -2,8 +2,6 @@
# Makefile for the Linux 802.x protocol layers.
#
-obj-y := p8023.o
-
# Check the p8022 selections against net/core/Makefile.
obj-$(CONFIG_SYSCTL) += sysctl_net_802.o
obj-$(CONFIG_LLC) += p8022.o psnap.o
@@ -11,5 +9,5 @@ obj-$(CONFIG_TR) += p8022.o psnap.o tr.o
obj-$(CONFIG_NET_FC) += fc.o
obj-$(CONFIG_FDDI) += fddi.o
obj-$(CONFIG_HIPPI)+= hippi.o
-obj-$(CONFIG_IPX) += p8022.o psnap.o
+obj-$(CONFIG_IPX) += p8022.o psnap.o p8023.o
obj-$(CONFIG_ATALK)+= p8022.o psnap.o
This patch isn't bad, but looking closer we could move the contents of
p8023.c as well as the contents of at least p8022.c and pe2.c into
af_ipx.c.
Is the contents of any of these three files expected to be used
outside IPX (closest candidate would be appletalk)?
Below is a patch implementing what I was thinking of.
cu
Adrian
-- snip --
This patch moves some code only used in this file to net/ipx/af_ipx.c .
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
include/net/p8022.h | 13 -
net/802/Makefile | 17 ++-
net/802/p8022.c | 66 ---
net/802/p8023.c | 61 -
net/8021q/vlan.c |1
net/8021q/vlan_dev.c |1
net/ethernet/Makefile |2
net/ethernet/pe2.c| 39
net/ipx/af_ipx.c | 102 --
9 files changed, 106 insertions(+), 196 deletions(-)
--- linux-2.6.15-rc1-mm1-full/net/802/Makefile.old 2005-11-18
02:14:35.0 +0100
+++ linux-2.6.15-rc1-mm1-full/net/802/Makefile 2005-11-18 02:15:06.0
+0100
@@ -2,14 +2,11 @@
# Makefile for the Linux 802.x protocol layers.
#
-obj-y := p8023.o
-
-# Check the p8022 selections against net/core/Makefile.
obj-$(CONFIG_SYSCTL) += sysctl_net_802.o
-obj-$(CONFIG_LLC) += p8022.o psnap.o
-obj-$(CONFIG_TR) += p8022.o psnap.o tr.o sysctl_net_802.o
-obj-$(CONFIG_NET_FC) += fc.o
-obj-$(CONFIG_FDDI) += fddi.o
-obj-$(CONFIG_HIPPI)+= hippi.o
-obj-$(CONFIG_IPX) += p8022.o psnap.o
-obj-$(CONFIG_ATALK)+= p8022.o psnap.o
+obj-$(CONFIG_LLC) += psnap.o
+obj-$(CONFIG_TR) += psnap.o tr.o sysctl_net_802.o
+obj-$(CONFIG_NET_FC) += fc.o
+obj-$(CONFIG_FDDI) += fddi.o
+obj-$(CONFIG_HIPPI)+= hippi.o
+obj-$(CONFIG_IPX) += psnap.o
+obj-$(CONFIG_ATALK)+= psnap.o
--- linux-2.6.15-rc1-mm1-full/net/ethernet/Makefile.old 2005-11-18
02:15:17.0 +0100
+++ linux-2.6.15-rc1-mm1-full/net/ethernet/Makefile 2005-11-18
02:15:22.0 +0100
@@ -4,5 +4,3 @@
obj-y += eth.o
obj-$(CONFIG_SYSCTL) += sysctl_net_ether.o
-obj-$(subst m,y,$(CONFIG_IPX)) += pe2.o
-obj-$(subst m,y,$(CONFIG_ATALK)) += pe2.o
--- linux-2.6.15-rc1-mm1-full/net/8021q/vlan.c.old 2005-11-18
02:19:40.0 +0100
+++ linux-2.6.15-rc1-mm1-full/net/8021q/vlan.c 2005-11-18 02:19:46.0
+0100
@@ -26,7 +26,6 @@
#include linux/mm.h
#include linux/in.h
#include linux/init.h
-#include net/p8022.h
#include net/arp.h
#include linux/rtnetlink.h
#include linux/notifier.h
--- linux-2.6.15-rc1-mm1-full/net/8021q/vlan_dev.c.old 2005-11-18
02:19:55.0 +0100
+++ linux-2.6.15-rc1-mm1-full/net/8021q/vlan_dev.c 2005-11-18
02:19:58.0 +0100
@@ -29,7 +29,6 @@
#include linux/netdevice.h
#include linux/etherdevice.h
#include net/datalink.h
-#include net/p8022.h
#include net/arp.h
#include vlan.h
--- linux-2.6.15-rc1-mm1-full/net/ipx/af_ipx.c.old 2005-11-18
02:17:00.0 +0100
+++ linux-2.6.15-rc1-mm1-full/net/ipx/af_ipx.c 2005-11-18 02:26:01.0
+0100
@@ -48,10 +48,10 @@
#include linux/termios.h
#include net/ipx.h
-#include net/p8022.h
#include net/psnap.h
#include net/sock.h
#include net/tcp_states.h
+#include net/llc.h
#include asm/uaccess.h
@@ -1939,8 +1939,104 @@
.notifier_call = ipxitf_device_event,
};
-extern struct datalink_proto *make_EII_client(void);
-extern void destroy_EII_client(struct datalink_proto *);
+static int p8022_request(struct datalink_proto *dl, struct sk_buff *skb,
+unsigned char *dest)
+{
+
Re: sky2 prints many hw tcp v4 csum failed
On Thu, Nov 17, 2005 at 07:26:22AM -0800, Stephen Hemminger wrote: On Thu, 17 Nov 2005 20:14:48 +0900 Akinobu Mita [EMAIL PROTECTED] wrote: I'm using sky2 driver on 2.6.14-mm2. It works fine, but I got this message repeatedly. hw tcp v4 csum failed I can suppress these messages by # ethtool -K eth0 tx off rx off And, These messages cannot be seen with sk98lin v8.16.2.3 (on 2.6.14-mm2 with a little changes to build it) Motherboard: ASUS Socket 775 P5GDC-V DELUXE Marvell 88E8053 Gigabit Ethernet Controller (Asus) Most likely, you are actually getting packets with a bad checksum. The kernel complains too much about it, this has been fixed in 2.6.15-rc1 (see Herbert Xu's patch in the netdev mailing list archive). Right, the messages disappeared. Thanks - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
