Re: [PATCH net-next v3 1/6] net: phy: mscc: migrate to phy_select/restore_page functions
On Nov 19 2018, Andrew Lunn wrote: > I still don't see why that would cause a hang. [ 996.37] [] mutex_lock+0x22/0x2a [ 996.38] [] mdiobus_read+0x36/0x60 [ 996.38] [] vsc85xx_config_init+0x4c/0x1e2 vsc85xx_config_init is calling mdiobus_read while holding the mdio_lock. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."
Re: [PATCH net-next v3 1/6] net: phy: mscc: migrate to phy_select/restore_page functions
On Nov 19 2018, Andrew Lunn wrote: > Could you turn on lockdep and see if it reports a deadlock. How do I "turn on lockdep"? Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."
Re: [PATCH net-next v3 1/6] net: phy: mscc: migrate to phy_select/restore_page functions
On Nov 19 2018, Alexandre Belloni wrote: > My first intuition is that he mac driver quentin is using does > phy_connect when the interface is opened while macb is doing it at probe > time. I didn't investigate but maybe this can help :) The phy probing of macb is very unreliable, perhaps it needs to be rewritten. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."
Re: [PATCH net-next v3 1/6] net: phy: mscc: migrate to phy_select/restore_page functions
On Nov 19 2018, Andrew Lunn wrote: > On Mon, Nov 19, 2018 at 03:57:17PM +0100, Andreas Schwab wrote: >> On Okt 08 2018, Quentin Schulz wrote: >> >> > The Microsemi PHYs have multiple banks of registers (called pages). >> > Registers can only be accessed from one page, if we need a register from >> > another page, we need to switch the page and the registers of all other >> > pages are not accessible anymore. >> > >> > Basically, to read register 5 from page 0, 1, 2, etc., you do the same >> > phy_read(phydev, 5); but you need to set the desired page beforehand. >> > >> > In order to guarantee that two concurrent functions do not change the >> > page, we need to do some locking per page. This can be achieved with the >> > use of phy_select_page and phy_restore_page functions but phy_write/read >> > calls in-between those two functions shall be replaced by their >> > lock-free alternative __phy_write/read. >> > >> > Let's migrate this driver to those functions. >> >> This has some serious locking problem. > > Hi Andreas > > Could you be more specific. Are you getting a deadlock? A WARN_ON? See the stack trace. That's where it hangs. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."
Re: [PATCH net-next v3 1/6] net: phy: mscc: migrate to phy_select/restore_page functions
On Okt 08 2018, Quentin Schulz wrote: > The Microsemi PHYs have multiple banks of registers (called pages). > Registers can only be accessed from one page, if we need a register from > another page, we need to switch the page and the registers of all other > pages are not accessible anymore. > > Basically, to read register 5 from page 0, 1, 2, etc., you do the same > phy_read(phydev, 5); but you need to set the desired page beforehand. > > In order to guarantee that two concurrent functions do not change the > page, we need to do some locking per page. This can be achieved with the > use of phy_select_page and phy_restore_page functions but phy_write/read > calls in-between those two functions shall be replaced by their > lock-free alternative __phy_write/read. > > Let's migrate this driver to those functions. This has some serious locking problem. [<0>] __schedule+0x25e/0x74c [<0>] schedule+0x1a/0x58 [<0>] schedule_preempt_disabled+0xc/0x14 [<0>] __mutex_lock.isra.0+0x10e/0x22e [<0>] __mutex_lock_slowpath+0xe/0x16 [<0>] mutex_lock+0x22/0x2a [<0>] mdiobus_read+0x36/0x60 [<0>] vsc85xx_config_init+0x4c/0x1e2 [<0>] phy_init_hw+0x3c/0x52 [<0>] phy_attach_direct+0xec/0x1dc [<0>] phy_connect_direct+0x1a/0x56 [<0>] macb_probe+0x800/0xb5e [macb] [<0>] platform_drv_probe+0x3e/0x7e [<0>] really_probe+0xba/0x310 [<0>] driver_probe_device+0x54/0xf2 [<0>] __driver_attach+0xde/0x106 [<0>] bus_for_each_dev+0x4a/0x72 [<0>] driver_attach+0x1a/0x22 [<0>] bus_add_driver+0x1ce/0x212 [<0>] driver_register+0x3a/0xd0 [<0>] __platform_driver_register+0x3a/0x42 [<0>] macb_driver_init+0x20/0x28 [macb] [<0>] do_one_initcall+0x48/0x128 [<0>] do_init_module+0x4a/0x186 [<0>] load_module+0xd6a/0xe6a [<0>] sys_finit_module+0xc6/0xfc [<0>] check_syscall_nr+0x22/0x22 Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."
Re: Oops running iptables -F OUTPUT
On Aug 28 2018, Ard Biesheuvel wrote:
> diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c
> index 6a501b25dd85..57d09d5ceb1a 100644
> --- a/arch/powerpc/kernel/setup_64.c
> +++ b/arch/powerpc/kernel/setup_64.c
> @@ -779,7 +779,6 @@ EXPORT_SYMBOL(__per_cpu_offset);
>
> void __init setup_per_cpu_areas(void)
> {
> - const size_t dyn_size = PERCPU_MODULE_RESERVE +
> PERCPU_DYNAMIC_RESERVE;
> size_t atom_size;
> unsigned long delta;
> unsigned int cpu;
> @@ -795,7 +794,9 @@ void __init setup_per_cpu_areas(void)
> else
> atom_size = 1 << 20;
>
> - rc = pcpu_embed_first_chunk(0, dyn_size, atom_size, pcpu_cpu_distance,
> + rc = pcpu_embed_first_chunk(PERCPU_MODULE_RESERVE,
> + PERCPU_DYNAMIC_RESERVE,
> + atom_size, pcpu_cpu_distance,
> pcpu_fc_alloc, pcpu_fc_free);
> if (rc < 0)
> panic("cannot initialize percpu area (err=%d)", rc);
That didn't help.
Andreas.
--
Andreas Schwab, sch...@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
Oops running iptables -F OUTPUT
I'm getting this Oops when running iptables -F OUTPUT: [ 91.139409] Unable to handle kernel paging request for data at address 0xd001fff12f34 [ 91.139414] Faulting instruction address: 0xd16a5718 [ 91.139419] Oops: Kernel access of bad area, sig: 11 [#1] [ 91.139426] BE SMP NR_CPUS=2 PowerMac [ 91.139434] Modules linked in: iptable_filter ip_tables x_tables bpfilter nfsd auth_rpcgss lockd grace nfs_acl sunrpc tun af_packet snd_aoa_codec_tas snd_aoa_fabric_layout snd_aoa snd_aoa_i2sbus snd_aoa_soundbus snd_pcm_oss snd_pcm snd_seq snd_timer snd_seq_device snd_mixer_oss snd sungem sr_mod firewire_ohci cdrom sungem_phy soundcore firewire_core pata_macio crc_itu_t sg hid_generic usbhid linear md_mod ohci_pci ohci_hcd ehci_pci ehci_hcd usbcore usb_common dm_snapshot dm_bufio dm_mirror dm_region_hash dm_log dm_mod sata_svw [ 91.139522] CPU: 1 PID: 3620 Comm: iptables Not tainted 4.19.0-rc1 #1 [ 91.139526] NIP: d16a5718 LR: d16a569c CTR: c06f560c [ 91.139531] REGS: c001fa577670 TRAP: 0300 Not tainted (4.19.0-rc1) [ 91.139534] MSR: 9200b032 CR: 84002484 XER: 2000 [ 91.139553] DAR: d001fff12f34 DSISR: 4000 IRQMASK: 0 GPR00: d16a569c c001fa5778f0 d16b0400 GPR04: 0002 8001fa46418e c001fa0d05c8 GPR08: d16b0400 d00037f13000 0001ff3e7000 d16a6fb8 GPR12: c06f560c c780 GPR16: 11635010 3fffa1b7aa68 GPR20: 0003 10013918 116350c0 c0b88990 GPR24: c0b88ba4 d001fff12f34 GPR28: d16b8000 c001fa20f400 c001fa20f440 [ 91.139627] NIP [d16a5718] .alloc_counters.isra.10+0xbc/0x140 [ip_tables] [ 91.139634] LR [d16a569c] .alloc_counters.isra.10+0x40/0x140 [ip_tables] [ 91.139638] Call Trace: [ 91.139645] [c001fa5778f0] [d16a569c] .alloc_counters.isra.10+0x40/0x140 [ip_tables] (unreliable) [ 91.139655] [c001fa5779b0] [d16a5b54] .do_ipt_get_ctl+0x110/0x2ec [ip_tables] [ 91.139666] [c001fa577aa0] [c06233e0] .nf_getsockopt+0x68/0x88 [ 91.139674] [c001fa577b40] [c0631608] .ip_getsockopt+0xbc/0x128 [ 91.139682] [c001fa577bf0] [c065adf4] .raw_getsockopt+0x18/0x5c [ 91.139690] [c001fa577c60] [c05b5f60] .sock_common_getsockopt+0x2c/0x40 [ 91.139697] [c001fa577cd0] [c05b3394] .__sys_getsockopt+0xa4/0xd0 [ 91.139704] [c001fa577d80] [c05b5ab0] .__se_sys_socketcall+0x238/0x2b4 [ 91.139712] [c001fa577e30] [c000a31c] system_call+0x5c/0x70 [ 91.139716] Instruction dump: [ 91.139721] 39290040 7d3d4a14 7fbe4840 409cff98 8138 2b890001 419d000c 393e0060 [ 91.139736] 4810 7d57c82a e93e0060 7d295214 <815a> 794807e1 41e20010 7c210b78 [ 91.139752] ---[ end trace f5d1d5431651845d ]--- Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."
Re: [PATCH v2 net-next 03/13] net: Allow MSG_EOR in each msghdr of sendmmsg
On Mär 07 2016, Tom Herbert <t...@herbertland.com> wrote: > This patch allows setting MSG_EOR in each individual msghdr passed > in sendmmsg. This allows a sendmmsg to send multiple messages when > using SOCK_SEQPACKET. This adds a new requirement to the interface of sendmmsg, namely that the msg_flags field must now be initialized, where previously it was ignored as documented in sendmsg(2). See also <https://sourceware.org/bugzilla/show_bug.cgi?id=23037>. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."
Re: [PATCH] Documentation: fix ascii art in networking docs
On Sep 16 2017, Pavel Machek <pa...@ucw.cz> wrote: > diff --git a/Documentation/networking/switchdev.txt > b/Documentation/networking/switchdev.txt > index 5e40e1f..6309e90 100644 > --- a/Documentation/networking/switchdev.txt > +++ b/Documentation/networking/switchdev.txt > @@ -29,7 +29,7 @@ with SR-IOV or soft switches, such as OVS, are possible. > sw1p1 + sw1p3 + sw1p5 + eth1 > +|+|+|+ > ||||||| > - +--++++-+--++---+ +-+-+ > + +--++++++---+ +-+-+ > | Switch driver | |mgmt | > |(this document)| | driver | > | | | | > This is all mis-aligned. How about replacing all the thin space characters by normal spaces? Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."
Re: [PATCH 07/23] netfilter: x_tables: check standard target size too
Pablo Neira Ayuso <pa...@netfilter.org> writes: > From: Florian Westphal <f...@strlen.de> > > We have targets and standard targets -- the latter carries a verdict. > > The ip/ip6tables validation functions will access t->verdict for the > standard targets to fetch the jump offset or verdict for chainloop > detection, but this happens before the targets get checked/validated. > > Thus we also need to check for verdict presence here, else t->verdict > can point right after a blob. > > Spotted with UBSAN while testing malformed blobs. This breaks iptables on PPC32. # iptables -nL iptables v1.4.21: can't initialize iptables table `filter': Table does not exist (do you need to insmod?) Perhaps iptables or your kernel needs to be upgraded. # modprobe iptable-filter FATAL: Error inserting iptable_filter (/lib/modules/4.7.0-rc1/kernel/net/ipv4/netfilter/iptable_filter.ko): Invalid argument Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."
Re: [PATCH iproute2] Make builds default to quiet mode
David Ahern <d...@cumulusnetworks.com> writes: > @@ -50,7 +54,7 @@ LDLIBS += $(LIBNETLINK) > all: Config > @set -e; \ > for i in $(SUBDIRS); \ > - do $(MAKE) $(MFLAGS) -C $$i; done > + do echo "\n$$i"; $(MAKE) $(MFLAGS) -C $$i; done echo "\n" is not portable. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."
[PATCH] net: cavium: change NET_VENDOR_CAVIUM to bool
CONFIG_NET_VENDOR_CAVIUM is only used to hide/show config options and to include subdirectories in the build, so it doesn't make sense to make it tristate. Signed-off-by: Andreas Schwab <sch...@suse.de> --- drivers/net/ethernet/cavium/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/Kconfig b/drivers/net/ethernet/cavium/Kconfig index 9b35d14..8fb84e6 100644 --- a/drivers/net/ethernet/cavium/Kconfig +++ b/drivers/net/ethernet/cavium/Kconfig @@ -3,7 +3,7 @@ # config NET_VENDOR_CAVIUM - tristate "Cavium ethernet drivers" + bool "Cavium ethernet drivers" depends on PCI default y ---help--- -- 2.6.2 -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: 4.3-rc3: `telnet ::1 ' hangs in SYN-SENT
Ok, that is already fixed by 31b33df. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
4.3-rc3: `telnet ::1 ' hangs in SYN-SENT
Trying to connect to ::1 on any port (whether or not anything listens) causes the connection to hang in SYN-SENT state. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: ss -p segfaults
j...@openmailbox.org j...@openmailbox.org writes: - free(p-process); - free(p-process_ctx); - free(p-socket_ctx); + if (p-process) + free(p-process); + if (p-process_ctx) + free(p-process_ctx); + if (p-socket_ctx) + free(p-socket_ctx); free(NULL) is a no-op. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now for something completely different. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Wiring up direct socket calls on x86_32 Linux?
Andy Lutomirski l...@amacapital.net writes: Glibc people: If Linux wired up the syscalls, would glibc use them? Not automatically. It needs to be compatible with the configured minimum kernel version, so runtime probing would needed to be implemented. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now for something completely different. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Bugme-new] [Bug 9816] New: cannot replace route
Jarek Poplawski [EMAIL PROTECTED] writes: And, after re-reading this bugzilla report, I'm pretty sure the thing should be done with 'ip route change' (but I didn't check if 2.6.24 knows about this...). $ man ip [...] ip route add - add new route ip route change - change route ip route replace - change or add new one [...] According to this replace should be a superset of change. Also, please check out comment#3, it also fails for replacing a route with something different (it's a route to an ipsec tunnel). Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now for something completely different. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 9/24] make atomic_read() behave consistently on ia64
Luck, Tony [EMAIL PROTECTED] writes:
That's distressing. I'm about to resubmit with a volatile cast in
atomic_set as well, since people expect that behavior and I've been
shown a legitimate case where it could matter. Does the assembly look
right with that cast in atomic_set() as well?
No. With the casts to volatile in atomic_set and atomic64_set I
still see places where ld8 is changed to ld4 + sign-extend.
Use atomic64_read to read an atomic64_t.
Signed-off-by: Andreas Schwab [EMAIL PROTECTED]
diff --git a/include/asm-ia64/atomic.h b/include/asm-ia64/atomic.h
index 1fc3b83..50c2b83 100644
--- a/include/asm-ia64/atomic.h
+++ b/include/asm-ia64/atomic.h
@@ -55,7 +55,7 @@ ia64_atomic64_add (__s64 i, atomic64_t *v)
do {
CMPXCHG_BUGCHECK(v);
- old = atomic_read(v);
+ old = atomic64_read(v);
new = old + i;
} while (ia64_cmpxchg(acq, v, old, new, sizeof(atomic64_t)) != old);
return new;
@@ -83,7 +83,7 @@ ia64_atomic64_sub (__s64 i, atomic64_t *v)
do {
CMPXCHG_BUGCHECK(v);
- old = atomic_read(v);
+ old = atomic64_read(v);
new = old - i;
} while (ia64_cmpxchg(acq, v, old, new, sizeof(atomic64_t)) != old);
return new;
Andreas.
--
Andreas Schwab, SuSE Labs, [EMAIL PROTECTED]
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
And now for something completely different.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] Avoid switch on long long in s2io driver
A switch on long long causes gcc to generate a reference to __ucmpdi2 on
ppc32. Avoid that by casting to int, since the value is only a small
integer anyway.
Signed-off-by: Andreas Schwab [EMAIL PROTECTED]
---
drivers/net/s2io.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux-2.6.22-rc1/drivers/net/s2io.c
===
--- linux-2.6.22-rc1.orig/drivers/net/s2io.c2007-05-13 11:03:28.0
+0200
+++ linux-2.6.22-rc1/drivers/net/s2io.c 2007-05-13 12:52:49.0 +0200
@@ -2898,7 +2898,7 @@ static void tx_intr_handler(struct fifo_
/* update t_code statistics */
err = 48;
- switch(err) {
+ switch((int)err) {
case 2:
nic-mac_control.stats_info-sw_stat.
tx_buf_abort_cnt++;
@@ -6825,7 +6825,7 @@ static int rx_osm_handler(struct ring_in
sp-mac_control.stats_info-sw_stat.parity_err_cnt++;
}
err = 48;
- switch(err) {
+ switch((int)err) {
case 1:
sp-mac_control.stats_info-sw_stat.
rx_parity_err_cnt++;
Andreas.
--
Andreas Schwab, SuSE Labs, [EMAIL PROTECTED]
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
And now for something completely different.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [patch 4/5] s2io driver updates
Ananda Raju [EMAIL PROTECTED] writes:
@@ -2704,6 +2792,10 @@ static void tx_intr_handler(fifo_info_t
if (txdlp-Control_1 TXD_T_CODE) {
unsigned long long err;
err = txdlp-Control_1 TXD_T_CODE;
+ if (err 0x1) {
This is never true.
@@ -5743,6 +6246,11 @@ static int rx_osm_handler(ring_info_t *r
skb-dev = dev;
if (err) {
+ /* Check for parity error */
+ if (err 0x1) {
Likewise.
(This is a very old patch, but the issue is still present.)
Andreas.
--
Andreas Schwab, SuSE Labs, [EMAIL PROTECTED]
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
And now for something completely different.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Can someone please try...
Michael Buesch [EMAIL PROTECTED] writes: ...the bcm43xx driver in my tree with a 4318 chip? The code there works excellent with my 4306 now, but I can't get it to work with my 4318. Doesn't work for me either. I cannot get it to associate to the AP. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now for something completely different. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: bcm43xx-softmac broken on 2.6.20-rc2
Larry Finger [EMAIL PROTECTED] writes: The patch does not apply because your mailer is breaking the white space and substituting spaces for tabs. No, it does not apply because it was space-stuffed. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now for something completely different. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH]: bcm43xx-d80211: fix hwcrypto issues (mcast)
Benjamin Herrenschmidt [EMAIL PROTECTED] writes: Well, the latest released version (fwcutter-005) contains a huge list of ... v3 URLs :-) Only 2 v4 in there. I'll check SVN. Still the same. One of them does not exist, the other one requires Javascript! Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now for something completely different. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH]: bcm43xx-d80211: fix hwcrypto issues (mcast)
Johannes Berg [EMAIL PROTECTED] writes: Try these: Support for bcmwl5.sys v4.80.53.0 added. ftp://downloads.netgear.com/files/wn511b_sw_3_28_3_8_setup.zip (bcmwl5.sys is renamed to wn511b.sys) No supported files in there. Support for bcmwl5(64).sys v4.100.15.5 added. from the latest Linksys WPC300N driver at http://www.linksys.com/download/ It's ucode revision 0x0173, patchlevel 0x0425, 2006-10-04. Requires Javascript. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now for something completely different. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
drivers/connector/cn_queue.c:130: warning: value computed is not used
There is no point in testing the atomic value if the result is thrown
away.
Signed-off-by: Andreas Schwab [EMAIL PROTECTED]
diff --git a/drivers/connector/cn_queue.c b/drivers/connector/cn_queue.c
index 9f2f00d..05f8ce2 100644
--- a/drivers/connector/cn_queue.c
+++ b/drivers/connector/cn_queue.c
@@ -127,7 +127,7 @@ void cn_queue_del_callback(struct cn_que
if (found) {
cn_queue_free_callback(cbq);
- atomic_dec_and_test(dev-refcnt);
+ atomic_dec(dev-refcnt);
}
}
Andreas.
--
Andreas Schwab, SuSE Labs, [EMAIL PROTECTED]
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
And now for something completely different.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Use pci_set_consistent_dma_mask in ixgb driver
The ixgb driver is using pci_alloc_consistent, thus is should also use
pci_set_consistent_dma_mask. This allows the driver to work on SGI
systems.
In case of an error during probing it should also disable the device again.
Signed-off-by: Andreas Schwab [EMAIL PROTECTED]
--- linux-2.6.16/drivers/net/ixgb/ixgb_main.c.~1~ 2006-03-20
06:53:29.0 +0100
+++ linux-2.6.16/drivers/net/ixgb/ixgb_main.c 2006-03-28 18:05:40.0
+0200
@@ -357,18 +357,20 @@ ixgb_probe(struct pci_dev *pdev,
if((err = pci_enable_device(pdev)))
return err;
- if(!(err = pci_set_dma_mask(pdev, DMA_64BIT_MASK))) {
+ if(!(err = pci_set_dma_mask(pdev, DMA_64BIT_MASK))
+ !(err = pci_set_consistent_dma_mask(pdev, DMA_64BIT_MASK))) {
pci_using_dac = 1;
} else {
- if((err = pci_set_dma_mask(pdev, DMA_32BIT_MASK))) {
+ if((err = pci_set_dma_mask(pdev, DMA_32BIT_MASK)) ||
+ (err = pci_set_consistent_dma_mask(pdev, DMA_32BIT_MASK))) {
IXGB_ERR(No usable DMA configuration, aborting\n);
- return err;
+ goto err_dma_mask;
}
pci_using_dac = 0;
}
if((err = pci_request_regions(pdev, ixgb_driver_name)))
- return err;
+ goto err_request_regions;
pci_set_master(pdev);
@@ -502,6 +504,9 @@ err_ioremap:
free_netdev(netdev);
err_alloc_etherdev:
pci_release_regions(pdev);
+err_request_regions:
+err_dma_mask:
+ pci_disable_device(pdev);
return err;
}
Andreas.
--
Andreas Schwab, SuSE Labs, [EMAIL PROTECTED]
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
And now for something completely different.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: GigE on PowerMac G5
Andreas Schwab [EMAIL PROTECTED] writes: Benjamin Herrenschmidt [EMAIL PROTECTED] writes: At this point, all I can say is... does it work in OS X ? Strange, OS X can't do it either. Looks like I have a hardware problem. It turned out that one of the contacts in the RJ-45 jack was twisted. After straightening it the Gb connection is working now. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now for something completely different. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: GigE on PowerMac G5
Benjamin Herrenschmidt [EMAIL PROTECTED] writes: At this point, all I can say is... does it work in OS X ? Strange, OS X can't do it either. Looks like I have a hardware problem. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now for something completely different. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
GigE on PowerMac G5
[Sorry for duplicate posting, I've used the wrong list address.] I suppose the NIC in the PowerMac G5 can do GigE, yet when plugged into a GB switch it is only willing to talk 100MB with it. Any idea why? Kernel is 2.6.16-rc5-git2. # lsprop /proc/device-tree/[EMAIL PROTECTED],f200/[EMAIL PROTECTED]/[EMAIL PROTECTED] name ethernet linux,phandleff9c53d8 interrupt-parent ff9779b0 gbit-phy assigned-addresses 82047810 8040 0020 82047830 8030 0010 local-mac-address 00 0a 95 ba b8 70 .p stats reg 00047800 02047810 0002 02047830 0001 max-frame-size 05ee (1518) address-bits 0030 (48) built-in compatible K2-GMAC category net removablenetwork network-type ethernet device_type network fast-back-to-back devsel-speed 0002 max-latency 0040 (64) min-grant0040 (64) interrupts 0029 0001 class-code 0002 (131072) revision-id device-id004c (76) vendor-id106b (4203) # ethtool eth0 Settings for eth0: Supported ports: [ TP MII ] Supported link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Half 1000baseT/Full Supports auto-negotiation: Yes Advertised link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Half 1000baseT/Full Advertised auto-negotiation: No Speed: 100Mb/s Duplex: Full Port: MII PHYAD: 0 Transceiver: external Auto-negotiation: on Supports Wake-on: g Wake-on: d Current message level: 0x0007 (7) Link detected: yes Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now for something completely different. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
