Re: [PATCH] rtlwifi: fix gigantic memleak in rtl_usb

[Bruno Randolf]

On 12/06/2015 09:39 PM, Peter Wu wrote:
>>> While using the rtl8192cu driver in monitor mode, somehow 5G of memory
>>> was permanently lost (observable via the Available column in `free -m`).
>>>
>>> This issue has existed since the introduction of this driver in v2.6.x,

One more reason to switch to rtl8xxxu as soon as possible...

bruno

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] add macro for printing mac addresses

[Bruno Randolf]

is there any chance to include a macro like this for printing mac addresses?

its advantage is that it can be used without the need to declare buffers for
print_mac(), for example:

printk(mac address:  MAC_FMT, MAC_ADDR(addr));

Signed-off-by: Bruno Randolf [EMAIL PROTECTED]
---

 include/linux/if_ether.h |9 +
 1 files changed, 9 insertions(+), 0 deletions(-)


diff --git a/include/linux/if_ether.h b/include/linux/if_ether.h
index 5f92977..b9a6fb2 100644
--- a/include/linux/if_ether.h
+++ b/include/linux/if_ether.h
@@ -127,6 +127,15 @@ extern struct ctl_table ether_table[];
  * Display a 6 byte device address (MAC) in a readable format.
  */
 #define MAC_FMT %02x:%02x:%02x:%02x:%02x:%02x
+
+#define MAC_ADDR(addr) \
+((unsigned char *)(addr))[0], \
+((unsigned char *)(addr))[1], \
+((unsigned char *)(addr))[2], \
+((unsigned char *)(addr))[3], \
+((unsigned char *)(addr))[4], \
+((unsigned char *)(addr))[5]
+
 extern char *print_mac(char *buf, const u8 *addr);
 #define DECLARE_MAC_BUF(var) char var[18] __maybe_unused
 

--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html