RE: [PATCH net-drivers-2.6 5/6] e100: CPU cycle saver microcode

2005-08-25 Thread Chilakala, Mallikarjuna 
Problem was reported on ICH devices & we modified code in
e100_load_ucode so that it will never be loaded on ICH devices.

static void e100_load_ucode(str
+   /* do not load u-code for ICH devices */
+   if (nic->flags & ich)
+   return;
+

-Malli

-Original Message-
From: Jeff Garzik [mailto:[EMAIL PROTECTED] 
Sent: Thursday, August 25, 2005 1:20 PM
To: Chilakala, Mallikarjuna
Cc: netdev; Venkatesan, Ganesh; Ronciak, John
Subject: Re: [PATCH net-drivers-2.6 5/6] e100: CPU cycle saver microcode

Malli Chilakala wrote:
> Add cpu cycle saver microcode to 8086:{1209/1229} other than ICH
devices.
> 
> Signed-off-by: Mallikarjuna R Chilakala
<[EMAIL PROTECTED]>
> Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]>
> Signed-off-by: John Ronciak <[EMAIL PROTECTED]>

Can you please review for me the reported problems in the CPU cycle 
saver code, and how this patch fixes those problems?

Jeff



-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [RESEND][PATCH net-drivers-2.6 5/9] ixgb: Fix data output by ethtool -d

2005-08-09 Thread Chilakala, Mallikarjuna 
Agreed, we will roll in this in our next build
-Malli

-Original Message-
From: Ingo Oeser [mailto:[EMAIL PROTECTED] 
Sent: Tuesday, August 09, 2005 3:27 AM
To: Chilakala, Mallikarjuna
Cc: [EMAIL PROTECTED]; netdev
Subject: Re: [RESEND][PATCH net-drivers-2.6 5/9] ixgb: Fix data output
by ethtool -d

Hi Malli,

Malli Chilakala wrote:
> Fix data output by ethtool -d
>
> Signed-off-by: Mallikarjuna R Chilakala
<[EMAIL PROTECTED]>
> Signed-off-by: Ganesh Venkatesan <[EMAIL PROTECTED]>
> Signed-off-by: John Ronciak <[EMAIL PROTECTED]>
>
> diff -up netdev-2.6/drivers/net/ixgb/ixgb_ethtool.c
> netdev-2.6/drivers/net/ixgb.new/ixgb_ethtool.c ---
> netdev-2.6/drivers/net/ixgb/ixgb_ethtool.c2005-08-05
09:25:28.0
> -0700 +++ netdev-2.6/drivers/net/ixgb.new/ixgb_ethtool.c
2005-08-05
> 09:25:38.0 -0700 @@ -301,7 +301,8 @@ ixgb_get_regs(struct
> net_device *netdev,
>   *reg++ = IXGB_READ_REG(hw, RAIDC);  /*  19 */
>   *reg++ = IXGB_READ_REG(hw, RXCSUM); /*  20 */
>
> - for (i = 0; i < IXGB_RAR_ENTRIES; i++) {
> + /* there are 16 RAR entries in hardware, we only use 3 */
> + for(i = 0; i < 16; i++) {

Please define a symbol for this constant somewhere. Introducing
hardcoded values are a regression in readability.
Suggested symbol: "#define IXGB_ALL_RAR_ENTRIES 16"


Regards

Ingo Oeser

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH net-drivers-2.6 1/9] ixgb: Set RXDCTL:PTHRESH/HTHRESH to zero

2005-08-05 Thread Chilakala, Mallikarjuna 
I was able to find the problem, I'll resend the updated ones :) 
-Malli

-Original Message-
From: Jeff Garzik [mailto:[EMAIL PROTECTED] 
Sent: Sunday, June 26, 2005 9:37 PM
To: Chilakala, Mallikarjuna
Cc: Netdev List
Subject: Re: [PATCH net-drivers-2.6 1/9] ixgb: Set
RXDCTL:PTHRESH/HTHRESH to zero

hmmm, none of the ixgb patches apply here...

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html