[PATCH 2.6.19-rc6] netfilter: fix panic on ip_conntrack_h323 with CONFIG_IP_NF_CT_ACCT
H.323 connection tracking code calls ip_ct_refresh_acct() when processing RCFs and URQs but passes NULL as the skb. When CONFIG_IP_NF_CT_ACCT is enabled, the connection tracking core tries to derefence the skb, which results in an obvious panic. A similar fix was applied on the SIP connection tracking code some time ago. Signed-off-by: Faidon Liambotis [EMAIL PROTECTED] --- a/net/ipv4/netfilter/ip_conntrack_helper_h323.c 2006-11-15 19:07:50.0 +0200 +++ b/net/ipv4/netfilter/ip_conntrack_helper_h323.c 2006-11-16 11:09:46.0 +0200 @@ -1417,7 +1417,7 @@ static int process_rcf(struct sk_buff ** DEBUGP (ip_ct_ras: set RAS connection timeout to %u seconds\n, info-timeout); - ip_ct_refresh_acct(ct, ctinfo, NULL, info-timeout * HZ); + ip_ct_refresh_acct(ct, ctinfo, *pskb, info-timeout * HZ); /* Set expect timeout */ read_lock_bh(ip_conntrack_lock); @@ -1465,7 +1465,7 @@ static int process_urq(struct sk_buff ** info-sig_port[!dir] = 0; /* Give it 30 seconds for UCF or URJ */ - ip_ct_refresh_acct(ct, ctinfo, NULL, 30 * HZ); + ip_ct_refresh_acct(ct, ctinfo, *pskb, 30 * HZ); return 0; } - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2.6.17-rc6] Remove Prism II support from Orinoco
Hi,
Pavel Roskin wrote:
The patch in question was never submitted to the orinoco mailing list.
I believe any such changes should be discussed by people using the
driver and participating in its development. It's not some minor change
or API update.
I'm sorry for not submitting/CCing this to the orinoco mailing list, I
should have.
I'm ready to consider disabling some ID's conditionally, primarily for
systems that cannot use udev. But it's far from the top of my TODO
list. And I'm not sure it would actually help users of desktop
distributions.
Well, that would be very nice, thanks!
But do you think that it will be enough? I mean, orinoco_{pci,plx,tdm}
exist only to support Prism2 chipsets.
HostAP a rather big and complete driver for Prism2/2.5/3.0 chipsets;
we're going to have another one based on the dscape stack too.
Do you think that there's a point on having the orinoco driver
supporting this chipset any more?
I don't mean to disrespect your work -- orinoco has served us for quite
a few years, but HostAP seems like a better alternative for these cards.
Please don't get offended by this -- I'm sure you've spent quite some
time on the particular code.
Regarding the disabling of IDs, I could prepare a patch for orinoco_cs
that would disable Prism2 support via a configuration option. Would that
be helpful/acceptable?
Best regards,
Faidon
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2.6.17-rc6] Remove Prism II support from Orinoco
On Sun, Jun 11, 2006 at 06:40:54PM -0400, Dave Jones wrote: Ah-ha, I had tested the wrong card. I also have a Sitecom card, which matches this ident you remove in your patch.. PCMCIA_DEVICE_MANF_CARD(0xd601, 0x0002), /* Safeway 802.11b, ZCOMAX AirRunner/XI-300 */ snip So with your patch, this card will become totally useless to me. I think you should forward this bug to the HostAP maintainer. This should be either be fixed in the driver or the driver should stop claiming that it supports this card. I merely found the duplicate IDs and removed them from Orinoco. I don't have neither the hardware or the time to test 30+ cards... Having two drivers supporting the same set of hardware seems pretty pointless to me. Plus, it confuses hotplugging/automatic detection. Regards, Faidon - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2.6.17-rc6] Remove Prism II support from Orinoco
On Mon, Jun 12, 2006 at 11:24:39AM -0400, John W. Linville wrote: On Mon, Jun 12, 2006 at 01:49:54AM +0300, Faidon Liambotis wrote: Having two drivers supporting the same set of hardware seems pretty pointless to me. Plus, it confuses hotplugging/automatic detection. This subject comes-up from time to time. In fact, I'm pretty sure it came-up very recently w.r.t. orinoco and hostap. I remember a patch that added all of Orinoco PCI IDs to HostAP. I'm not sure if you're referring to that, but that's pretty different (and obviously wrong). The consensus seems to be that drivers should have IDs for all devices they support, even if that means that some devices are supported by multiple drivers. This leaves the choice of which driver to use in the hands of the user and/or distro. I'd mostly agree to that if distributors had a way to enable/disable Prism2 support on the orinoco_cs driver based on a build-time configuration option. Should I prepare such a patch? FWIW, I think we've experienced a similar situation like this in the past in the networking land and the consensus was to completely remove the other driver. I'm referring to e100/eepro100, of course. Regards, Faidon - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Remove Prism II support from Orinoco
Stephen Hemminger wrote: my problem is that for my prism 2 adapter both drivers are loaded at which point neither of them works. I'm running FC5, and i have to keep removing the orinoco*.ko files to keep them from loading, so I'm all for this patch. use blacklist in module config to block one. Just put in /etc/modprobe.conf blacklist orinoco Unfortunately, that workaround doesn't work so well when you want to have the ability to plug real orinoco (hermes) cards to your computer... In other words and unless I'm missing something, there isn't currently a way to have a Hermes card and a Prism II card both plugged in and working. Regards, Faidon - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2.6.17-rc6] Remove Prism II support from Orinoco
Remove Prism II IDs from the orinoco driver since now we have a separate
driver for them (HostAP). Additionally, kill orinoco_{pci,plx,nortel}
completely, since they only exist to support Prism cards.
No attempt was made to clean up the rest of the driver of the actual
Prism II code, only the PCI IDs were removed.
Signed-off-by: Faidon Liambotis [EMAIL PROTECTED]
--
drivers/net/wireless/Kconfig | 61 -
drivers/net/wireless/Makefile |4
drivers/net/wireless/orinoco_cs.c | 24 --
drivers/net/wireless/orinoco_nortel.c | 312 --
drivers/net/wireless/orinoco_pci.c| 399 -
drivers/net/wireless/orinoco_plx.c| 403 --
drivers/net/wireless/orinoco_tmd.c| 260 -
7 files changed, 9 insertions(+), 1454 deletions(-)
diff -Nur linux-2.6.17-rc6/drivers/net/wireless/Kconfig
linux/drivers/net/wireless/Kconfig
--- linux-2.6.17-rc6/drivers/net/wireless/Kconfig 2006-06-06
03:57:02.0 +0300
+++ linux/drivers/net/wireless/Kconfig 2006-06-10 19:03:27.0 +0300
@@ -285,18 +285,16 @@
depends on NET_RADIO (PPC_PMAC || PCI || PCMCIA)
---help---
A driver for 802.11b wireless cards based based on the Hermes or
- Intersil HFA384x (Prism 2) MAC controller. This includes the vast
- majority of the PCMCIA 802.11b cards (which are nearly all rebadges)
- - except for the Cisco/Aironet cards. Cards supported include the
- Apple Airport (not a PCMCIA card), WavelanIEEE/Orinoco,
- Cabletron/EnteraSys Roamabout, ELSA AirLancer, MELCO Buffalo, Avaya,
- IBM High Rate Wireless, Farralon Syyline, Samsung MagicLAN, Netgear
- MA401, LinkSys WPC-11, D-Link DWL-650, 3Com AirConnect, Intel
- PRO/Wireless, and Symbol Spectrum24 High Rate amongst others.
+ MAC controller. Cards supported include the Apple Airport (not a
+ PCMCIA card), WavelanIEEE/Orinoco, Cabletron/EnteraSys Roamabout,
+ ELSA AirLancer, MELCO Buffalo, Avaya, IBM High Rate Wireless,
+ Farralon Syyline, Samsung MagicLAN, Netgear MA401, LinkSys WPC-11,
+ D-Link DWL-650, 3Com AirConnect, Intel PRO/Wireless, and Symbol
+ Spectrum24 High Rate amongst others.
This option includes the guts of the driver, but in order to
actually use a card you will also need to enable support for PCMCIA
- Hermes cards, PLX9052 based PCI adaptors or the Apple Airport below.
+ Hermes cards or the Apple Airport below.
You will also very likely also need the Wireless Tools in order to
configure your card and that /etc/pcmcia/wireless.opts works :
@@ -314,46 +312,6 @@
This driver does not support the Airport Extreme (802.11b/g). Use
the BCM43xx driver for Airport Extreme cards.
-config PLX_HERMES
- tristate Hermes in PLX9052 based PCI adaptor support (Netgear MA301
etc.)
- depends on PCI HERMES
- help
- Enable support for PCMCIA cards supported by the Hermes (aka
- orinoco) driver when used in PLX9052 based PCI adaptors. These
- adaptors are not a full PCMCIA controller but act as a more limited
- PCI - PCMCIA bridge. Several vendors sell such adaptors so that
- 802.11b PCMCIA cards can be used in desktop machines. The Netgear
- MA301 is such an adaptor.
-
-config TMD_HERMES
- tristate Hermes in TMD7160 based PCI adaptor support
- depends on PCI HERMES
- help
- Enable support for PCMCIA cards supported by the Hermes (aka
- orinoco) driver when used in TMD7160 based PCI adaptors. These
- adaptors are not a full PCMCIA controller but act as a more limited
- PCI - PCMCIA bridge. Several vendors sell such adaptors so that
- 802.11b PCMCIA cards can be used in desktop machines.
-
-config NORTEL_HERMES
- tristate Nortel emobility PCI adaptor support
- depends on PCI HERMES
- help
- Enable support for PCMCIA cards supported by the Hermes (aka
- orinoco) driver when used in Nortel emobility PCI adaptors. These
- adaptors are not full PCMCIA controllers, but act as a more limited
- PCI - PCMCIA bridge.
-
-config PCI_HERMES
- tristate Prism 2.5 PCI 802.11b adaptor support
- depends on PCI HERMES
- help
- Enable support for PCI and mini-PCI 802.11b wireless NICs based on
- the Prism 2.5 chipset. These are true PCI cards, not the 802.11b
- PCMCIA cards bundled with PCI-PCMCIA adaptors which are also
- common. Some of the built-in wireless adaptors in laptops are of
- this variety.
-
config ATMEL
tristate Atmel at76c50x chipset 802.11b support
depends on NET_RADIO (PCI || PCMCIA)
@@ -388,9 +346,8 @@
A driver for Hermes chipset based PCMCIA wireless adaptors
[PATCH 2.6.17-rc6] Add two PLX device IDs
This patch adds device IDs for Symbol LA-4123 and Global Sun Tech GL24110P to the HostAP PLX driver. This is not tested with real hardware, but there is no reason why it shouldn't work. Please test. Signed-off-by: Faidon Liambotis [EMAIL PROTECTED] -- hostap_plx.c |2 ++ 1 files changed, 2 insertions(+) diff -Nur linux-2.6.17-rc6/drivers/net/wireless/hostap/hostap_plx.c linux/drivers/net/wireless/hostap/hostap_plx.c --- linux-2.6.17-rc6/drivers/net/wireless/hostap/hostap_plx.c 2006-06-06 03:57:02.0 +0300 +++ linux/drivers/net/wireless/hostap/hostap_plx.c 2006-06-10 19:20:10.0 +0300 @@ -67,10 +67,12 @@ PLXDEV(0x10b7, 0x7770, 3Com AirConnect PCI 777A), PLXDEV(0x111a, 0x1023, Siemens SpeedStream SS1023), PLXDEV(0x126c, 0x8030, Nortel emobility), + PLXDEV(0x1562, 0x0001, Symbol LA-4123), PLXDEV(0x1385, 0x4100, Netgear MA301), PLXDEV(0x15e8, 0x0130, National Datacomm NCP130 (PLX9052)), PLXDEV(0x15e8, 0x0131, National Datacomm NCP130 (TMD7160)), PLXDEV(0x1638, 0x1100, Eumitcom WL11000), + PLXDEV(0x16ab, 0x1100, Global Sun Tech GL24110P), PLXDEV(0x16ab, 0x1101, Global Sun Tech GL24110P (?)), PLXDEV(0x16ab, 0x1102, Linksys WPC11 with WDT11), PLXDEV(0x16ab, 0x1103, Longshine 8031), - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC] Geographical/regulatory information for ieee80211
Ulrich Kunitz wrote: For the 802.11a frequencies, there are three bands: Annex 3 Band B 5150-5250 MHz for indoor use (36-48) Annex 3 Band C 5250-5350 MHz for indoor use (52-64) Annex 3 Band D 5470-5725 MHz for outdoor use (100-140) However these bands are not available in all European states, details can be found in the recommendation. Spain, Portugal, Greece and Belgium for instance don't allow Annex 3 Band D. Actually, Greece allows 5150-5250 and 5250-5350MHz for indoor use and 5470-5725 for indoor and outdoor use. This is quite new though (3rd April) :-) As I've mailed Larry in private, EU countries will eventually conform to this: http://europa.eu.int/eur-lex/lex/LexUriServ/LexUriServ.do?uri=CELEX:32005D0513:EN:NOT Regards, Faidon - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
