Re: [PATCH net] Revert "net: Add driver helper functions to determine checksum offloadability"
On 13/10/16 15:35, David Miller wrote: From: Stephen Hemminger Date: Tue, 11 Oct 2016 13:04:09 -0700 This reverts commit 6ae23ad36253a8033c5714c52b691b84456487c5. The code has been in kernel since 4.4 but there are no in tree code that uses. Unused code is broken code, remove it. Signed-off-by: Stephen Hemminger Tom if you have any real plans to develop on this work at all in the immediate future, please speak up now. Otherwise I'm applying Stephen's patch. Thanks. Oops, nope, I tell a lie. We used it initially and then realised we didn't strictly need it since we only advertise IP_CSUM and IPV6_CSUM of inner packets, so we should never be presented with a packet we'd need to call the helper for. So we're not using it after all. Jon
Re: [PATCH net] Revert "net: Add driver helper functions to determine checksum offloadability"
On 13/10/16 15:35, David Miller wrote: From: Stephen Hemminger Date: Tue, 11 Oct 2016 13:04:09 -0700 This reverts commit 6ae23ad36253a8033c5714c52b691b84456487c5. The code has been in kernel since 4.4 but there are no in tree code that uses. Unused code is broken code, remove it. Signed-off-by: Stephen Hemminger Tom if you have any real plans to develop on this work at all in the immediate future, please speak up now. Otherwise I'm applying Stephen's patch. Thanks. We've used this in our overlay support, which we plan to upstream in the next month or two (or at least Soon(tm)), so we'd rather it stayed in otherwise we'll just have to reimplement it. Jon
