[PATCH] 2.6.25-rc1 ml4x network driver build failure

2008-02-12 Thread Kamalesh Babulal
The 2.6.25-rc1 kernel build fails on the powerpc with the error

drivers/net/mlx4/alloc.c: In function ‘mlx4_buf_alloc’:
drivers/net/mlx4/alloc.c:162: error: implicit declaration of function ‘vmap’
drivers/net/mlx4/alloc.c:162: error: ‘VM_MAP’ undeclared (first use in this 
function)
drivers/net/mlx4/alloc.c:162: error: (Each undeclared identifier is reported 
only once
drivers/net/mlx4/alloc.c:162: error: for each function it appears in.)
drivers/net/mlx4/alloc.c:162: warning: assignment makes pointer from integer 
without a cast
drivers/net/mlx4/alloc.c: In function ‘mlx4_buf_free’:
drivers/net/mlx4/alloc.c:187: error: implicit declaration of function ‘vunmap’
make[3]: *** [drivers/net/mlx4/alloc.o] Error 1
make[2]: *** [drivers/net/mlx4] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2

I have tested the patch for the build failure.

Signed-off-by: Kamalesh Babulal <[EMAIL PROTECTED]>
--
--- linux-2.6.25-rc1/drivers/net/mlx4/alloc.c   2008-02-11 03:48:14.0 
+0530
+++ linux-2.6.25-rc1/drivers/net/mlx4/~alloc.c  2008-02-12 14:43:46.0 
+0530
@@ -34,6 +34,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include "mlx4.h"
 
-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] 2.6.24-mm1 section type conflict cleanup

2008-02-04 Thread Kamalesh Babulal
Sam Ravnborg wrote:
> On Mon, Feb 04, 2008 at 09:52:23PM +0530, Kamalesh Babulal wrote:
>> Hi Andrew,
>>
>> The 2.6.24-mm1 kernel build fails at many places with section type
>> conflict build error.
> 
> What arch?
> We have troubles with powerpc as pointed out by Al in another thread.
> 
>   Sam
Hi Sam,

This clean up is done for the powerpc, sorry forgot to mention it.

-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] 2.6.24-mm1 section type conflict cleanup

2008-02-04 Thread Kamalesh Babulal
Hi Andrew,

The 2.6.24-mm1 kernel build fails at many places with section type
conflict build error.

drivers/net/typhoon.c:181: error: typhoon_card_info causes a section type 
conflict
make[2]: *** [drivers/net/typhoon.o] Error 1

drivers/net/natsemi.c:245: error: natsemi_pci_info causes a section type 
conflict
make[2]: *** [drivers/net/natsemi.o] Error 1

drivers/net/bnx2.c:95: error: board_info causes a section type conflict
make[2]: *** [drivers/net/bnx2.o] Error 1

drivers/net/bnx2x.c:112: error: board_info causes a section type conflict
make[2]: *** [drivers/net/bnx2x.o] Error 1

drivers/net/bnx2x.c:112: error: board_info causes a section type conflict
make[2]: *** [drivers/net/bnx2x.o] Error 1

drivers/net/via-velocity.c:453: error: velocity_id_table causes a section type 
conflict
make[2]: *** [drivers/net/via-velocity.o] Error 1

drivers/net/starfire.c:350: error: netdrv_tbl causes a section type conflict
make[2]: *** [drivers/net/starfire.o] Error 1


I have tested the patch for build test only

Signed-off-by: Kamalesh Babulal <[EMAIL PROTECTED]>
--
--- linux-2.6.24/drivers/net/typhoon.c  2008-01-25 04:28:37.0 +0530
+++ linux-2.6.24/drivers/net/~typhoon.c 2008-02-04 16:21:55.0 +0530
@@ -178,7 +178,7 @@ enum typhoon_cards {
 };
 
 /* directly indexed by enum typhoon_cards, above */
-static const struct typhoon_card_info typhoon_card_info[] __devinitdata = {
+static const struct typhoon_card_info typhoon_card_info[] __devinitconst = {
{ "3Com Typhoon (3C990-TX)",
TYPHOON_CRYPTO_NONE},
{ "3Com Typhoon (3CR990-TX-95)",
--- linux-2.6.24/drivers/net/natsemi.c  2008-02-04 14:57:00.0 +0530
+++ linux-2.6.24/drivers/net/~natsemi.c 2008-02-04 16:36:22.0 +0530
@@ -242,7 +242,7 @@ static const struct {
const char *name;
unsigned long flags;
unsigned int eeprom_size;
-} natsemi_pci_info[] __devinitdata = {
+} natsemi_pci_info[] __devinitconst = {
{ "Aculab E1/T1 PMXc cPCI carrier card", NATSEMI_FLAG_IGNORE_PHY, 128 },
{ "NatSemi DP8381[56]", 0, 24 },
 };
--- linux-2.6.24/drivers/net/bnx2.c 2008-02-04 14:56:59.0 +0530
+++ linux-2.6.24/drivers/net/~bnx2.c2008-02-04 16:44:02.0 +0530
@@ -92,7 +92,7 @@ typedef enum {
 /* indexed by board_t, above */
 static const struct {
char *name;
-} board_info[] __devinitdata = {
+} board_info[] __devinitconst = {
{ "Broadcom NetXtreme II BCM5706 1000Base-T" },
{ "HP NC370T Multifunction Gigabit Server Adapter" },
{ "HP NC370i Multifunction Gigabit Server Adapter" },
--- linux-2.6.24/drivers/net/bnx2.c 2008-02-04 16:44:47.0 +0530
+++ linux-2.6.24/drivers/net/~bnx2.c2008-02-04 16:47:08.0 +0530
@@ -104,7 +104,7 @@ static const struct {
{ "Broadcom NetXtreme II BCM5709 1000Base-SX" },
};
 
-static struct pci_device_id bnx2_pci_tbl[] = {
+static struct pci_device_id bnx2_pci_tbl[] __devinitconst = {
{ PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_NX2_5706,
  PCI_VENDOR_ID_HP, 0x3101, 0, 0, NC370T },
{ PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_NX2_5706,
--- linux-2.6.24/drivers/net/bnx2x.c2008-02-04 14:57:00.0 +0530
+++ linux-2.6.24/drivers/net/~bnx2x.c   2008-02-04 18:01:14.0 +0530
@@ -109,7 +109,7 @@ enum bnx2x_board_type {
 /* indexed by board_t, above */
 static const struct {
char *name;
-} board_info[] __devinitdata = {
+} board_info[] __devinitconst = {
{ "Broadcom NetXtreme II BCM57710 XGb" }
 };
 
--- linux-2.6.24/drivers/net/starfire.c 2008-01-25 04:28:37.0 +0530
+++ linux-2.6.24/drivers/net/~starfire.c2008-02-04 18:08:08.0 
+0530
@@ -347,7 +347,7 @@ MODULE_DEVICE_TABLE(pci, starfire_pci_tb
 static const struct chip_info {
const char *name;
int drv_flags;
-} netdrv_tbl[] __devinitdata = {
+} netdrv_tbl[] __devinitconst = {
{ "Adaptec Starfire 6915", CanHaveMII },
 };
 
--- linux-2.6.24/drivers/net/via-velocity.c 2008-02-04 14:57:00.0 
+0530
+++ linux-2.6.24/drivers/net/~via-velocity.c2008-02-04 18:04:21.0 
+0530
@@ -450,7 +450,7 @@ static const struct velocity_info_tbl ch
  * device driver. Used for hotplug autoloading.
  */
 
-static const struct pci_device_id velocity_id_table[] __devinitdata = {
+static const struct pci_device_id velocity_id_table[] __devinitconst = {
    { PCI_DEVICE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_612X) },
{ }
 };
-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[BUILD FAILURE] 2.6.24-git7 section type conflict at various drivers on powerpc

2008-01-30 Thread Kamalesh Babulal
 mismatch in 
reference from the function .mlx4_init_icm() to the function 
.devinit.text:.mlx4_init_cmpt_table()
The function  .mlx4_init_icm() references
the function __devinit .mlx4_init_cmpt_table().
This is often because .mlx4_init_icm lacks a __devinit 
annotation or the annotation of .mlx4_init_cmpt_table is wrong.

WARNING: drivers/net/mlx4/mlx4_core.o(.text+0x728c): Section mismatch in 
reference from the function .mlx4_init_hca() to the function 
.devinit.text:.mlx4_load_fw()
The function  .mlx4_init_hca() references
the function __devinit .mlx4_load_fw().
This is often because .mlx4_init_hca lacks a __devinit 
annotation or the annotation of .mlx4_load_fw is wrong.

WARNING: drivers/net/mlx4/mlx4_core.o(.text+0x7c98): Section mismatch in 
reference from the function .__mlx4_init_one() to the function 
.devinit.text:.mlx4_enable_msi_x()
The function  .__mlx4_init_one() references
the function __devinit .mlx4_enable_msi_x().
This is often because .__mlx4_init_one lacks a __devinit 
annotation or the annotation of .mlx4_enable_msi_x is wrong.

WARNING: drivers/net/mlx4/mlx4_core.o(.text+0x97ac): Section mismatch in 
reference from the function .mlx4_init_mr_table() to the function 
.devinit.text:.mlx4_buddy_init()
The function  .mlx4_init_mr_table() references
the function __devinit .mlx4_buddy_init().
This is often because .mlx4_init_mr_table lacks a __devinit 
annotation or the annotation of .mlx4_buddy_init is wrong.

  LD  drivers/net/mlx4/built-in.o
WARNING: drivers/net/mlx4/built-in.o(.text+0x6cf8): Section mismatch in 
reference from the function .mlx4_init_icm() to the function 
.devinit.text:.mlx4_init_cmpt_table()
The function  .mlx4_init_icm() references
the function __devinit .mlx4_init_cmpt_table().
This is often because .mlx4_init_icm lacks a __devinit 
annotation or the annotation of .mlx4_init_cmpt_table is wrong.

WARNING: drivers/net/mlx4/built-in.o(.text+0x728c): Section mismatch in 
reference from the function .mlx4_init_hca() to the function 
.devinit.text:.mlx4_load_fw()
The function  .mlx4_init_hca() references
the function __devinit .mlx4_load_fw().
This is often because .mlx4_init_hca lacks a __devinit 
annotation or the annotation of .mlx4_load_fw is wrong.

WARNING: drivers/net/mlx4/built-in.o(.text+0x7c98): Section mismatch in 
reference from the function .__mlx4_init_one() to the function 
.devinit.text:.mlx4_enable_msi_x()
The function  .__mlx4_init_one() references
the function __devinit .mlx4_enable_msi_x().
This is often because .__mlx4_init_one lacks a __devinit 
annotation or the annotation of .mlx4_enable_msi_x is wrong.

WARNING: drivers/net/mlx4/built-in.o(.text+0x97ac): Section mismatch in 
reference from the function .mlx4_init_mr_table() to the function 
.devinit.text:.mlx4_buddy_init()
The function  .mlx4_init_mr_table() references
the function __devinit .mlx4_buddy_init().
This is often because .mlx4_init_mr_table lacks a __devinit 
annotation or the annotation of .mlx4_buddy_init is wrong.

WARNING: drivers/net/tokenring/built-in.o(.text+0x4d64): Section mismatch in 
reference from the function .olympic_open() to the function 
.devinit.text:.olympic_init()
The function  .olympic_open() references
the function __devinit .olympic_init().
This is often because .olympic_open lacks a __devinit 
annotation or the annotation of .olympic_init is wrong.


-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [BUILD FAILURE]2.6.24-git6 build failure on sis190 ethernet driver

2008-01-30 Thread Kamalesh Babulal
Sam Ravnborg wrote:
> On Wed, Jan 30, 2008 at 09:11:36AM +0530, Kamalesh Babulal wrote:
>> Hi,
>>
>> The 2.6.24-git6 kernel build fails on various x86_64 machines with the build 
>> failure
>>
>> drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type 
>> conflict
>> make[2]: *** [drivers/net/sis190.o] Error 1
>>
>> # gcc --version (machine1)
>> gcc (GCC) 4.1.1 20070105 (Red Hat 4.1.1-52)
>>
>> # gcc --version (machine2)
>> gcc (GCC) 4.1.1 20060525 (Red Hat 4.1.1-1)
> 
> Hi Kamalesh
> 
> I know another patch is circulating, but please try the following.

Hi Sam,

Thanks, the patch fixes the build failure.

Tested-by: Kamalesh Babulal <[EMAIL PROTECTED]>

> diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c
> index b570402..0a5e024 100644
> --- a/drivers/net/sis190.c
> +++ b/drivers/net/sis190.c
> @@ -1556,7 +1556,7 @@ static int __devinit 
> sis190_get_mac_addr_from_eeprom(struct pci_dev *pdev,
>  static int __devinit sis190_get_mac_addr_from_apc(struct pci_dev *pdev,
>  struct net_device *dev)
>  {
> - static const u16 __devinitdata ids[] = { 0x0965, 0x0966, 0x0968 };
> + static const u16 __devinitconst ids[] = { 0x0965, 0x0966, 0x0968 };
>   struct sis190_private *tp = netdev_priv(dev);
>   struct pci_dev *isa_bridge;
>   u8 reg, tmp8;
> 
> It is the better fix if you can confirm it working.
> The section conflict issued by gcc happens because we try to
> mix const and non-const data in the same section.
> 
>   Sam


-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [BUILD FAILURE]2.6.24-git6 build failure on sis190 ethernet driver

2008-01-30 Thread Kamalesh Babulal
Gabriel C wrote:
> Kamalesh Babulal wrote:
>> Hi,
>>
>> The 2.6.24-git6 kernel build fails on various x86_64 machines with the build 
>> failure
>>
>> drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type 
>> conflict
>> make[2]: *** [drivers/net/sis190.o] Error 1
>>
>> # gcc --version (machine1)
>> gcc (GCC) 4.1.1 20070105 (Red Hat 4.1.1-52)
>>
>> # gcc --version (machine2)
>> gcc (GCC) 4.1.1 20060525 (Red Hat 4.1.1-1)
>>
> 
> Heh :) vger.kernel.org does not like emails directly from gmail , it seems =)
> 
> ( sorry for sending this 3 time now )
> 
> The following patch should fix the build failure.
> 
> diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c
> index b570402..e48e4ad 100644
> --- a/drivers/net/sis190.c
> +++ b/drivers/net/sis190.c
> @@ -326,7 +326,7 @@ static const struct {
>   { "SiS 191 PCI Gigabit Ethernet adapter" },
>  };
> 
> -static struct pci_device_id sis190_pci_tbl[] __devinitdata = {
> +static const struct pci_device_id sis190_pci_tbl[] __devinitdata = {
>   { PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0190), 0, 0, 0 },
>   { PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0191), 0, 0, 1 },
>   { 0, },
> 
> 
> Gabriel

Hi Gabriel,

Thanks, the patch fixes the build failure.


-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[BUILD FAILURE]2.6.24-git6 build failure on sis190 ethernet driver

2008-01-29 Thread Kamalesh Babulal
Hi,

The 2.6.24-git6 kernel build fails on various x86_64 machines with the build 
failure

drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict
make[2]: *** [drivers/net/sis190.o] Error 1

# gcc --version (machine1)
gcc (GCC) 4.1.1 20070105 (Red Hat 4.1.1-52)

# gcc --version (machine2)
gcc (GCC) 4.1.1 20060525 (Red Hat 4.1.1-1)

-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: 2.6.24-rc8-mm1 : net tcp_input.c warnings

2008-01-24 Thread Kamalesh Babulal
On Thu, Jan 24, 2008 at 11:54:18AM +0200, Ilpo Järvinen wrote:
> On Thu, 24 Jan 2008, Dave Young wrote:
> 
> Hi Dave (& others),
> 
> > Thanks.
> 
> Thanks a lot, I was first to ignore all these because they occurred 
> with newreno, but looked again... :-/
> 
> > New warning trigged with your debug patch:
> 
> This was probably with the earlier one I sent to you because there's still 
> this case remaining which itself is valid:
> 
> > P: 5 L: 0 vs 0 S: 0 vs 1 w: 2044790889-2044796616 (0)
> 
> ...snip... this is still ok state (S+L <= P):
> 
> > P: 5 L: 0 vs 0 S: 0 vs 3 w: 2044790889-2044796616 (0)
> > TCP wq(s)  <
> > TCP wq(h) +++h+<
> > l0 s3 f0 p5 seq: su2044790889 hs2044795029 sn2044796616
> > [ cut here ]
> > WARNING: at net/ipv4/tcp_input.c:2169 tcp_mark_head_lost+0x122/0x150()
> > Modules linked in: snd_seq_dummy snd_seq_oss snd_seq_midi_event
> > snd_seq snd_seq_device snd_pcm_oss snd_mixer_oss eeprom e100 psmouse
> > snd_hda_intel snd_pcm snd_timer btusb bluetooth serio_raw snd 3c59x sg
> > evdev thermal soundcore rtc_cmos snd_page_alloc rtc_core rtc_lib
> > i2c_i801 processor button intel_agp dcdbas pcspkr agpgart
> > Pid: 0, comm: swapper Not tainted 2.6.24-rc8-mm1 #8
> >  [] ? have_callable_console+0x20/0x30
> >  [] warn_on_slowpath+0x54/0x80
> >  [] ? tcp_print_queue+0x1a4/0x230
> >  [] ? vprintk+0x308/0x320
.
.

.
.

> > ---[ end trace 14b601818e6903ac ]---
> 
> ...But this no longer is, and even more, L: 5 is not valid state at this 
> point all (should only happen if we went to RTO but it would reset S to 
> zero with newreno):
> 
> > P: 5 L: 5 vs 5 S: 0 vs 3 w: 2044790889-2044796616 (0)
> > TCP wq(s) l<
> > TCP wq(h) +++h+<
> > l5 s3 f0 p5 seq: su2044790889 hs2044795029 sn2044796616
> 
> Surprisingly, it was the first time the WARN_ON for left_out returned 
> correct location. This also explains why the patch I sent to Krishna 
> didn't print anything (it didn't end up into printing because I forgot 
> to add L+S>P check into to the state checking if).
> 
> ...so please, could you (others than Denys) try this patch, it should 
> solve the issue. And Denys, could you confirm (and if necessary double 
> check) that the kernel you saw this similar problem with is the pure 
> Linus' mainline, i.e., without any net-2.6.25 or mm bits please, if so, 
> that problem persists. And anyway, there were some fackets_out related 
> problems reported as well and this doesn't help for that but I think I've 
> lost track of who was seeing it due to large number of reports :-), could 
> somebody refresh my memory because I currently don't have time to dig it 
> up from archives (at least on this week).
> 
> 
> -- 
>  i.
> 
> --
> [PATCH] [TCP]: NewReno must count every skb while marking losses
> 
> NewReno should add cnt per skb (as with FACK) instead of depending
> on SACKED_ACKED bits which won't be set with it at all.
> Effectively, NewReno should always exists after the first
> iteration anyway (or immediately if there's already head in
> lost_out.
> 
> This was fixed earlier in net-2.6.25 but got reverted among other
> stuff and I didn't notice that this is still necessary (actually
> wasn't even considering this case while trying to figure out the
> reports because I lived with different kind of code than it in
> reality was).
> 
> This should solve the WARN_ONs in TCP code that as a result of
> this triggered multiple times in every place we check for this
> invariant.
> 
> Special thanks to Dave Young <[EMAIL PROTECTED]> and
> Krishna Kumar2 <[EMAIL PROTECTED]> for trying with my debug
> patches.

Hi,

Thanks, after applying the patch the warning is not seen.


  Tested-by: Kamalesh Babulal <[EMAIL PROTECTED]> 
> Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]>
> ---
>  net/ipv4/tcp_input.c |2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
> index 295490e..aa409a5 100644
> --- a/net/ipv4/tcp_input.c
> +++ b/net/ipv4/tcp_input.c
> @@ -2156,7 +2156,7 @@ static void tcp_mark_head_lost(struct sock *sk, int 
> packets, int fast_rexmit)
>   tp->lost_skb_hint = skb;
>   tp->lost_cnt_hint = cnt;
> 
> - if (tcp_is_fack(tp) ||
> + if (tcp_is_fack(tp) || tcp_is_reno(tp) ||
>   (TCP_SKB_CB(skb)->sacked & TCPCB_SACKED_ACKED))
>   cnt += tcp_skb_pcount(skb);
> 
> -- 
> 1.5.2.2


-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: 2.6.24-rc8-mm1 Badness at net/ipv4/tcp_input.c:2506

2008-01-23 Thread Kamalesh Babulal
) l *0x1f84
0x1f84 is in tcp_fastretrans_alert (net/ipv4/tcp_input.c:2504).
2499int is_dupack = !(flag & (FLAG_SND_UNA_ADVANCED | 
FLAG_NOT_DUP));
2500int do_lost = is_dupack || ((flag & FLAG_DATA_SACKED) &&
2501(tcp_fackets_out(tp) > 
tp->reordering));
2502int fast_rexmit = 0;
2503
2504if (WARN_ON(!tp->packets_out && tp->sacked_out))
2505tp->sacked_out = 0;
2506if (WARN_ON(!tp->sacked_out && tp->fackets_out))
2507        tp->fackets_out = 0;
2508


-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: mm snapshot broken-out-2007-11-20-01-45 Build Fail - net/wireless driver

2007-11-20 Thread Kamalesh Babulal
Hi Andrew,

The kernel build fails, with following message

  LD  drivers/net/wireless/built-in.o
drivers/net/wireless/rtl8187.o: In function `rtl8225z2_rf_init':
(.opd+0x180): multiple definition of `rtl8225z2_rf_init'
drivers/net/wireless/rtl8180.o:(.opd+0x1b0): first defined here
drivers/net/wireless/rtl8187.o: In function `rtl8225z2_rf_init':
/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8187_rtl8225.c:571: multiple 
definition of `.rtl8225z2_rf_init'
drivers/net/wireless/rtl8180.o:/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8180_rtl8225.c:561:
 first defined here
ld: Warning: size of symbol `.rtl8225z2_rf_init' changed from 3836 in 
drivers/net/wireless/rtl8180.o to 3544 in drivers/net/wireless/rtl8187.o
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_set_channel':
(.opd+0x160): multiple definition of `rtl8225_rf_set_channel'
drivers/net/wireless/rtl8180.o:(.opd+0x1d0): first defined here
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_init':
/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8187_rtl8225.c:329: multiple 
definition of `.rtl8225_rf_init'
drivers/net/wireless/rtl8180.o:/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8180_rtl8225.c:322:
 first defined here
ld: Warning: size of symbol `.rtl8225_rf_init' changed from 3492 in 
drivers/net/wireless/rtl8180.o to 3528 in drivers/net/wireless/rtl8187.o
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_stop':
(.opd+0x190): multiple definition of `rtl8225_rf_stop'
drivers/net/wireless/rtl8180.o:(.opd+0x1c0): first defined here
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_set_channel':
/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8187_rtl8225.c:735: multiple 
definition of `.rtl8225_rf_set_channel'
drivers/net/wireless/rtl8180.o:/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8180_rtl8225.c:753:
 first defined here
ld: Warning: size of symbol `.rtl8225_rf_set_channel' changed from 360 in 
drivers/net/wireless/rtl8180.o to 136 in drivers/net/wireless/rtl8187.o
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_init':
(.opd+0x170): multiple definition of `rtl8225_rf_init'
drivers/net/wireless/rtl8180.o:(.opd+0x1a0): first defined here
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_stop':
/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8187_rtl8225.c:719: multiple 
definition of `.rtl8225_rf_stop'
drivers/net/wireless/rtl8180.o:/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8180_rtl8225.c:736:
 first defined here
ld: Warning: size of symbol `.rtl8225_rf_stop' changed from 244 in 
drivers/net/wireless/rtl8180.o to 632 in drivers/net/wireless/rtl8187.o
make[3]: *** [drivers/net/wireless/built-in.o] Error 1
make[2]: *** [drivers/net/wireless] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2

The patch causing this build failure, might be git-wireless.patch.

-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded

2007-11-20 Thread Kamalesh Babulal
Hi Andrew,

The kernel build fails, with following message

  LD  drivers/net/wireless/built-in.o
drivers/net/wireless/rtl8187.o: In function `rtl8225z2_rf_init':
(.opd+0x180): multiple definition of `rtl8225z2_rf_init'
drivers/net/wireless/rtl8180.o:(.opd+0x1b0): first defined here
drivers/net/wireless/rtl8187.o: In function `rtl8225z2_rf_init':
/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8187_rtl8225.c:571: multiple 
definition of `.rtl8225z2_rf_init'
drivers/net/wireless/rtl8180.o:/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8180_rtl8225.c:561:
 first defined here
ld: Warning: size of symbol `.rtl8225z2_rf_init' changed from 3836 in 
drivers/net/wireless/rtl8180.o to 3544 in drivers/net/wireless/rtl8187.o
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_set_channel':
(.opd+0x160): multiple definition of `rtl8225_rf_set_channel'
drivers/net/wireless/rtl8180.o:(.opd+0x1d0): first defined here
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_init':
/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8187_rtl8225.c:329: multiple 
definition of `.rtl8225_rf_init'
drivers/net/wireless/rtl8180.o:/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8180_rtl8225.c:322:
 first defined here
ld: Warning: size of symbol `.rtl8225_rf_init' changed from 3492 in 
drivers/net/wireless/rtl8180.o to 3528 in drivers/net/wireless/rtl8187.o
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_stop':
(.opd+0x190): multiple definition of `rtl8225_rf_stop'
drivers/net/wireless/rtl8180.o:(.opd+0x1c0): first defined here
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_set_channel':
/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8187_rtl8225.c:735: multiple 
definition of `.rtl8225_rf_set_channel'
drivers/net/wireless/rtl8180.o:/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8180_rtl8225.c:753:
 first defined here
ld: Warning: size of symbol `.rtl8225_rf_set_channel' changed from 360 in 
drivers/net/wireless/rtl8180.o to 136 in drivers/net/wireless/rtl8187.o
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_init':
(.opd+0x170): multiple definition of `rtl8225_rf_init'
drivers/net/wireless/rtl8180.o:(.opd+0x1a0): first defined here
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_stop':
/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8187_rtl8225.c:719: multiple 
definition of `.rtl8225_rf_stop'
drivers/net/wireless/rtl8180.o:/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8180_rtl8225.c:736:
 first defined here
ld: Warning: size of symbol `.rtl8225_rf_stop' changed from 244 in 
drivers/net/wireless/rtl8180.o to 632 in drivers/net/wireless/rtl8187.o
make[3]: *** [drivers/net/wireless/built-in.o] Error 1
make[2]: *** [drivers/net/wireless] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2

The patch causing this build failure, might be git-wireless.patch.
-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [BUG] 2.6.23-git19 - S390x: Kernel panic while bringing up the network interface

2007-10-24 Thread Kamalesh Babulal
Heiko Carstens wrote:
> On Wed, Oct 24, 2007 at 08:59:06AM +0530, Kamalesh Babulal wrote:
>> Hi,
>>
>> Kernel panic's while bringing up the network interface with the 2.6.23-git19
>>
>> Setting network parameters:  Ý  OK  ¨
>> Bringing up loopback interface:  Ý  OK  ¨
>> Bringing up interface eth0:
>>  Ý<002e2f72>¨ inet_ioctl+0xd6/0x110
>>  Ý<0027cae2>¨ sock_ioctl+0x26e/0x2a0
>>  Ý<000b4c52>¨ do_ioctl+0x4a/0xac
>>  Ý<000b5076>¨ vfs_ioctl+0x3c2/0x3d8
>>  Ý<000b50ec>¨ sys_ioctl+0x60/0x88
>>  Ý<00021b7e>¨ sysc_noemu+0x10/0x16
>>  Ý<021201ca>¨ 0x21201ca
>>
>>  <0>Kernel panic - not syncing: Fatal exception in interrupt
>> 00: HCPGSP2629I The virtual machine is placed in CP mode due to a SIGP stop 
>> from
>>  CPU 01.
>> 02: HCPGSP2629I The virtual machine is placed in CP mode due to a SIGP stop 
>> from
>>  CPU 01.
>> 03: HCPGSP2629I The virtual machine is placed in CP mode due to a SIGP stop 
>> from
>>  CPU 01.
>> 01: HCPGIR450W CP entered; disabled wait PSW 00020001 8000  
>> 000164DE
> 
> That should be fixed with this one:
> 
> commit f1ecfd5d3b69d98b814435758c485e6fd0e112de
> Author: Ursula Braun <[EMAIL PROTECTED]>
> Date:   Mon Oct 22 16:16:14 2007 +0200
> 
> remove header_ops bug in qeth driver
> 
> Remove qeth bug caused by commit:
> [NET]: Move hardware header operations out of netdevice.
> 
> This is the second part of the qeth header_ops patch, since
> first patch sent 10/19 has been insufficient.
> Nevertheless first patch is still valid and should be kept.
>     
> Signed-off-by: Ursula Braun <[EMAIL PROTECTED]>
> Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
> 
> Patch is in -rc1. Could you please pull and try again? Thanks.

Hi,

The kernel panic is not seen in the 2.6.24-rc1 kernel.

-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[BUG] 2.6.23-git19 - S390x: Kernel panic while bringing up the network interface

2007-10-23 Thread Kamalesh Babulal
Hi,

Kernel panic's while bringing up the network interface with the 2.6.23-git19

Setting network parameters:  Ý  OK  ¨
Bringing up loopback interface:  Ý  OK  ¨
Bringing up interface eth0:
 Ý<002e2f72>¨ inet_ioctl+0xd6/0x110
 Ý<0027cae2>¨ sock_ioctl+0x26e/0x2a0
 Ý<000b4c52>¨ do_ioctl+0x4a/0xac
 Ý<000b5076>¨ vfs_ioctl+0x3c2/0x3d8
 Ý<000b50ec>¨ sys_ioctl+0x60/0x88
 Ý<00021b7e>¨ sysc_noemu+0x10/0x16
 Ý<021201ca>¨ 0x21201ca

 <0>Kernel panic - not syncing: Fatal exception in interrupt
00: HCPGSP2629I The virtual machine is placed in CP mode due to a SIGP stop from
 CPU 01.
02: HCPGSP2629I The virtual machine is placed in CP mode due to a SIGP stop from
 CPU 01.
03: HCPGSP2629I The virtual machine is placed in CP mode due to a SIGP stop from
 CPU 01.
01: HCPGIR450W CP entered; disabled wait PSW 00020001 8000  000164DE

-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: 2.6.23-rc8-mm2 - drivers/net/ibm_newemac/mal - broken

2007-09-27 Thread Kamalesh Babulal
Andrew Morton wrote:
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc8/2.6.23-rc8-mm2/

Hi Andrew,

The drivers/net/ibm_newemac/mal seems to be broken with 2.6.23-rc8-mm2 also, it 
was
reported on 2.6.23-rc8-mm1 (http://lkml.org/lkml/2007/9/25/173).


-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [2.6.23-rc4-mm1][Bug] kernel BUG at include/linux/netdevice.h:339!

2007-09-20 Thread Kamalesh Babulal
Andrew Morton wrote:
> On Mon, 17 Sep 2007 17:46:38 +0530
> Kamalesh Babulal <[EMAIL PROTECTED]> wrote:
>
>   
>> Kernel Bug is hit with 2.6.23-rc4-mm1 kernel on ppc64 machine.
>>
>> kernel BUG at include/linux/netdevice.h:339!
>> 
>
> (please cc netdev@vger.kernel.org on networking-related matters)
>
> You died here:
>
> static inline void napi_complete(struct napi_struct *n)
> {
> BUG_ON(!test_bit(NAPI_STATE_SCHED, &n->state));
>
> The NAPI changes have had a few problems and hopefully things have
> been fixed up since then.  I'll try to get rc6-mm1 out this evening,
> so please retest that?
>   
Hi Andrew,

I don't see this bug in the 2.6.23-rc6-mm1, till now.

-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: 2.6.23-rc4-mm1

2007-09-01 Thread Kamalesh Babulal

Andrew Morton wrote:

On Sat, 1 Sep 2007 15:53:53 +0900 KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> wrote:
I met 2 troubles while I compiled rc4-mm1 on x86/UP system,

One on pcnet32.c (patch is attaced below).
One on crypto CONFIG.

== compile log ==
drivers/net/pcnet32.c: In function 'pcnet32_netif_stop':
drivers/net/pcnet32.c:445: warning: unused variable 'lp'
drivers/net/pcnet32.c: In function 'pcnet32_netif_start':
drivers/net/pcnet32.c:455: warning: unused variable 'lp'
drivers/net/pcnet32.c: In function 'pcnet32_interrupt':
drivers/net/pcnet32.c:2622: error: 'struct net_device' has no member named 
'napi'



Only git-net touches pcnet32.c

  


Hi Kamezawa,

I got the pcnet32.c compile failure and after applying the patch compile 
does not fails.


Thanks & Regards,
Kamalesh Babulal.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html