Re: [PATCH 0/2] 9p: Fixes for hard-to-hit bugs

[Latchesar Ionkov]

Acked-by: Latchesar Ionkov 

On Wed, Sep 6, 2017 at 8:59 AM, Tuomas Tynkkynen  wrote:
> These two patches fix two hard-to-hit (but really annoying) bugs in 9p.
> The first one was posted earlier in February (with one R-b), the second
> is a new one.
>
> Both of these have had soaking in NixOS distribution kernels for
> a couple of months with no ill effects.
>
> Tuomas Tynkkynen (2):
>   fs/9p: Compare qid.path in v9fs_test_inode
>   net/9p: Switch to wait_event_killable()
>
>  fs/9p/vfs_inode.c  |  3 +++
>  fs/9p/vfs_inode_dotl.c |  3 +++
>  net/9p/client.c|  3 +--
>  net/9p/trans_virtio.c  | 13 ++---
>  net/9p/trans_xen.c |  4 ++--
>  5 files changed, 15 insertions(+), 11 deletions(-)
>
> --
> 2.13.0
>

Re: net/9p/mux.c: use-after-free

[Latchesar Ionkov]

Yep, it's a leak.

Thanks,
   Lucho

On 7/25/07, Eric Van Hensbergen <[EMAIL PROTECTED]> wrote:

On 7/22/07, Adrian Bunk <[EMAIL PROTECTED]> wrote:
> The Coverity checker spotted the following use-after-free
> in net/9p/mux.c:
>
> <--  snip  -->
>
> ...
> struct p9_conn *p9_conn_create(struct p9_transport *trans, int msize,
> unsigned char *extended)
> {
> ...
> if (!m->tagpool) {
> kfree(m);
> return ERR_PTR(PTR_ERR(m->tagpool));
> }
> ...
>
> <--  snip  -->
>

I've got a fix for this one:
if (!m->tagpool) {
mtmp = ERR_PTR(PTR_ERR(m->tagpool));
kfree(m);
return mtmp;
}

but I was wondering about one of the other returns further down the function:

...
memset(&m->poll_waddr, 0, sizeof(m->poll_waddr));
m->poll_task = NULL;
n = p9_mux_poll_start(m);
if (n)
return ERR_PTR(n);

n = trans->poll(trans, &m->pt);
...

lucho: doesn't that constitute a leak?  Shouldn't we be doing:

if (n) {
kfree(m);
return ERR_PTR(n);
}

 -eric


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH][RFC]: v9fs: moving non-VFS related interfaces to net/

[Latchesar Ionkov]

Hi,

It was suggested on lkml that we move the non-VFS layers of the 9P2000
protocol from fs/9p to net/9p making 9p usable for things other than
the VFS subsystem.

Can you please pull the patchset from
git://git.org/pub/scm/linux/kernel/git/ericvh/v9fs.git/ and review and
ack/reject it.

Thanks,
   Lucho
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html