Re: drivers/net/ax88796.c compile error on sh64
On Sun, Nov 11, 2007 at 10:06:21AM +0100, Adrian Bunk wrote: Commit 8687991a734a67f1638782c968f46fff0f94bb1f causes the following compile error on sh64: -- snip -- ... CC [M] drivers/net/ax88796.o /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/ax88796.c: In function 'ax_get_8390_hdr': /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/ax88796.c:187: error: implicit declaration of function 'readsw' /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/ax88796.c:189: error: implicit declaration of function 'readsb' /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/ax88796.c: In function 'ax_block_output': /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/ax88796.c:275: error: implicit declaration of function 'writesw' /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/ax88796.c:277: error: implicit declaration of function 'writesb' make[3]: *** [drivers/net/ax88796.o] Error 1 -- snip -- That's a pretty good argument for the PLAT_HAS_xxx stuff in the Kconfig space. We could have a if (CONFIG_SUPERH !CONFIG_SUPERH64) thing here, but there's probably not much point. I'm planning on merging them in the 2.6.25 time period anyways, so adding a stop-gap solution to hide this driver's visibility doesn't really seem like a worthwhile endeavour. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC] dependencies for platform drivers (was Re: ax88796: add superh to kconfig dependencies)
On Fri, Nov 09, 2007 at 09:26:52AM +, Ralf Baechle wrote: If writesb() is not an official API then maybe the answer should have been to either add that API to other architectures or fix the driver. I guess this incident means I need to go through all Kconfig* files to see what bogus architecture dependencies on MIPS or !MIPS exist ... While writesb() isn't an official API, the iowriteX_rep() interfaces theoretically are. Tidying up the driver for iomap is probably a better option. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: ax88796: add superh to kconfig dependencies
On Thu, Nov 08, 2007 at 04:31:05PM +0900, Magnus Damm wrote: ax88796: add superh to kconfig dependencies This patch adds sh architecture support to the ax88796 kconfig. Signed-off-by: Magnus Damm [EMAIL PROTECTED] --- This patch was posted about a month ago but never picked up: http://www.mail-archive.com/netdev@vger.kernel.org/msg50018.html The rest of the sh support is already included in rc1. Please apply. And as per: http://www.mail-archive.com/netdev@vger.kernel.org/msg50027.html Still-acked-by: Paul Mundt [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: ax88796: add superh to kconfig depencencies
On Tue, Oct 09, 2007 at 09:51:38PM +0900, Magnus Damm wrote: ax88796: add superh to kconfig depencencies This patch adds sh architecture support to the ax88796 kconfig. Signed-off-by: Magnus Damm [EMAIL PROTECTED] Acked-by: Paul Mundt [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] smc911x irq sense request and MPR2 board support
On Sat, Sep 29, 2007 at 01:24:47AM -0400, Jeff Garzik wrote: Markus Brunner wrote: this are the changes to the smc911x driver, which were necessary to get it running on the Magic Panel R2 (smsc9115). It is a SH3-DSP based board. The other patches are available on the linuxsh-dev mailinglist. http://marc.info/?l=linuxsh-devr=1b=200708w=2 It was necessary to set the irq sense to low level. Therefor the SMC_IRQ_SENSE define was added. How are the chances for inclusion in 2.6.24? Signed-off by: Markus Brunner [EMAIL PROTECTED] Signed-off by: Mark Jonas [EMAIL PROTECTED] does the SuperH maintainer ACK this? Yes, this looks fine. Acked-by: Paul Mundt [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] smc91x Hitachi Solution Engine (SuperH) Support
On Sat, Sep 29, 2007 at 01:29:25AM -0400, Jeff Garzik wrote: Nobuhiro Iwamatsu wrote: This patch supports Hitachi Solution Engine (SuperH) of smc91x. Please apply this patch . diff --git a/drivers/net/smc91x.h b/drivers/net/smc91x.h index 6ff3a16..af9e6bf 100644 --- a/drivers/net/smc91x.h +++ b/drivers/net/smc91x.h @@ -284,6 +284,7 @@ SMC_outw(u16 val, void __iomem *ioaddr, int reg) #elif defined(CONFIG_SUPERH) #ifdef CONFIG_SOLUTION_ENGINE +#define SMC_IRQ_FLAGS (0) #define SMC_CAN_USE_8BIT 0 #define SMC_CAN_USE_16BIT 1 #define SMC_CAN_USE_32BIT 0 Does the SuperH maintainer ACK this? Acked-by: Paul Mundt [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: sh: add support for ax88796 and 93cx6 to highlander boards
On Mon, Sep 10, 2007 at 03:36:26PM +0900, Magnus Damm wrote:
--- 0004/arch/sh/boards/renesas/r7780rp/setup.c
+++ work/arch/sh/boards/renesas/r7780rp/setup.c 2007-09-06
15:35:49.0 +0900
@@ -21,6 +21,7 @@
#include asm/clock.h
#include asm/heartbeat.h
#include asm/io.h
+#include net/ax88796.h
static struct resource r8a66597_usb_host_resources[] = {
[0] = {
@@ -136,11 +137,50 @@ static struct platform_device heartbeat_
.resource = heartbeat_resources,
};
+static struct ax_plat_data ax88796_platdata = {
+ .flags = AXFLG_HAS_93CX6,
+ .wordlength = 2,
+ .dcr_val= 0x1,
+ .rcr_val= 0x40,
+};
+
+static struct resource ax88796_resources[] = {
+ {
+#ifdef CONFIG_SH_R7780RP
+ .start = 0xa5800400,
+ .end= 0xa5800400 + (0x20 * 0x2) - 1,
+#else
+ .start = 0xa4100400,
+ .end= 0xa4100400 + (0x20 * 0x2) - 1,
+#endif
+ .flags = IORESOURCE_MEM,
+ },
+ {
+ .start = IRQ_AX88796,
+ .end= IRQ_AX88796,
+ .flags = IORESOURCE_IRQ,
+ },
+};
+
+static struct platform_device ax88796_device = {
+ .name = ax88796,
+ .id = 0,
+
+ .dev= {
+ .platform_data = ax88796_platdata,
+ },
+
+ .num_resources = ARRAY_SIZE(ax88796_resources),
+ .resource = ax88796_resources,
+};
+
+
static struct platform_device *r7780rp_devices[] __initdata = {
r8a66597_usb_host_device,
m66592_usb_peripheral_device,
cf_ide_device,
heartbeat_device,
+ ax88796_device,
};
static int __init r7780rp_devices_setup(void)
These bits I'll merge separately once the other patches have been
applied.
--- 0001/drivers/net/Kconfig
+++ work/drivers/net/Kconfig 2007-09-06 15:35:41.0 +0900
@@ -218,13 +218,20 @@ source drivers/net/arm/Kconfig
config AX88796
tristate ASIX AX88796 NE2000 clone support
- depends on ARM || MIPS
+ depends on ARM || MIPS || SUPERH
select CRC32
select MII
help
AX88796 driver, using platform bus to provide
chip detection and resources
+config AX88796_93CX6
+ bool ASIX AX88796 external 93CX6 eeprom support
+ depends on AX88796
+ select EEPROM_93CX6
+ help
+ Select this if your platform comes with an external 93CX6 eeprom.
+
config MACE
tristate MACE (Power Mac ethernet) support
depends on PPC_PMAC PPC32
There are two different changes here, these should probably be split up
and applied independently of each other, given that there's no real
dependency between them.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: drivers/infiniband/mlx/mad.c misplaced ;
On Wed, Aug 15, 2007 at 05:40:11PM -0700, Joe Perches wrote: $ egrep -r --include=*.c \bif[[:space:]]*\([^\)]*\)[[:space:]]*\; * arch/sh/boards/se/7343/io.c:if (0) ; drivers/atm/iphase.c: if (!desc1) ; drivers/infiniband/hw/mlx4/mad.c: if (!err); drivers/isdn/capi/capiutil.c: else if (c = 0x0f); drivers/net/tokenring/ibmtr.c: else if (ti-shared_ram_paging == 0xf); /* No paging in adapter */ drivers/s390/scsi/zfcp_erp.c: if (status == ZFCP_ERP_SUCCEEDED) ; /* no further action */ fs/hostfs/hostfs_user.c:if(attrs-ia_valid HOSTFS_ATTR_CTIME) ; net/netfilter/xt_u32.c: if (skb-len 4 || pos skb-len - 4); sound/pci/au88x0/au88x0_synth.c:if (eax == 0) ; On Thu, Aug 16, 2007 at 02:18:40PM +0100, Andy Whitcroft wrote: A couple of people suggested adding checks to checkpatch for trailing semicolons on conditionals, where the conditional block may not be actually conditional: if (err); return err; While regression testing the changes, I ran these checks across the whole of 2.6.23-rc3 and there appear to be 5 places where this is occurs (above and beyond the IPv6 one which triggered this effort) and a benign use which could be confused later which it seems safest to fix. Following this email are 6 patches for these issues, relevant maintainers cc'd. All against 2.6.23-rc3 It looks like you may want to refine your search parameters to match the above, as there are at least a few cases where the space exists. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 17/24] make atomic_read() behave consistently on sh64
On Thu, Aug 09, 2007 at 10:09:08AM -0400, Chris Snook wrote: Purify volatile use for atomic_t on sh64. Signed-off-by: Chris Snook [EMAIL PROTECTED] On Thu, Aug 09, 2007 at 10:10:34AM -0400, Chris Snook wrote: Purify volatile use for atomic_t on sh. Signed-off-by: Chris Snook [EMAIL PROTECTED] Acked-by: Paul Mundt [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 37/59] sysctl: C99 convert arch/sh64/kernel/traps.c and remove ABI breakage.
On Tue, Jan 16, 2007 at 09:39:42AM -0700, Eric W. Biederman wrote: From: Eric W. Biederman [EMAIL PROTECTED] - unquoted While doing the C99 conversion I notices that the top level sh64 directory was using the binary number for CTL_KERN. That is a no-no so I removed the support for the sysctl binary interface only leaving sysctl /proc support. At least the sysctl tables were placed at the end of the list so user space did not see this mistake. Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] Looks good, thanks Eric. Acked-by: Paul Mundt [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
