Re: [PATCH] airo: make debug-like messages printed by airo_print_dbg()
Hi,
I regret making a mistake yesterday, I forgot a comma.
Here now is the working patch.
[PATCH] airo: collapse debugging-messages in issuecommand to one line
Robert Schulze
--- linux-2.6.17.1/drivers/net/wireless/airo.c.orig 2006-07-08
14:02:12.0 +0200
+++ linux-2.6.17.1/drivers/net/wireless/airo.c 2006-07-10 18:30:30.0
+0200
@@ -3897,11 +3897,10 @@ static u16 issuecommand(struct airo_info
pRsp-rsp1 = IN4500(ai, RESP1);
pRsp-rsp2 = IN4500(ai, RESP2);
if ((pRsp-status 0xff00)!=0 pCmd-cmd != CMD_SOFTRESET) {
- airo_print_err(ai-dev-name, cmd= %x\n, pCmd-cmd);
- airo_print_err(ai-dev-name, status= %x\n, pRsp-status);
- airo_print_err(ai-dev-name, Rsp0= %x\n, pRsp-rsp0);
- airo_print_err(ai-dev-name, Rsp1= %x\n, pRsp-rsp1);
- airo_print_err(ai-dev-name, Rsp2= %x\n, pRsp-rsp2);
+ airo_print_err(ai-dev-name,
+ cmd:%x status:%x rsp0:%x rsp1:%x rsp2:%x,
+ pCmd-cmd, pRsp-status, pRsp-rsp0, pRsp-rsp1,
+ pRsp-rsp2);
}
// clear stuck command busy if necessary
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] airo: make debug-like messages printed by airo_print_dbg()
Hi, Dan Williams schrieb: This message will only happen if the card hangs up and stops responding to commands anyway, so we don't necessarily care about making the message decipherable to anyone other than developers. Well, I get this message each time I insert my Cisco Aironet 350 PCMCIA card, which works obviously fine. On card removal, I get: airo(eth1): cmd= 21 airo(eth1): status= airo(eth1): Rsp0= airo(eth1): Rsp1= airo(eth1): Rsp2= four(!) times. Besides, the messages can be read by issuing dmesg even after the patch, so no information gets lost. with kind regards, Robert Schulze - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] airo: make debug-like messages printed by airo_print_dbg()
Hi,
ok lets keep that message to be visible to anybody, but put it into one line.
Thanks for your comments.
Now, I will track down what causes the error on my machine, I think it has
something todo with pcmcia...
with kind regards,
Robert Schulze
--- linux-2.6.17.1/drivers/net/wireless/airo.c.orig 2006-07-08
14:02:12.0 +0200
+++ linux-2.6.17.1/drivers/net/wireless/airo.c 2006-07-10 00:19:15.0
+0200
@@ -3897,11 +3897,10 @@ static u16 issuecommand(struct airo_info
pRsp-rsp1 = IN4500(ai, RESP1);
pRsp-rsp2 = IN4500(ai, RESP2);
if ((pRsp-status 0xff00)!=0 pCmd-cmd != CMD_SOFTRESET) {
- airo_print_err(ai-dev-name, cmd= %x\n, pCmd-cmd);
- airo_print_err(ai-dev-name, status= %x\n, pRsp-status);
- airo_print_err(ai-dev-name, Rsp0= %x\n, pRsp-rsp0);
- airo_print_err(ai-dev-name, Rsp1= %x\n, pRsp-rsp1);
- airo_print_err(ai-dev-name, Rsp2= %x\n, pRsp-rsp2);
+ airo_print_err(ai-dev-name,
+ cmd:%x status:%x rsp0:%x rsp1:%x rsp2:%x
+ pCmd-cmd, pRsp-status, pRsp-rsp0, pRsp-rsp1,
+ pRsp-rsp2);
}
// clear stuck command busy if necessary
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: airo maybe should select crypto_aes
Hi, Herbert Xu schrieb: First of your patch is space-damaged. Please make sure that the original tabs are preserved and resend. Sorry for that, hope it fits this time. Also, wireless patches should be sent to this list with a cc to John W. Linville [EMAIL PROTECTED]. Didn't know that. With kind regards, Robert Schulze --- linux-2.6.17.1/drivers/net/wireless/Kconfig.orig 2006-07-03 17:37:02.0 +0200 +++ linux-2.6.17.1/drivers/net/wireless/Kconfig 2006-07-03 17:36:44.0 +0200 @@ -419,6 +419,7 @@ config AIRO_CS tristate Cisco/Aironet 34X/35X/4500/4800 PCMCIA cards depends on NET_RADIO PCMCIA (BROKEN || !M32R) select CRYPTO + select CRYPTO_AES ---help--- This is the standard Linux driver to support Cisco/Aironet PCMCIA 802.11 wireless cards. This driver is the same as the Aironet - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] airo: make debug-like messages printed by airo_print_dbg()
I don't think that messages like
airo(eth1): cmd= 111
airo(eth1): status= 7f11
airo(eth1): Rsp0= 2
airo(eth1): Rsp1= 0
airo(eth1): Rsp2= 0
are interesting to normal users, so switch them from airo_print_err() to
airo_print_dbg().
Furthermore, remove implicit linefeed in those messages, as they are handled by
airo_print().
with kind regards,
Robert Schulze
--- linux-2.6.17.1/drivers/net/wireless/airo.c.orig 2006-07-08
14:02:12.0 +0200
+++ linux-2.6.17.1/drivers/net/wireless/airo.c 2006-07-08 17:36:08.0
+0200
@@ -3897,11 +3897,11 @@ static u16 issuecommand(struct airo_info
pRsp-rsp1 = IN4500(ai, RESP1);
pRsp-rsp2 = IN4500(ai, RESP2);
if ((pRsp-status 0xff00)!=0 pCmd-cmd != CMD_SOFTRESET) {
- airo_print_err(ai-dev-name, cmd= %x\n, pCmd-cmd);
- airo_print_err(ai-dev-name, status= %x\n, pRsp-status);
- airo_print_err(ai-dev-name, Rsp0= %x\n, pRsp-rsp0);
- airo_print_err(ai-dev-name, Rsp1= %x\n, pRsp-rsp1);
- airo_print_err(ai-dev-name, Rsp2= %x\n, pRsp-rsp2);
+ airo_print_dbg(ai-dev-name, cmd= %x, pCmd-cmd);
+ airo_print_dbg(ai-dev-name, status= %x, pRsp-status);
+ airo_print_dbg(ai-dev-name, Rsp0= %x, pRsp-rsp0);
+ airo_print_dbg(ai-dev-name, Rsp1= %x, pRsp-rsp1);
+ airo_print_dbg(ai-dev-name, Rsp2= %x, pRsp-rsp2);
}
// clear stuck command busy if necessary
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
airo maybe should select crypto_aes
Hi, I first wrote to the linux-pcmcia ML, but they said it wasn't the right address for my issue. The driver airo (for Cisco Wlan-Cards) complains about failed to load transform for AES, when it is loaded and CRYPTO_AES is not selected in Kconfig. I've got a patch for that, maybe it's worth it. with kind regards, Robert Schulze --- linux-2.6.17.1/drivers/net/wireless/Kconfig.orig2006-07-03 17:37:02.0 +0200 +++ linux-2.6.17.1/drivers/net/wireless/Kconfig 2006-07-03 17:36:44.0 +0200 @@ -419,6 +419,7 @@ config AIRO_CS tristate Cisco/Aironet 34X/35X/4500/4800 PCMCIA cards depends on NET_RADIO PCMCIA (BROKEN || !M32R) select CRYPTO + select CRYPTO_AES ---help--- This is the standard Linux driver to support Cisco/Aironet PCMCIA 802.11 wireless cards. This driver is the same as the Aironet - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
