Re: [PATCH 3/3] NetXen: 64-bit memory fixes, driver cleanup
On Fri, 2006-11-17 at 08:40 -0800, Stephen Hemminger wrote: On Fri, 17 Nov 2006 07:36:03 -0800 Linsys Contractor Amit S. Kale [EMAIL PROTECTED] wrote: NetXen: 1G/10G Ethernet Driver updates - These fixes take care of driver on machines with 4G memory - Driver cleanup Signed-off-by: Amit S. Kale [EMAIL PROTECTED] netxen_nic.h | 41 ++ netxen_nic_ethtool.c | 19 ++-- netxen_nic_hw.c | 10 +- netxen_nic_hw.h |4 netxen_nic_init.c | 51 +++- netxen_nic_isr.c |3 netxen_nic_main.c | 204 +++--- netxen_nic_phan_reg.h | 10 +- 8 files changed, 293 insertions(+), 49 deletions(-) If you can't DMA from high memory, then don't set NETIF_F_HIGHDMA, why do you need explicit bounce buffers. If you can't DMA from unaligned address, the write a small routine to copy the skb to a new one. The hardware supports DMA into 35 bit addresses. The intent is to enable DMA into addresses upto 32G. Sanjeev. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2.6.17 2/9] NetXen: Hardware access routines
On Mon, 2006-08-21 at 07:03 -0700, Stephen Hemminger wrote: On Mon, 21 Aug 2006 13:57:23 +0530 Amit S. Kale [EMAIL PROTECTED] wrote: We can certainly create a table for all error messages. It'll hurt readability of code in many of the other places where printks are used to indicate some hardware error. -Amit My suggestion was intended as an way to handle multiple driver versions all using the same firmware or vice versa. By locking the firmware and driver version together you might make maintenance more difficult. We misunderstood your earlier comment. The compatible driver firmware images have the same major minor version numbers. Only the sub-version numbers may be different. This gives us more flexibility in releasing driver firmware fixes. Sanjeev. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/9] NetXen 1G/10G driver
On Wed, 2006-04-05 at 10:32 -0700, Stephen Hemminger wrote: On Wed, 05 Apr 2006 10:31:14 -0700 Sanjeev Jorapur [EMAIL PROTECTED] wrote: On Wed, 2006-04-05 at 10:13 -0700, Stephen Hemminger wrote: On Wed, 05 Apr 2006 09:38:24 -0700 Bryan O'Sullivan [EMAIL PROTECTED] wrote: On Sat, 2006-04-01 at 05:14 -0800, Linsys Contractor Amit S. Kale wrote: We would like this driver to be inluded in mainline kernel. Kindly review it and feel free to get back to me for any feedback/queries/comments. Based on some light reading and my own recent experience, I'd estimate that you have about three months of work ahead of you before this will be suitable for merging. The code is a big mess as it stands. Also, next time you submit patches, please make life easier by including a description in each patch of what's included, keep the patches below 2500 lines long, and don't go back and randomly add bits and pieces afterwards. Or for a new driver, just make it one big piece and put it at a website for download and include linke. Thanks to everyone for your comments. We will incorporate the feedback and repost the driver. The last time we posted our driver, it was on a website with a link to download. We got just one comment back. So, this time, we decided to inline the patches. Sanjeev. Inline is better, but looking at pieces is also annoying, so do both. Sure, will do that. Sanjeev. -- Sanjeev Jorapur - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
