Re: [2.6.25 patch] fix broken error handling in ieee80211_sta_process_addba_request()

2008-02-20 Thread Tomas Winkler
On Feb 20, 2008 8:46 AM, Jarek Poplawski [EMAIL PROTECTED] wrote:
 On 19-02-2008 23:58, Adrian Bunk wrote:
 ...
  --- a/net/mac80211/ieee80211_sta.c
  +++ b/net/mac80211/ieee80211_sta.c
  @@ -1116,9 +1116,10 @@ static void 
  ieee80211_sta_process_addba_request(struct net_device *dev,
 ...
  + printk(KERN_ERR can not allocate reordering buffer 

   + printk(KERN_ERR cannot allocate reordering buffer 

 Probably this can be fixed during the commit.

 Jarek P
.
ACK: both patches.
 --
 To unsubscribe from this list: send the line unsubscribe netdev in
 the body of a message to [EMAIL PROTECTED]
 More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: handing cloned frames to netif_rx()?

2008-01-11 Thread Tomas Winkler
On Jan 11, 2008 3:17 AM, Johannes Berg [EMAIL PROTECTED] wrote:
 In 802.11n, there is a case where multiple data frames are received
 aggregated into a single frame (A-MSDU).

 Currently, we copy each of these frames out into their own skb, but
 because of the alignment with that etc. I started to think that we could
 simply pass up a clone of the original skb with start/length adjusted
 properly so that it windows only the contained packet.

 The buffer would be shared but the data within the original window
 (starting with the 802.3 header) could even be written to, it won't be
 needed again by mac80211 once it's handed off to netif_rx(). The skb
 will obviously have lots of head- and tailroom but that space would be
 part of other packets.

 Is it ok to do this? Will something freak out if we pass a cloned skb to
 netif_rx()?

This would be great even in regular case. 4965 has ability to deliver
more frames per receiving buffer
Because of A-MSDU we keeps 8K receiving buffers which are
underutilized when A-MSDU is not used.

 johannes

--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] NET: Multiqueue network device support.

2007-06-11 Thread Tomas Winkler

On 6/11/07, jamal [EMAIL PROTECTED] wrote:

On Mon, 2007-11-06 at 17:30 +0300, Cohen, Guy wrote:


 For WiFi devices the HW often implements the scheduling, especially when
 QoS (WMM/11e/11n) is implemented. There are few traffic queues defined
 by the specs and the selection of the next queue to transmit a packet
 from, is determined in real time, just when there is a tx opportunity.
 This cannot be predicted in advance since it depends on the medium usage
 of other stations.

WMM is a strict prio mechanism.
The parametrization very much favors the high prio packets when the
tx opportunity to send shows up.



This is not true, there is no simple priority order from 1 to 4 ,
rather set of parameters that dermises access to medium.  You have to
emulate medium behavior to schedule packets in correct order. That's
why this pushed to HW, otherwise nobody would invest money in this
part of silicon :)


 Hence, to make it possible for wireless devices to use the qdisc
 mechanism properly, the HW queues should _ALL_ be non-empty at all
 times, whenever data is available in the upper layers.

agreed.

 Or in other
 words, the upper layers should not block a specific queue because of the
 usage of any other queue.

This is where we are going to disagree.
There is no way the stack will send the driver packets which are low
prio if there are some which are high prio. There is therefore, on
contention between low and high prio, no way for low prio packets to
obstruct the high prio packets; however, it is feasible that high prio
packets will obstruct low prio packets (which is fine).

cheers,
jamal

-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


dscape git

2006-07-17 Thread Tomas Winkler
I've tried to clone dscape git and I got the error
bellow. I hade no problem go get other trees. I'm new
to git so maybe I didn't use correct switches
Command Line: git clone
http://www.kernel.org/pub/scm/linux/kernel/git/jbenc/dscap
e.git/ dscape
Thanks for help

got 0cdcef84239e5f1d60310883688b7aeca5278875
error: The requested file was not found (curl_result =
22, http_code = 503, sha1
 = 27fd37621255799602d74e94d670ff7a1658d40a)
Getting pack list for
http://www.kernel.org/pub/scm/linux/kernel/git/jbenc/dscap
e.git/
got 80f18b79eacc07319afe473023a5358cfbc11ae6
Getting pack list for http://www.kernel.or
error: The requested file was not found
error: Unable to find
27fd37621255799602d74e94d670ff7a1658d40a under
http://www.
kernel.org/pub/scm/linux/kernel/git/jbenc/dscape.git/
Cannot obtain needed blob
27fd37621255799602d74e94d670ff7a1658d40a
while processing commit a495f8ec7590d6df5edc36bff419f25b8c3440de.

__
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: dscape git

2006-07-17 Thread Tomas Winkler
First I'm behind the firewall second other gits worked
just fine.
Thanks

--- Erik Mouw [EMAIL PROTECTED] wrote:

 On Mon, Jul 17, 2006 at 07:15:03AM -0700, Tomas
 Winkler wrote:
  I've tried to clone dscape git and I got the error
  bellow. I hade no problem go get other trees. I'm
 new
  to git so maybe I didn't use correct switches
  Command Line: git clone
 

http://www.kernel.org/pub/scm/linux/kernel/git/jbenc/dscap
  e.git/ dscape
 
 When available, use the git protocol. It's both
 faster and more
 efficient.
 
  Thanks for help
  
  got 0cdcef84239e5f1d60310883688b7aeca5278875
  error: The requested file was not found
 (curl_result =
  22, http_code = 503, sha1
   = 27fd37621255799602d74e94d670ff7a1658d40a)
  Getting pack list for
 

http://www.kernel.org/pub/scm/linux/kernel/git/jbenc/dscap
  e.git/
  got 80f18b79eacc07319afe473023a5358cfbc11ae6
  Getting pack list for http://www.kernel.or
  error: The requested file was not found
  error: Unable to find
  27fd37621255799602d74e94d670ff7a1658d40a under
  http://www.
 

kernel.org/pub/scm/linux/kernel/git/jbenc/dscape.git/
  Cannot obtain needed blob
  27fd37621255799602d74e94d670ff7a1658d40a
  while processing commit
 a495f8ec7590d6df5edc36bff419f25b8c3440de.
 
 Could be that www.kernel.org didn't yet fully sync
 up with
 master.kernel.org. Just wait, it usually gets
 corrected in half an
 hour.
 
 I just succesfully clone'd dscape with the following
 command line:
 
 git clone --reference linux-2.6 \
  

git://git.kernel.org/pub/scm/linux/kernel/git/jbenc/dscape.git
 dscape
 
 The --reference parameter tells git that I have a
 local repository
 called linux-2.6 (which just follow Linus' 2.6
 tree) which can be
 used to pull the shared git objects from. Saves
 quite some disk space.
 
 
 Erik
 
 -- 
 +-- Erik Mouw -- www.harddisk-recovery.com -- +31 70
 370 12 90 --
 | Lab address: Delftechpark 26, 2628 XH, Delft, The
 Netherlands
 -
 To unsubscribe from this list: send the line
 unsubscribe netdev in
 the body of a message to [EMAIL PROTECTED]
 More majordomo info at 
 http://vger.kernel.org/majordomo-info.html
 


__
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: dscape git

2006-07-17 Thread Tomas Winkler
Hmm, I've missed the second part of you email. 
The solution you've suggested has worked. 
Thanks
Anyhow if this is a problem of sync then it last for 2
days already.
Thanks a lot


--- Tomas Winkler [EMAIL PROTECTED] wrote:

 First I'm behind the firewall second other gits
 worked
 just fine.
 Thanks
 
 --- Erik Mouw [EMAIL PROTECTED] wrote:
 
  On Mon, Jul 17, 2006 at 07:15:03AM -0700, Tomas
  Winkler wrote:
   I've tried to clone dscape git and I got the
 error
   bellow. I hade no problem go get other trees.
 I'm
  new
   to git so maybe I didn't use correct switches
   Command Line: git clone
  
 

http://www.kernel.org/pub/scm/linux/kernel/git/jbenc/dscap
   e.git/ dscape
  
  When available, use the git protocol. It's both
  faster and more
  efficient.
  
   Thanks for help
   
   got 0cdcef84239e5f1d60310883688b7aeca5278875
   error: The requested file was not found
  (curl_result =
   22, http_code = 503, sha1
= 27fd37621255799602d74e94d670ff7a1658d40a)
   Getting pack list for
  
 

http://www.kernel.org/pub/scm/linux/kernel/git/jbenc/dscap
   e.git/
   got 80f18b79eacc07319afe473023a5358cfbc11ae6
   Getting pack list for http://www.kernel.or
   error: The requested file was not found
   error: Unable to find
   27fd37621255799602d74e94d670ff7a1658d40a under
   http://www.
  
 

kernel.org/pub/scm/linux/kernel/git/jbenc/dscape.git/
   Cannot obtain needed blob
   27fd37621255799602d74e94d670ff7a1658d40a
   while processing commit
  a495f8ec7590d6df5edc36bff419f25b8c3440de.
  
  Could be that www.kernel.org didn't yet fully sync
  up with
  master.kernel.org. Just wait, it usually gets
  corrected in half an
  hour.
  
  I just succesfully clone'd dscape with the
 following
  command line:
  
  git clone --reference linux-2.6 \
   
 

git://git.kernel.org/pub/scm/linux/kernel/git/jbenc/dscape.git
  dscape
  
  The --reference parameter tells git that I have
 a
  local repository
  called linux-2.6 (which just follow Linus' 2.6
  tree) which can be
  used to pull the shared git objects from. Saves
  quite some disk space.
  
  
  Erik
  
  -- 
  +-- Erik Mouw -- www.harddisk-recovery.com -- +31
 70
  370 12 90 --
  | Lab address: Delftechpark 26, 2628 XH, Delft,
 The
  Netherlands
  -
  To unsubscribe from this list: send the line
  unsubscribe netdev in
  the body of a message to [EMAIL PROTECTED]
  More majordomo info at 
  http://vger.kernel.org/majordomo-info.html
  
 
 
 __
 Do You Yahoo!?
 Tired of spam?  Yahoo! Mail has the best spam
 protection around 
 http://mail.yahoo.com 
 -
 To unsubscribe from this list: send the line
 unsubscribe netdev in
 the body of a message to [EMAIL PROTECTED]
 More majordomo info at 
 http://vger.kernel.org/majordomo-info.html
 


__
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html