Re: [PATCH] cfg80211/nl80211: add wifi tx power mode switching support
Hi Johannes, Thanks for the reply. You are right that the physical antenna does not change. When I refer to 'calibration data', it actually corresponding to how mwifiex adjust the per-band tx power. For mwifiex, the per-band tx power is pre-calculated based on need, and stored in DT, a vendor command or std nl80211 message is sent to tell the driver to switch between two set of "calibration data". I'm aware that iwl7000 is using a vendor command to do this as well, but instead of pre-calculate required tx power info, the tx value can be passed along with the vendor command message. This patch was sent originally to standardize the requirement of sending a vendor command to the driver (so it'll be a standard nl80211 message). However, we have decided to move along with vendor command for both mwifiex and nl80211, so this patch is not needed anymore. Thanks for the comments! Wei-Ning On Tue, Jun 28, 2016 at 6:57 PM, Johannes Berg wrote: > On Thu, 2016-05-12 at 17:34 +0800, Wei-Ning Huang wrote: >> >> Johannes, I feel like being able to set calibration data at runtime >> is something common to all wireless drivers, so instead of using >> vendor commands what do you think if I pass the calibration data name >> instead of using those magic constants? This way, userspace does not >> need to know the details of what band/range power limit the driver >> supports. It allows for flexible driver side implementation and >> easier for userspace to control. >> > > Sorry - I dropped this thread accidentally. > > I'm not really sure I understand the situation fully, but right now to > me this seems very strange. > > The physical antennas probably don't really change between "clamshell" > and "tablet" mode, do the physical radiation properties change enough > to actually require different *calibration*? To me, that sounds very > strange. > > Assuming they don't really change fundamentally, then I understand the > need to set different power levels, per band/channel/whatever > granularity. But that can be achieved in very different ways, and in > fact if you look at Chrome then for our iwl7000 driver there we do have > a command to do something similar (currently a vendor command, but that > can be changed) without ever changing the *calibration*. > > So to me, the whole premise of the patch is confusing and/or wrong. > > johannes -- Wei-Ning Huang, 黃偉寧 | Software Engineer, Google Inc., Taiwan | wnhu...@google.com | Cell: +886 910-380678
Re: [PATCH] cfg80211/nl80211: add wifi tx power mode switching support
On Fri, May 13, 2016 at 6:02 AM, Arend van Spriel
wrote:
> On 12-05-16 11:34, Wei-Ning Huang wrote:
>> On Thu, May 12, 2016 at 2:33 AM, Dan Williams wrote:
>>> On Wed, 2016-05-11 at 13:03 +0800, Wei-Ning Huang wrote:
>>>> On Fri, May 6, 2016 at 4:19 PM, Wei-Ning Huang
>>>> wrote:
>>>>>
>>>>> On Fri, May 6, 2016 at 12:07 AM, Dan Williams
>>>>> wrote:
>>>>>>
>>>>>>
>>>>>> On Thu, 2016-05-05 at 14:44 +0800, Wei-Ning Huang wrote:
>>>>>>>
>>>>>>> Recent new hardware has the ability to switch between tablet
>>>>>>> mode and
>>>>>>> clamshell mode. To optimize WiFi performance, we want to be
>>>>>>> able to
>>>>>>> use
>>>>>>> different power table between modes. This patch adds a new
>>>>>>> netlink
>>>>>>> message type and cfg80211_ops function to allow userspace to
>>>>>>> trigger
>>>>>>> a
>>>>>>> power mode switch for a given wireless interface.
>>>>>>>
>>>>>>> Signed-off-by: Wei-Ning Huang
>>>>>>> ---
>>>>>>> include/net/cfg80211.h | 11 +++
>>>>>>> include/uapi/linux/nl80211.h | 21 +
>>>>>>> net/wireless/nl80211.c | 16
>>>>>>> net/wireless/rdev-ops.h | 22 ++
>>>>>>> net/wireless/trace.h | 20
>>>>>>> 5 files changed, 90 insertions(+)
>>>>>>>
>>>>>>> diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
>>>>>>> index 9e1b24c..aa77fa0 100644
>>>>>>> --- a/include/net/cfg80211.h
>>>>>>> +++ b/include/net/cfg80211.h
>>>>>>> @@ -2370,6 +2370,12 @@ struct cfg80211_qos_map {
>>>>>>> * @get_tx_power: store the current TX power into the dbm
>>>>>>> variable;
>>>>>>> * return 0 if successful
>>>>>>> *
>>>>>>> + * @set_tx_power_mode: set the transmit power mode. Some
>>>>>>> device have
>>>>>>> the ability
>>>>>>> + * to transform between different mode such as clamshell and
>>>>>>> tablet mode.
>>>>>>> + * set_tx_power_mode allows setting of different TX power
>>>>>>> mode at runtime.
>>>>>>> + * @get_tx_power_mode: store the current TX power mode into
>>>>>>> the mode
>>>>>>> variable;
>>>>>>> + * return 0 if successful
>>>>>>> + *
>>>>>>> * @set_wds_peer: set the WDS peer for a WDS interface
>>>>>>> *
>>>>>>> * @rfkill_poll: polls the hw rfkill line, use cfg80211
>>>>>>> reporting
>>>>>>> @@ -2631,6 +2637,11 @@ struct cfg80211_ops {
>>>>>>> int (*get_tx_power)(struct wiphy *wiphy, struct
>>>>>>> wireless_dev *wdev,
>>>>>>> int *dbm);
>>>>>>>
>>>>>>> + int (*set_tx_power_mode)(struct wiphy *wiphy,
>>>>>>> + enum nl80211_tx_power_mode
>>>>>>> mode);
>>>>>>> + int (*get_tx_power_mode)(struct wiphy *wiphy,
>>>>>>> + enum nl80211_tx_power_mode
>>>>>>> *mode);
>>>>>>> +
>>>>>>> int (*set_wds_peer)(struct wiphy *wiphy, struct
>>>>>>> net_device *dev,
>>>>>>> const u8 *addr);
>>>>>>>
>>>>>>> diff --git a/include/uapi/linux/nl80211.h
>>>>>>> b/include/uapi/linux/nl80211.h
>>>>>>> index 5a30a75..9b1888a 100644
>>>>>>> --- a/include/uapi/linux/nl80211.h
>>>>>>> +++ b/include/uapi/linux/nl80211.h
>>>>>>> @@ -1796,6 +1796,9 @@ enum nl80211_commands {
>>>>>>> * connecting to a PCP, and in %NL80211_CMD_START_AP to
>>>>>>> start
>>>>>>> * a PCP instead of AP. Relevant for DMG networks only
Re: [PATCH] cfg80211/nl80211: add wifi tx power mode switching support
On Thu, May 12, 2016 at 2:33 AM, Dan Williams wrote:
> On Wed, 2016-05-11 at 13:03 +0800, Wei-Ning Huang wrote:
>> On Fri, May 6, 2016 at 4:19 PM, Wei-Ning Huang
>> wrote:
>> >
>> > On Fri, May 6, 2016 at 12:07 AM, Dan Williams
>> > wrote:
>> > >
>> > >
>> > > On Thu, 2016-05-05 at 14:44 +0800, Wei-Ning Huang wrote:
>> > > >
>> > > > Recent new hardware has the ability to switch between tablet
>> > > > mode and
>> > > > clamshell mode. To optimize WiFi performance, we want to be
>> > > > able to
>> > > > use
>> > > > different power table between modes. This patch adds a new
>> > > > netlink
>> > > > message type and cfg80211_ops function to allow userspace to
>> > > > trigger
>> > > > a
>> > > > power mode switch for a given wireless interface.
>> > > >
>> > > > Signed-off-by: Wei-Ning Huang
>> > > > ---
>> > > > include/net/cfg80211.h | 11 +++
>> > > > include/uapi/linux/nl80211.h | 21 +
>> > > > net/wireless/nl80211.c | 16
>> > > > net/wireless/rdev-ops.h | 22 ++
>> > > > net/wireless/trace.h | 20
>> > > > 5 files changed, 90 insertions(+)
>> > > >
>> > > > diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
>> > > > index 9e1b24c..aa77fa0 100644
>> > > > --- a/include/net/cfg80211.h
>> > > > +++ b/include/net/cfg80211.h
>> > > > @@ -2370,6 +2370,12 @@ struct cfg80211_qos_map {
>> > > > * @get_tx_power: store the current TX power into the dbm
>> > > > variable;
>> > > > * return 0 if successful
>> > > > *
>> > > > + * @set_tx_power_mode: set the transmit power mode. Some
>> > > > device have
>> > > > the ability
>> > > > + * to transform between different mode such as clamshell and
>> > > > tablet mode.
>> > > > + * set_tx_power_mode allows setting of different TX power
>> > > > mode at runtime.
>> > > > + * @get_tx_power_mode: store the current TX power mode into
>> > > > the mode
>> > > > variable;
>> > > > + * return 0 if successful
>> > > > + *
>> > > > * @set_wds_peer: set the WDS peer for a WDS interface
>> > > > *
>> > > > * @rfkill_poll: polls the hw rfkill line, use cfg80211
>> > > > reporting
>> > > > @@ -2631,6 +2637,11 @@ struct cfg80211_ops {
>> > > > int (*get_tx_power)(struct wiphy *wiphy, struct
>> > > > wireless_dev *wdev,
>> > > > int *dbm);
>> > > >
>> > > > + int (*set_tx_power_mode)(struct wiphy *wiphy,
>> > > > + enum nl80211_tx_power_mode
>> > > > mode);
>> > > > + int (*get_tx_power_mode)(struct wiphy *wiphy,
>> > > > + enum nl80211_tx_power_mode
>> > > > *mode);
>> > > > +
>> > > > int (*set_wds_peer)(struct wiphy *wiphy, struct
>> > > > net_device *dev,
>> > > > const u8 *addr);
>> > > >
>> > > > diff --git a/include/uapi/linux/nl80211.h
>> > > > b/include/uapi/linux/nl80211.h
>> > > > index 5a30a75..9b1888a 100644
>> > > > --- a/include/uapi/linux/nl80211.h
>> > > > +++ b/include/uapi/linux/nl80211.h
>> > > > @@ -1796,6 +1796,9 @@ enum nl80211_commands {
>> > > > * connecting to a PCP, and in %NL80211_CMD_START_AP to
>> > > > start
>> > > > * a PCP instead of AP. Relevant for DMG networks only.
>> > > > *
>> > > > + * @NL80211_ATTR_WIPHY_TX_POWER_MODE: Transmit power mode. See
>> > > > + * &enum nl80211_tx_power_mode for possible values.
>> > > > + *
>> > > > * @NUM_NL80211_ATTR: total number of nl80211_attrs available
>> > > > * @NL80211_ATTR_MAX: highest attribute number currently
>> > > > defined
>> > > > * @__NL80211_ATTR_AFTER_LAST: internal use
>> > > > @@ -2172,6 +2175,8
Re: [PATCH] cfg80211/nl80211: add wifi tx power mode switching support
On Fri, May 6, 2016 at 4:19 PM, Wei-Ning Huang wrote:
> On Fri, May 6, 2016 at 12:07 AM, Dan Williams wrote:
>>
>> On Thu, 2016-05-05 at 14:44 +0800, Wei-Ning Huang wrote:
>> > Recent new hardware has the ability to switch between tablet mode and
>> > clamshell mode. To optimize WiFi performance, we want to be able to
>> > use
>> > different power table between modes. This patch adds a new netlink
>> > message type and cfg80211_ops function to allow userspace to trigger
>> > a
>> > power mode switch for a given wireless interface.
>> >
>> > Signed-off-by: Wei-Ning Huang
>> > ---
>> > include/net/cfg80211.h | 11 +++
>> > include/uapi/linux/nl80211.h | 21 +
>> > net/wireless/nl80211.c | 16
>> > net/wireless/rdev-ops.h | 22 ++
>> > net/wireless/trace.h | 20
>> > 5 files changed, 90 insertions(+)
>> >
>> > diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
>> > index 9e1b24c..aa77fa0 100644
>> > --- a/include/net/cfg80211.h
>> > +++ b/include/net/cfg80211.h
>> > @@ -2370,6 +2370,12 @@ struct cfg80211_qos_map {
>> > * @get_tx_power: store the current TX power into the dbm variable;
>> > * return 0 if successful
>> > *
>> > + * @set_tx_power_mode: set the transmit power mode. Some device have
>> > the ability
>> > + * to transform between different mode such as clamshell and
>> > tablet mode.
>> > + * set_tx_power_mode allows setting of different TX power
>> > mode at runtime.
>> > + * @get_tx_power_mode: store the current TX power mode into the mode
>> > variable;
>> > + * return 0 if successful
>> > + *
>> > * @set_wds_peer: set the WDS peer for a WDS interface
>> > *
>> > * @rfkill_poll: polls the hw rfkill line, use cfg80211 reporting
>> > @@ -2631,6 +2637,11 @@ struct cfg80211_ops {
>> > int (*get_tx_power)(struct wiphy *wiphy, struct
>> > wireless_dev *wdev,
>> > int *dbm);
>> >
>> > + int (*set_tx_power_mode)(struct wiphy *wiphy,
>> > + enum nl80211_tx_power_mode
>> > mode);
>> > + int (*get_tx_power_mode)(struct wiphy *wiphy,
>> > + enum nl80211_tx_power_mode
>> > *mode);
>> > +
>> > int (*set_wds_peer)(struct wiphy *wiphy, struct
>> > net_device *dev,
>> > const u8 *addr);
>> >
>> > diff --git a/include/uapi/linux/nl80211.h
>> > b/include/uapi/linux/nl80211.h
>> > index 5a30a75..9b1888a 100644
>> > --- a/include/uapi/linux/nl80211.h
>> > +++ b/include/uapi/linux/nl80211.h
>> > @@ -1796,6 +1796,9 @@ enum nl80211_commands {
>> > * connecting to a PCP, and in %NL80211_CMD_START_AP to start
>> > * a PCP instead of AP. Relevant for DMG networks only.
>> > *
>> > + * @NL80211_ATTR_WIPHY_TX_POWER_MODE: Transmit power mode. See
>> > + * &enum nl80211_tx_power_mode for possible values.
>> > + *
>> > * @NUM_NL80211_ATTR: total number of nl80211_attrs available
>> > * @NL80211_ATTR_MAX: highest attribute number currently defined
>> > * @__NL80211_ATTR_AFTER_LAST: internal use
>> > @@ -2172,6 +2175,8 @@ enum nl80211_attrs {
>> >
>> > NL80211_ATTR_PBSS,
>> >
>> > + NL80211_ATTR_WIPHY_TX_POWER_MODE,
>> > +
>> > /* add attributes here, update the policy in nl80211.c */
>> >
>> > __NL80211_ATTR_AFTER_LAST,
>> > @@ -3703,6 +3708,22 @@ enum nl80211_tx_power_setting {
>> > };
>> >
>> > /**
>> > + * enum nl80211_tx_power_mode - TX power mode setting
>> > + * @NL80211_TX_POWER_LOW: general low TX power mode
>> > + * @NL80211_TX_POWER_MEDIUM: general medium TX power mode
>> > + * @NL80211_TX_POWER_HIGH: general high TX power mode
>> > + * @NL80211_TX_POWER_CLAMSHELL: clamshell mode TX power mode
>> > + * @NL80211_TX_POWER_TABLET: tablet mode TX power mode
>> > + */
>> > +enum nl80211_tx_power_mode {
>> > + NL80211_TX_POWER_LOW,
>> > + NL80211_TX_POWER_MEDIUM,
>> > + NL80211_TX_POWER_HIGH,
>> > + NL80211_TX_POWER_CLAMSHELL,
>> > + NL80211_TX_POWER_TABLET,
>>
>
>> "clamshell
Re: [PATCH] cfg80211/nl80211: add wifi tx power mode switching support
On Fri, May 6, 2016 at 12:07 AM, Dan Williams wrote:
>
> On Thu, 2016-05-05 at 14:44 +0800, Wei-Ning Huang wrote:
> > Recent new hardware has the ability to switch between tablet mode and
> > clamshell mode. To optimize WiFi performance, we want to be able to
> > use
> > different power table between modes. This patch adds a new netlink
> > message type and cfg80211_ops function to allow userspace to trigger
> > a
> > power mode switch for a given wireless interface.
> >
> > Signed-off-by: Wei-Ning Huang
> > ---
> > include/net/cfg80211.h | 11 +++
> > include/uapi/linux/nl80211.h | 21 +
> > net/wireless/nl80211.c | 16
> > net/wireless/rdev-ops.h | 22 ++
> > net/wireless/trace.h | 20
> > 5 files changed, 90 insertions(+)
> >
> > diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
> > index 9e1b24c..aa77fa0 100644
> > --- a/include/net/cfg80211.h
> > +++ b/include/net/cfg80211.h
> > @@ -2370,6 +2370,12 @@ struct cfg80211_qos_map {
> > * @get_tx_power: store the current TX power into the dbm variable;
> > * return 0 if successful
> > *
> > + * @set_tx_power_mode: set the transmit power mode. Some device have
> > the ability
> > + * to transform between different mode such as clamshell and
> > tablet mode.
> > + * set_tx_power_mode allows setting of different TX power
> > mode at runtime.
> > + * @get_tx_power_mode: store the current TX power mode into the mode
> > variable;
> > + * return 0 if successful
> > + *
> > * @set_wds_peer: set the WDS peer for a WDS interface
> > *
> > * @rfkill_poll: polls the hw rfkill line, use cfg80211 reporting
> > @@ -2631,6 +2637,11 @@ struct cfg80211_ops {
> > int (*get_tx_power)(struct wiphy *wiphy, struct
> > wireless_dev *wdev,
> > int *dbm);
> >
> > + int (*set_tx_power_mode)(struct wiphy *wiphy,
> > + enum nl80211_tx_power_mode
> > mode);
> > + int (*get_tx_power_mode)(struct wiphy *wiphy,
> > + enum nl80211_tx_power_mode
> > *mode);
> > +
> > int (*set_wds_peer)(struct wiphy *wiphy, struct
> > net_device *dev,
> > const u8 *addr);
> >
> > diff --git a/include/uapi/linux/nl80211.h
> > b/include/uapi/linux/nl80211.h
> > index 5a30a75..9b1888a 100644
> > --- a/include/uapi/linux/nl80211.h
> > +++ b/include/uapi/linux/nl80211.h
> > @@ -1796,6 +1796,9 @@ enum nl80211_commands {
> > * connecting to a PCP, and in %NL80211_CMD_START_AP to start
> > * a PCP instead of AP. Relevant for DMG networks only.
> > *
> > + * @NL80211_ATTR_WIPHY_TX_POWER_MODE: Transmit power mode. See
> > + * &enum nl80211_tx_power_mode for possible values.
> > + *
> > * @NUM_NL80211_ATTR: total number of nl80211_attrs available
> > * @NL80211_ATTR_MAX: highest attribute number currently defined
> > * @__NL80211_ATTR_AFTER_LAST: internal use
> > @@ -2172,6 +2175,8 @@ enum nl80211_attrs {
> >
> > NL80211_ATTR_PBSS,
> >
> > + NL80211_ATTR_WIPHY_TX_POWER_MODE,
> > +
> > /* add attributes here, update the policy in nl80211.c */
> >
> > __NL80211_ATTR_AFTER_LAST,
> > @@ -3703,6 +3708,22 @@ enum nl80211_tx_power_setting {
> > };
> >
> > /**
> > + * enum nl80211_tx_power_mode - TX power mode setting
> > + * @NL80211_TX_POWER_LOW: general low TX power mode
> > + * @NL80211_TX_POWER_MEDIUM: general medium TX power mode
> > + * @NL80211_TX_POWER_HIGH: general high TX power mode
> > + * @NL80211_TX_POWER_CLAMSHELL: clamshell mode TX power mode
> > + * @NL80211_TX_POWER_TABLET: tablet mode TX power mode
> > + */
> > +enum nl80211_tx_power_mode {
> > + NL80211_TX_POWER_LOW,
> > + NL80211_TX_POWER_MEDIUM,
> > + NL80211_TX_POWER_HIGH,
> > + NL80211_TX_POWER_CLAMSHELL,
> > + NL80211_TX_POWER_TABLET,
>
> "clamshell" and "tablet" probably mean many different things to many
> different people with respect to whether or not they should do anything
> with power saving or wifi. I feel like a more generic interface is
> needed here.
We could probably drop those two CLAMSHELL and TABLET constant or
describing what they mean
in more detail?
>
> Could this be already done by:
> @NL80211_ATTR_WIPHY_TX_POWER_SETTING = NL80211_TX_POWER_LIMITED
>
[PATCH] cfg80211/nl80211: add wifi tx power mode switching support
Recent new hardware has the ability to switch between tablet mode and
clamshell mode. To optimize WiFi performance, we want to be able to use
different power table between modes. This patch adds a new netlink
message type and cfg80211_ops function to allow userspace to trigger a
power mode switch for a given wireless interface.
Signed-off-by: Wei-Ning Huang
---
include/net/cfg80211.h | 11 +++
include/uapi/linux/nl80211.h | 21 +
net/wireless/nl80211.c | 16
net/wireless/rdev-ops.h | 22 ++
net/wireless/trace.h | 20
5 files changed, 90 insertions(+)
diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
index 9e1b24c..aa77fa0 100644
--- a/include/net/cfg80211.h
+++ b/include/net/cfg80211.h
@@ -2370,6 +2370,12 @@ struct cfg80211_qos_map {
* @get_tx_power: store the current TX power into the dbm variable;
* return 0 if successful
*
+ * @set_tx_power_mode: set the transmit power mode. Some device have the
ability
+ * to transform between different mode such as clamshell and tablet mode.
+ * set_tx_power_mode allows setting of different TX power mode at runtime.
+ * @get_tx_power_mode: store the current TX power mode into the mode variable;
+ * return 0 if successful
+ *
* @set_wds_peer: set the WDS peer for a WDS interface
*
* @rfkill_poll: polls the hw rfkill line, use cfg80211 reporting
@@ -2631,6 +2637,11 @@ struct cfg80211_ops {
int (*get_tx_power)(struct wiphy *wiphy, struct wireless_dev *wdev,
int *dbm);
+ int (*set_tx_power_mode)(struct wiphy *wiphy,
+enum nl80211_tx_power_mode mode);
+ int (*get_tx_power_mode)(struct wiphy *wiphy,
+enum nl80211_tx_power_mode *mode);
+
int (*set_wds_peer)(struct wiphy *wiphy, struct net_device *dev,
const u8 *addr);
diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h
index 5a30a75..9b1888a 100644
--- a/include/uapi/linux/nl80211.h
+++ b/include/uapi/linux/nl80211.h
@@ -1796,6 +1796,9 @@ enum nl80211_commands {
* connecting to a PCP, and in %NL80211_CMD_START_AP to start
* a PCP instead of AP. Relevant for DMG networks only.
*
+ * @NL80211_ATTR_WIPHY_TX_POWER_MODE: Transmit power mode. See
+ * &enum nl80211_tx_power_mode for possible values.
+ *
* @NUM_NL80211_ATTR: total number of nl80211_attrs available
* @NL80211_ATTR_MAX: highest attribute number currently defined
* @__NL80211_ATTR_AFTER_LAST: internal use
@@ -2172,6 +2175,8 @@ enum nl80211_attrs {
NL80211_ATTR_PBSS,
+ NL80211_ATTR_WIPHY_TX_POWER_MODE,
+
/* add attributes here, update the policy in nl80211.c */
__NL80211_ATTR_AFTER_LAST,
@@ -3703,6 +3708,22 @@ enum nl80211_tx_power_setting {
};
/**
+ * enum nl80211_tx_power_mode - TX power mode setting
+ * @NL80211_TX_POWER_LOW: general low TX power mode
+ * @NL80211_TX_POWER_MEDIUM: general medium TX power mode
+ * @NL80211_TX_POWER_HIGH: general high TX power mode
+ * @NL80211_TX_POWER_CLAMSHELL: clamshell mode TX power mode
+ * @NL80211_TX_POWER_TABLET: tablet mode TX power mode
+ */
+enum nl80211_tx_power_mode {
+ NL80211_TX_POWER_LOW,
+ NL80211_TX_POWER_MEDIUM,
+ NL80211_TX_POWER_HIGH,
+ NL80211_TX_POWER_CLAMSHELL,
+ NL80211_TX_POWER_TABLET,
+};
+
+/**
* enum nl80211_packet_pattern_attr - packet pattern attribute
* @__NL80211_PKTPAT_INVALID: invalid number for nested attribute
* @NL80211_PKTPAT_PATTERN: the pattern, values where the mask has
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 056a730..61b474d 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -402,6 +402,7 @@ static const struct nla_policy
nl80211_policy[NUM_NL80211_ATTR] = {
[NL80211_ATTR_SCHED_SCAN_DELAY] = { .type = NLA_U32 },
[NL80211_ATTR_REG_INDOOR] = { .type = NLA_FLAG },
[NL80211_ATTR_PBSS] = { .type = NLA_FLAG },
+ [NL80211_ATTR_WIPHY_TX_POWER_MODE] = { .type = NLA_U32 },
};
/* policy for the key attributes */
@@ -2218,6 +2219,21 @@ static int nl80211_set_wiphy(struct sk_buff *skb, struct
genl_info *info)
return result;
}
+ if (info->attrs[NL80211_ATTR_WIPHY_TX_POWER_MODE]) {
+ enum nl80211_tx_power_mode mode;
+ int idx = 0;
+
+ if (!rdev->ops->set_tx_power_mode)
+ return -EOPNOTSUPP;
+
+ idx = NL80211_ATTR_WIPHY_TX_POWER_MODE;
+ mode = nla_get_u32(info->attrs[idx]);
+
+ result = rdev_set_tx_power_mode(rdev, mode);
+ if (result)
+ return result;
+ }
+
if (info->attrs[NL80211_ATTR_WIPHY_ANTENNA_TX] &&
info->attrs[NL80211_ATTR_WIPHY_ANTE
Re: [PATCH] mwifiex: advertise low priority scan feature
I've resent the patch here: https://patchwork.kernel.org/patch/8637861/ Thanks! Wei-Ning On Tue, Mar 22, 2016 at 12:12 PM, Wei-Ning Huang wrote: > Hi Kalle, > > Thanks for the review. I accidentally removed the s-o-b line from > akarwar in this version. > The original patch can be found at: > https://chromium-review.googlesource.com/#/c/246052/ > I've resent a new one. > > Wei-Ning > > On Mon, Mar 21, 2016 at 6:28 PM, Kalle Valo wrote: >> Wei-Ning Huang writes: >> >>> From: Amitkumar Karwar >>> >>> Low priority scan handling code which delays or aborts scan >>> operation based on Tx traffic is removed recently. The reason >>> is firmware already takes care of it in our new feature scan >>> channel gap. Hence we should advertise low priority scan >>> support to cfg80211. >>> >>> This patch fixes a problem in which OBSS scan request from >>> wpa_supplicant was being rejected by cfg80211. >>> >>> Signed-off-by: Wei-Ning Huang >> >> The From line states that this is written by Amitkumar but there's no >> Signed-off-By line from him. I can't take this without that, please >> resend. >> >> (Wei-Ning's s-o-b line is correct, I just need also Amitkumar's line.) >> >> -- >> Kalle Valo > > > > -- > Wei-Ning Huang, 黃偉寧 | Software Engineer, Google Inc., Taiwan | > wnhu...@google.com | Cell: +886 910-380678 -- Wei-Ning Huang, 黃偉寧 | Software Engineer, Google Inc., Taiwan | wnhu...@google.com | Cell: +886 910-380678
Re: [PATCH] mwifiex: add __GFP_REPEAT to skb allocation call
Adding some chromium devs to the thread. In, http://lxr.free-electrons.com/source/mm/page_alloc.c#L3152 The default mm retry allocation when 'order <= PAGE_ALLOC_COSTLY_ORDER' of gfp_mask contains __GFP_REPEAT. PAGE_ALLOC_COSTLY_ORDER is defined to be 3. On systems with page size = 4K, this means memory compaction and retry is only done when the size of allocation is <= 32K In mwifiex, the allocation size is 64K. When we have system with memory fragmentation and allocation failed, there will be no retry. This is why we need to add __GFP_REPEAT here to allow the system to perform memory compaction and retry allocation. Maybe Amit@marvell can comment on if this is a good fix on this issue. I'm also aware that marvell is the progress of implementing scatter/gatter for mwifiex, which can also fix the issue. Wei-Ning On Tue, Mar 29, 2016 at 4:37 PM, Kalle Valo wrote: > Wei-Ning Huang writes: > >> "single skb allocation failure" happens when system is under heavy >> memory pressure. Add __GFP_REPEAT to skb allocation call so kernel >> attempts to reclaim pages and retry the allocation. >> >> Signed-off-by: Wei-Ning Huang > > Is this really a proper way to fix the issue? This is the first time I'm > hearing about the flag and there isn't even a single user in > drivers/net. I would like to get confirmation from others that > __GFP_REPEAT is really ok to use in a wireless driver before I can take > this. > > -- > Kalle Valo -- Wei-Ning Huang, 黃偉寧 | Software Engineer, Google Inc., Taiwan | wnhu...@google.com | Cell: +886 910-380678
[PATCH] mwifiex: add __GFP_REPEAT to skb allocation call
"single skb allocation failure" happens when system is under heavy
memory pressure. Add __GFP_REPEAT to skb allocation call so kernel
attempts to reclaim pages and retry the allocation.
Signed-off-by: Wei-Ning Huang
---
drivers/net/wireless/marvell/mwifiex/sdio.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c
b/drivers/net/wireless/marvell/mwifiex/sdio.c
index b2c839a..c64989c 100644
--- a/drivers/net/wireless/marvell/mwifiex/sdio.c
+++ b/drivers/net/wireless/marvell/mwifiex/sdio.c
@@ -1124,7 +1124,8 @@ static void mwifiex_deaggr_sdio_pkt(struct
mwifiex_adapter *adapter,
break;
}
skb_deaggr = mwifiex_alloc_dma_align_buf(pkt_len,
-GFP_KERNEL | GFP_DMA);
+GFP_KERNEL | GFP_DMA |
+__GFP_REPEAT);
if (!skb_deaggr)
break;
skb_put(skb_deaggr, pkt_len);
@@ -1374,7 +1375,8 @@ static int mwifiex_sdio_card_to_host_mp_aggr(struct
mwifiex_adapter *adapter,
/* copy pkt to deaggr buf */
skb_deaggr = mwifiex_alloc_dma_align_buf(len_arr[pind],
GFP_KERNEL |
-GFP_DMA);
+GFP_DMA |
+__GFP_REPEAT);
if (!skb_deaggr) {
mwifiex_dbg(adapter, ERROR, "skb allocation
failure\t"
"drop pkt len=%d type=%d\n",
@@ -1416,7 +1418,8 @@ rx_curr_single:
mwifiex_dbg(adapter, INFO, "info: RX: port: %d, rx_len: %d\n",
port, rx_len);
- skb = mwifiex_alloc_dma_align_buf(rx_len, GFP_KERNEL | GFP_DMA);
+ skb = mwifiex_alloc_dma_align_buf(rx_len, GFP_KERNEL | GFP_DMA |
+ __GFP_REPEAT);
if (!skb) {
mwifiex_dbg(adapter, ERROR,
"single skb allocated fail,\t"
@@ -1521,7 +1524,8 @@ static int mwifiex_process_int_status(struct
mwifiex_adapter *adapter)
rx_len = (u16) (rx_blocks * MWIFIEX_SDIO_BLOCK_SIZE);
mwifiex_dbg(adapter, INFO, "info: rx_len = %d\n", rx_len);
- skb = mwifiex_alloc_dma_align_buf(rx_len, GFP_KERNEL | GFP_DMA);
+ skb = mwifiex_alloc_dma_align_buf(rx_len, GFP_KERNEL | GFP_DMA |
+ __GFP_REPEAT);
if (!skb)
return -1;
--
2.8.0.rc3.226.g39d4020
Re: [PATCH v2] mwifiex: advertise low priority scan feature
Tested-by: Wei-Ning Huang On Tue, Mar 22, 2016 at 12:09 PM, Wei-Ning Huang wrote: > From: Amitkumar Karwar > > Low priority scan handling code which delays or aborts scan > operation based on Tx traffic is removed recently. The reason > is firmware already takes care of it in our new feature scan > channel gap. Hence we should advertise low priority scan > support to cfg80211. > > This patch fixes a problem in which OBSS scan request from > wpa_supplicant was being rejected by cfg80211. > > Signed-off-by: Amitkumar Karwar > Signed-off-by: Wei-Ning Huang > --- > drivers/net/wireless/marvell/mwifiex/cfg80211.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c > b/drivers/net/wireless/marvell/mwifiex/cfg80211.c > index bb7235e..7dafc5b 100644 > --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c > +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c > @@ -4086,6 +4086,7 @@ int mwifiex_register_cfg80211(struct mwifiex_adapter > *adapter) > > wiphy->features |= NL80211_FEATURE_HT_IBSS | >NL80211_FEATURE_INACTIVITY_TIMER | > + NL80211_FEATURE_LOW_PRIORITY_SCAN | >NL80211_FEATURE_NEED_OBSS_SCAN; > > if (ISSUPP_TDLS_ENABLED(adapter->fw_cap_info)) > -- > 2.8.0.rc3.226.g39d4020 > -- Wei-Ning Huang, 黃偉寧 | Software Engineer, Google Inc., Taiwan | wnhu...@google.com | Cell: +886 910-380678
Re: [PATCH] mwifiex: advertise low priority scan feature
Hi Kalle, Thanks for the review. I accidentally removed the s-o-b line from akarwar in this version. The original patch can be found at: https://chromium-review.googlesource.com/#/c/246052/ I've resent a new one. Wei-Ning On Mon, Mar 21, 2016 at 6:28 PM, Kalle Valo wrote: > Wei-Ning Huang writes: > >> From: Amitkumar Karwar >> >> Low priority scan handling code which delays or aborts scan >> operation based on Tx traffic is removed recently. The reason >> is firmware already takes care of it in our new feature scan >> channel gap. Hence we should advertise low priority scan >> support to cfg80211. >> >> This patch fixes a problem in which OBSS scan request from >> wpa_supplicant was being rejected by cfg80211. >> >> Signed-off-by: Wei-Ning Huang > > The From line states that this is written by Amitkumar but there's no > Signed-off-By line from him. I can't take this without that, please > resend. > > (Wei-Ning's s-o-b line is correct, I just need also Amitkumar's line.) > > -- > Kalle Valo -- Wei-Ning Huang, 黃偉寧 | Software Engineer, Google Inc., Taiwan | wnhu...@google.com | Cell: +886 910-380678
[PATCH v2] mwifiex: advertise low priority scan feature
From: Amitkumar Karwar Low priority scan handling code which delays or aborts scan operation based on Tx traffic is removed recently. The reason is firmware already takes care of it in our new feature scan channel gap. Hence we should advertise low priority scan support to cfg80211. This patch fixes a problem in which OBSS scan request from wpa_supplicant was being rejected by cfg80211. Signed-off-by: Amitkumar Karwar Signed-off-by: Wei-Ning Huang --- drivers/net/wireless/marvell/mwifiex/cfg80211.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c index bb7235e..7dafc5b 100644 --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c @@ -4086,6 +4086,7 @@ int mwifiex_register_cfg80211(struct mwifiex_adapter *adapter) wiphy->features |= NL80211_FEATURE_HT_IBSS | NL80211_FEATURE_INACTIVITY_TIMER | + NL80211_FEATURE_LOW_PRIORITY_SCAN | NL80211_FEATURE_NEED_OBSS_SCAN; if (ISSUPP_TDLS_ENABLED(adapter->fw_cap_info)) -- 2.8.0.rc3.226.g39d4020
[PATCH] mwifiex: advertise low priority scan feature
From: Amitkumar Karwar Low priority scan handling code which delays or aborts scan operation based on Tx traffic is removed recently. The reason is firmware already takes care of it in our new feature scan channel gap. Hence we should advertise low priority scan support to cfg80211. This patch fixes a problem in which OBSS scan request from wpa_supplicant was being rejected by cfg80211. Signed-off-by: Wei-Ning Huang --- drivers/net/wireless/marvell/mwifiex/cfg80211.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c index bb7235e..7dafc5b 100644 --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c @@ -4086,6 +4086,7 @@ int mwifiex_register_cfg80211(struct mwifiex_adapter *adapter) wiphy->features |= NL80211_FEATURE_HT_IBSS | NL80211_FEATURE_INACTIVITY_TIMER | + NL80211_FEATURE_LOW_PRIORITY_SCAN | NL80211_FEATURE_NEED_OBSS_SCAN; if (ISSUPP_TDLS_ENABLED(adapter->fw_cap_info)) -- 2.8.0.rc3.226.g39d4020
Re: [PATCH] mwifiex: advertise low priority scan feature
Tested-by: Wei-Ning Huang On Mon, Mar 21, 2016 at 4:07 PM, Wei-Ning Huang wrote: > From: Amitkumar Karwar > > Low priority scan handling code which delays or aborts scan > operation based on Tx traffic is removed recently. The reason > is firmware already takes care of it in our new feature scan > channel gap. Hence we should advertise low priority scan > support to cfg80211. > > This patch fixes a problem in which OBSS scan request from > wpa_supplicant was being rejected by cfg80211. > > Signed-off-by: Wei-Ning Huang > --- > drivers/net/wireless/marvell/mwifiex/cfg80211.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c > b/drivers/net/wireless/marvell/mwifiex/cfg80211.c > index bb7235e..7dafc5b 100644 > --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c > +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c > @@ -4086,6 +4086,7 @@ int mwifiex_register_cfg80211(struct mwifiex_adapter > *adapter) > > wiphy->features |= NL80211_FEATURE_HT_IBSS | >NL80211_FEATURE_INACTIVITY_TIMER | > + NL80211_FEATURE_LOW_PRIORITY_SCAN | >NL80211_FEATURE_NEED_OBSS_SCAN; > > if (ISSUPP_TDLS_ENABLED(adapter->fw_cap_info)) > -- > 2.8.0.rc3.226.g39d4020 > -- Wei-Ning Huang, 黃偉寧 | Software Engineer, Google Inc., Taiwan | wnhu...@google.com | Cell: +886 910-380678
[PATCH] Bluetooth: hci_core: cancel power off delayed work properly
From: Wei-Ning Huang
When the HCI_AUTO_OFF flag is cleared, the power_off delayed work need
to be cancel or HCI will be powered off even if it's managed.
Signed-off-by: Wei-Ning Huang
---
net/bluetooth/hci_core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index 47bcef7..f42305a 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -2017,6 +2017,7 @@ static void hci_power_on(struct work_struct *work)
if (test_bit(HCI_UP, &hdev->flags) &&
hci_dev_test_flag(hdev, HCI_MGMT) &&
hci_dev_test_and_clear_flag(hdev, HCI_AUTO_OFF)) {
+ cancel_delayed_work(&hdev->power_off);
hci_req_sync_lock(hdev);
err = __hci_req_hci_power_on(hdev);
hci_req_sync_unlock(hdev);
--
2.7.0.rc3.207.g0ac5344
