Re: [PATCH 0/4] NetXen: Initialization, link status and other bug fixes
On Thu, 2007-06-07 at 04:28 -0700, Mithlesh Thukral wrote: Hi All, I will be sending bug fixes related to initialization, link status and some compile issues of NetXen's 1/10G Ethernet driver in subsequent mails. These patches are wrt netdev#upstream-fixes. Regards, Mithlesh Thukral Jeff, Thanks for your review this series patches on 6/3. Based on your comments, we have re-submitted the patches with your requirements. Also we have tested these patches on x/pBlade in our lab. Thanks, wendy - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/5] NetXen: Add NETXEN prefix to macros
On Sun, 2007-06-03 at 11:50 -0400, Jeff Garzik wrote: Mithlesh Thukral wrote: NetXen: Add NETXEN prefix to a macro This patch will add the NETXEN prefix to USER_START macro. Signed-off by: Wen Xiong [EMAIL PROTECTED] Signed-off by: Mithlesh Thukral [EMAIL PROTECTED] --- drivers/net/netxen/netxen_nic.h |4 ++-- drivers/net/netxen/netxen_nic_ethtool.c |2 +- drivers/net/netxen/netxen_nic_hw.c |4 ++-- drivers/net/netxen/netxen_nic_init.c|4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) Your patch description is useless. Clearly we know -what- it does, simply by reading the patch. But it does not answer the simple question: why? why is this needed in a bug fix Release Candidate series? Hi Jeff, When we backported netxen driver to 2.6.9 kernel on ppc, we saw the compile errors for USER_START. Because there is another definition for USER_START which is used by arch/ppc64/mm/hash_utils.c and native.c. So we like to add NETXEN before USER_START in netxen device driver, then netxen driver can be compiled correctly in 2.6.9 kernel. Let me know if you any question for this patch. Thanks, wendy Xiong - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 4/5] NetXen: Fix ping issue
On Sun, 2007-06-03 at 11:51 -0400, Jeff Garzik wrote: Mithlesh Thukral wrote: NetXen: Fix initialization and subsequent ping issue This patch will fix the initialization and ping issues seen on certain PPC architecture blades. Signed-off by: Wen Xiong [EMAIL PROTECTED] Signed-off by: Mithlesh Thukral [EMAIL PROTECTED] --- drivers/net/netxen/netxen_nic_main.c |7 +++ drivers/net/netxen/netxen_nic_niu.c |8 ++-- 2 files changed, 9 insertions(+), 6 deletions(-) Again, your patch description is useless. You should describe the problem being fixed, and how/why the changes seen in the patch actually fix the issue. Hi Jeff, Ping problem description: After we moved up netxen adapter's firmware to 3.4.19, we saw this ping problem on x/pBlade. After configured interface up, ping -c 1 10.10.10.10 failed. Netxen adapter couldn't accept ARP broadcast packet somehow. If I manually added MAC address in the ARP table, then ping start working. netxen adapter should finish initilization after system boot. But on some platform, looks netxen adapter didn't initilization correctly after system boot up, so have to re-load the firmware again in probe routine. Also re-initilization netxen_config_0 and netxen_config_1 registers. Let me know if you have any question for this patch. Thanks Wendy Xiong - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/5] NetXen: Add NETXEN prefix to macros
On Wed, 2007-06-06 at 14:05 -0400, Jeff Garzik wrote: On Wed, Jun 06, 2007 at 12:52:44PM -0500, wendy xiong wrote: On Sun, 2007-06-03 at 11:50 -0400, Jeff Garzik wrote: Mithlesh Thukral wrote: NetXen: Add NETXEN prefix to a macro This patch will add the NETXEN prefix to USER_START macro. Signed-off by: Wen Xiong [EMAIL PROTECTED] Signed-off by: Mithlesh Thukral [EMAIL PROTECTED] --- drivers/net/netxen/netxen_nic.h |4 ++-- drivers/net/netxen/netxen_nic_ethtool.c |2 +- drivers/net/netxen/netxen_nic_hw.c |4 ++-- drivers/net/netxen/netxen_nic_init.c|4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) Your patch description is useless. Clearly we know -what- it does, simply by reading the patch. But it does not answer the simple question: why? why is this needed in a bug fix Release Candidate series? Hi Jeff, When we backported netxen driver to 2.6.9 kernel on ppc, we saw the compile errors for USER_START. Because there is another definition for USER_START which is used by arch/ppc64/mm/hash_utils.c and native.c. So we like to add NETXEN before USER_START in netxen device driver, then netxen driver can be compiled correctly in 2.6.9 kernel. Let me know if you any question for this patch. That answers my questions, but doesn't address the issue: You need to regenerate the patch with the description improved as described. The patch description is copied verbatim into the kernel changelog, and preserved verbatim for all eternity. Four years from now, we need to be able to read the patch description and understand -why- the NETXEN_xxx prefix was added. Simply stating that the NETXEN_xxx prefix was added is useless, as it is self-evident from reading the patch itself. Jeff Jeff, Thanks. We will re-generate the patch with correct issue title and description. Thanks, wendy - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 5/5] NetXen: Fix link status messages
On Sun, 2007-06-03 at 11:51 -0400, Jeff Garzik wrote: Mithlesh Thukral wrote: NetXen: Correct link status messages. This patch will fix the problem of wrong link status messages that were reported. Signed-off by: Wen Xiong [EMAIL PROTECTED] Signed-off by: Mithlesh Thukral [EMAIL PROTECTED] --- drivers/net/netxen/netxen_nic.h |1 + drivers/net/netxen/netxen_nic_init.c | 21 + drivers/net/netxen/netxen_nic_isr.c | 23 +++ 3 files changed, 37 insertions(+), 8 deletions(-) dropped due to previous patches being dropped Hi Jeff, Thanks for your review the patch! We are going to re-submit the patch with correct problem description. Thanks, wendy - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] e1000: Work around 82571 completion timout on Pseries HW
On Thu, 2007-05-17 at 17:04 -0400, Jeff Garzik wrote: Wen Xiong wrote: Here there are not hardware issue on both Intel or PPC. The patch is to work around a loop hold on early version of PCI SGI spec. The later PCI Sgi have spec have corrected it. We can just implement it for PPC only. Other vendor may have the same issue. If it is not a PPC-specific issue, then we should not limit it to PPC. Jeff Hi Jeff, We have tested the patch on PowerPC CEC and IO drawers. We really want to fix this for PPC. If you can accept for vendors, we are ok. Thanks for your help! wendy - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [patch 1/1] icom: Add new sub-device-id to support new adapter
Hi Andrew,
I have tested this with new adapter on our systems. I didn't get
comments since I sent out last Wednesday.
Could you help me with this patch?
Thank you very much!
Wendy
On Wed, 2007-05-09 at 17:36 -0500, wendy xiong wrote:
This patch add new sub-device-id to support new adapter and changed the
interrupt irq number for unsigned char to unsigned int.
Signed-off by: Wendy Xiong [EMAIL PROTECTED]
diff -Nuar linux-2.6.21-rc7.orig/drivers/serial/icom.c
linux-2.6.21-rc7.new/drivers/serial/icom.c
--- linux-2.6.21-rc7.orig/drivers/serial/icom.c 2008-01-10 23:53:59.0
-0600
+++ linux-2.6.21-rc7.new/drivers/serial/icom.c 2008-01-10 23:58:30.0
-0600
@@ -97,6 +97,13 @@
.subdevice = PCI_DEVICE_ID_IBM_ICOM_FOUR_PORT_MODEL,
.driver_data = ADAPTER_V2,
},
+ {
+ .vendor = PCI_VENDOR_ID_IBM,
+ .device = PCI_DEVICE_ID_IBM_ICOM_DEV_ID_2,
+ .subvendor = PCI_VENDOR_ID_IBM,
+ .subdevice =
PCI_DEVICE_ID_IBM_ICOM_V2_ONE_PORT_RVX_ONE_PORT_MDM_PCIE,
+ .driver_data = ADAPTER_V2,
+},
{}
};
diff -Nuar linux-2.6.21-rc7.orig/drivers/serial/icom.h
linux-2.6.21-rc7.new/drivers/serial/icom.h
--- linux-2.6.21-rc7.orig/drivers/serial/icom.h 2008-01-10 23:53:59.0
-0600
+++ linux-2.6.21-rc7.new/drivers/serial/icom.h 2008-01-10 23:55:42.0
-0600
@@ -258,7 +258,7 @@
struct icom_adapter {
void __iomem * base_addr;
unsigned long base_addr_pci;
- unsigned char irq_number;
+ unsigned int irq_number;
struct pci_dev *pci_dev;
struct icom_port port_info[4];
int index;
diff -Nuar linux-2.6.21-rc7.orig/include/linux/pci_ids.h
linux-2.6.21-rc7.new/include/linux/pci_ids.h
--- linux-2.6.21-rc7.orig/include/linux/pci_ids.h 2008-01-10
23:54:13.0 -0600
+++ linux-2.6.21-rc7.new/include/linux/pci_ids.h2008-01-10
23:59:08.0 -0600
@@ -471,6 +471,7 @@
#define PCI_DEVICE_ID_IBM_ICOM_DEV_ID_20x0219
#define PCI_DEVICE_ID_IBM_ICOM_V2_TWO_PORTS_RVX0x021A
#define PCI_DEVICE_ID_IBM_ICOM_V2_ONE_PORT_RVX_ONE_PORT_MDM0x0251
+#define PCI_DEVICE_ID_IBM_ICOM_V2_ONE_PORT_RVX_ONE_PORT_MDM_PCIE 0x0361
#define PCI_DEVICE_ID_IBM_ICOM_FOUR_PORT_MODEL 0x252
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
[patch 1/1] icom: Add new sub-device-id to support new adapter
This patch add new sub-device-id to support new adapter and changed the
interrupt irq number for unsigned char to unsigned int.
Signed-off by: Wendy Xiong [EMAIL PROTECTED]
diff -Nuar linux-2.6.21-rc7.orig/drivers/serial/icom.c
linux-2.6.21-rc7.new/drivers/serial/icom.c
--- linux-2.6.21-rc7.orig/drivers/serial/icom.c 2008-01-10 23:53:59.0
-0600
+++ linux-2.6.21-rc7.new/drivers/serial/icom.c 2008-01-10 23:58:30.0
-0600
@@ -97,6 +97,13 @@
.subdevice = PCI_DEVICE_ID_IBM_ICOM_FOUR_PORT_MODEL,
.driver_data = ADAPTER_V2,
},
+ {
+ .vendor = PCI_VENDOR_ID_IBM,
+ .device = PCI_DEVICE_ID_IBM_ICOM_DEV_ID_2,
+ .subvendor = PCI_VENDOR_ID_IBM,
+ .subdevice =
PCI_DEVICE_ID_IBM_ICOM_V2_ONE_PORT_RVX_ONE_PORT_MDM_PCIE,
+ .driver_data = ADAPTER_V2,
+},
{}
};
diff -Nuar linux-2.6.21-rc7.orig/drivers/serial/icom.h
linux-2.6.21-rc7.new/drivers/serial/icom.h
--- linux-2.6.21-rc7.orig/drivers/serial/icom.h 2008-01-10 23:53:59.0
-0600
+++ linux-2.6.21-rc7.new/drivers/serial/icom.h 2008-01-10 23:55:42.0
-0600
@@ -258,7 +258,7 @@
struct icom_adapter {
void __iomem * base_addr;
unsigned long base_addr_pci;
- unsigned char irq_number;
+ unsigned int irq_number;
struct pci_dev *pci_dev;
struct icom_port port_info[4];
int index;
diff -Nuar linux-2.6.21-rc7.orig/include/linux/pci_ids.h
linux-2.6.21-rc7.new/include/linux/pci_ids.h
--- linux-2.6.21-rc7.orig/include/linux/pci_ids.h 2008-01-10
23:54:13.0 -0600
+++ linux-2.6.21-rc7.new/include/linux/pci_ids.h2008-01-10
23:59:08.0 -0600
@@ -471,6 +471,7 @@
#define PCI_DEVICE_ID_IBM_ICOM_DEV_ID_20x0219
#define PCI_DEVICE_ID_IBM_ICOM_V2_TWO_PORTS_RVX0x021A
#define PCI_DEVICE_ID_IBM_ICOM_V2_ONE_PORT_RVX_ONE_PORT_MDM0x0251
+#define PCI_DEVICE_ID_IBM_ICOM_V2_ONE_PORT_RVX_ONE_PORT_MDM_PCIE 0x0361
#define PCI_DEVICE_ID_IBM_ICOM_FOUR_PORT_MODEL 0x252
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
