Re: [2.6.25-rc2] e100: Trying to free already-free IRQ 11 during suspend ...
On Thursday 21 February 2008, Kok, Auke wrote:
> Kok, Auke wrote:
> > Kok, Auke wrote:
> >> Andrew Morton wrote:
> >>> On Sun, 17 Feb 2008 15:36:50 +0300 Andrey Borzenkov <[EMAIL PROTECTED]>
> >>> wrote:
> >>>
> ... and possibly reboot/poweroff (it flows by too fast to be legible).
>
> [ 8803.850634] ACPI: Preparing to enter system sleep state S3
> [ 8803.853141] Suspending console(s)
> [ 8805.287505] serial 00:09: disabled
> [ 8805.291564] Trying to free already-free IRQ 11
> [ 8805.291579] Pid: 6920, comm: pm-suspend Not tainted 2.6.25-rc2-1avb #2
> [ 8805.291628] [] free_irq+0xb7/0x130
> [ 8805.291675] [] e100_suspend+0xc0/0x100
> [ 8805.291724] [] pci_device_suspend+0x26/0x70
> [ 8805.291747] [] suspend_device+0x94/0xd0
> [ 8805.291763] [] device_suspend+0x153/0x240
> [ 8805.291784] [] suspend_devices_and_enter+0x4f/0xf0
> [ 8805.291808] [] ? freeze_processes+0x3f/0x80
> [ 8805.291825] [] enter_state+0xaa/0x140
> [ 8805.291840] [] state_store+0x8f/0xd0
> [ 8805.291852] [] ? state_store+0x0/0xd0
> [ 8805.291866] [] kobj_attr_store+0x24/0x30
> [ 8805.291901] [] sysfs_write_file+0xbb/0x110
> [ 8805.291936] [] vfs_write+0x99/0x130
> [ 8805.291963] [] ? sysfs_write_file+0x0/0x110
> [ 8805.291979] [] sys_write+0x3d/0x70
> [ 8805.291998] [] sysenter_past_esp+0x5f/0xa5
> [ 8805.292038] ===
> [ 8805.347640] ACPI: PCI interrupt for device :00:06.0 disabled
> [ 8805.361128] ACPI: PCI interrupt for device :00:02.0 disabled
> [ 8805.376670] hwsleep-0322 [00] enter_sleep_state : Entering sleep
> state [S3]
> [ 8805.376670] Back to C!
>
> Interface is unused normally (only for netconsole sometimes). dmesg and
> config
> attached.
> >>> Does reverting this:
> >>>
> >>> commit 8543da6672b0994921f014f2250e27ae81645580
> >>> Author: Auke Kok <[EMAIL PROTECTED]>
> >>> Date: Wed Dec 12 16:30:42 2007 -0800
> >>>
> >>> e100: free IRQ to remove warningwhenrebooting
> >>>
> >>> with this patch:
> >>>
> >>> --- a/drivers/net/e100.c~revert-1
> >>> +++ a/drivers/net/e100.c
> >>> @@ -2804,9 +2804,8 @@ static int e100_suspend(struct pci_dev *
> >>> pci_enable_wake(pdev, PCI_D3cold, 0);
> >>> }
> >>>
> >>> - free_irq(pdev->irq, netdev);
> >>> -
> >>> pci_disable_device(pdev);
> >>> + free_irq(pdev->irq, netdev);
> >>> pci_set_power_state(pdev, PCI_D3hot);
> >>>
> >>> return 0;
> >>> @@ -2848,8 +2847,6 @@ static void e100_shutdown(struct pci_dev
> >>> pci_enable_wake(pdev, PCI_D3cold, 0);
> >>> }
> >>>
> >>> - free_irq(pdev->irq, netdev);
> >>> -
> >>> pci_disable_device(pdev);
> >>> pci_set_power_state(pdev, PCI_D3hot);
> >>> }
> >>> _
> >>>
> >>> fix it?
> >>>
> Hmm ... after resume device has disappeared at all ...
>
> {pts/1}% cat /proc/interrupts
> CPU0
> 0:1290492XT-PIC-XTtimer
> 1: 6675XT-PIC-XTi8042
> 2: 0XT-PIC-XTcascade
> 3: 2XT-PIC-XT
> 4: 2XT-PIC-XT
> 5: 3XT-PIC-XT
> 7: 4XT-PIC-XTirda0
> 8: 0XT-PIC-XTrtc0
> 9:583XT-PIC-XTacpi
> 10: 2XT-PIC-XT
> 11: 31483XT-PIC-XTyenta, yenta, yenta, ohci_hcd:usb1,
> ALI 5451, pcmcia0.0
> 12: 28070XT-PIC-XTi8042
> 14: 21705XT-PIC-XTide0
> 15: 82123XT-PIC-XTide1
> NMI: 0 Non-maskable interrupts
> TRM: 0 Thermal event interrupts
> SPU: 0 Spurious interrupts
> ERR: 0
> >>> I hope that's not a separate bug...
> >> I'll take a look at this as well. thanks for reporting.
> >
> > ok, I just had a repro - on a regular shutdown even.
> >
> > this always worked before - I'm not blaming anything yet but something in
> > the pci
> > shutdown code must now be freeing our irq for us (I'm not using anything
> > fancy to
> > autoconfigure my network here).
> >
> > I definately do not see this with 2.6.24 either.
>
> can you try this patch please? It rewrites e100 to do suspend/shutdown just
> like
> e1000e does, which is much more tested than anything else. I don't get the IRQ
> message anymore - but I haven't gotten to testing suspend/resume just yet.
>
Yes it fixes it.
signature.asc
Description: This is a digitally signed message part.
Re: [2.6.25-rc2] e100: Trying to free already-free IRQ 11 during suspend ...
Kok, Auke wrote:
> Kok, Auke wrote:
>> Andrew Morton wrote:
>>> On Sun, 17 Feb 2008 15:36:50 +0300 Andrey Borzenkov <[EMAIL PROTECTED]>
>>> wrote:
>>>
... and possibly reboot/poweroff (it flows by too fast to be legible).
[ 8803.850634] ACPI: Preparing to enter system sleep state S3
[ 8803.853141] Suspending console(s)
[ 8805.287505] serial 00:09: disabled
[ 8805.291564] Trying to free already-free IRQ 11
[ 8805.291579] Pid: 6920, comm: pm-suspend Not tainted 2.6.25-rc2-1avb #2
[ 8805.291628] [] free_irq+0xb7/0x130
[ 8805.291675] [] e100_suspend+0xc0/0x100
[ 8805.291724] [] pci_device_suspend+0x26/0x70
[ 8805.291747] [] suspend_device+0x94/0xd0
[ 8805.291763] [] device_suspend+0x153/0x240
[ 8805.291784] [] suspend_devices_and_enter+0x4f/0xf0
[ 8805.291808] [] ? freeze_processes+0x3f/0x80
[ 8805.291825] [] enter_state+0xaa/0x140
[ 8805.291840] [] state_store+0x8f/0xd0
[ 8805.291852] [] ? state_store+0x0/0xd0
[ 8805.291866] [] kobj_attr_store+0x24/0x30
[ 8805.291901] [] sysfs_write_file+0xbb/0x110
[ 8805.291936] [] vfs_write+0x99/0x130
[ 8805.291963] [] ? sysfs_write_file+0x0/0x110
[ 8805.291979] [] sys_write+0x3d/0x70
[ 8805.291998] [] sysenter_past_esp+0x5f/0xa5
[ 8805.292038] ===
[ 8805.347640] ACPI: PCI interrupt for device :00:06.0 disabled
[ 8805.361128] ACPI: PCI interrupt for device :00:02.0 disabled
[ 8805.376670] hwsleep-0322 [00] enter_sleep_state : Entering sleep
state [S3]
[ 8805.376670] Back to C!
Interface is unused normally (only for netconsole sometimes). dmesg and
config
attached.
>>> Does reverting this:
>>>
>>> commit 8543da6672b0994921f014f2250e27ae81645580
>>> Author: Auke Kok <[EMAIL PROTECTED]>
>>> Date: Wed Dec 12 16:30:42 2007 -0800
>>>
>>> e100: free IRQ to remove warningwhenrebooting
>>>
>>> with this patch:
>>>
>>> --- a/drivers/net/e100.c~revert-1
>>> +++ a/drivers/net/e100.c
>>> @@ -2804,9 +2804,8 @@ static int e100_suspend(struct pci_dev *
>>> pci_enable_wake(pdev, PCI_D3cold, 0);
>>> }
>>>
>>> - free_irq(pdev->irq, netdev);
>>> -
>>> pci_disable_device(pdev);
>>> + free_irq(pdev->irq, netdev);
>>> pci_set_power_state(pdev, PCI_D3hot);
>>>
>>> return 0;
>>> @@ -2848,8 +2847,6 @@ static void e100_shutdown(struct pci_dev
>>> pci_enable_wake(pdev, PCI_D3cold, 0);
>>> }
>>>
>>> - free_irq(pdev->irq, netdev);
>>> -
>>> pci_disable_device(pdev);
>>> pci_set_power_state(pdev, PCI_D3hot);
>>> }
>>> _
>>>
>>> fix it?
>>>
Hmm ... after resume device has disappeared at all ...
{pts/1}% cat /proc/interrupts
CPU0
0:1290492XT-PIC-XTtimer
1: 6675XT-PIC-XTi8042
2: 0XT-PIC-XTcascade
3: 2XT-PIC-XT
4: 2XT-PIC-XT
5: 3XT-PIC-XT
7: 4XT-PIC-XTirda0
8: 0XT-PIC-XTrtc0
9:583XT-PIC-XTacpi
10: 2XT-PIC-XT
11: 31483XT-PIC-XTyenta, yenta, yenta, ohci_hcd:usb1,
ALI 5451, pcmcia0.0
12: 28070XT-PIC-XTi8042
14: 21705XT-PIC-XTide0
15: 82123XT-PIC-XTide1
NMI: 0 Non-maskable interrupts
TRM: 0 Thermal event interrupts
SPU: 0 Spurious interrupts
ERR: 0
>>> I hope that's not a separate bug...
>> I'll take a look at this as well. thanks for reporting.
>
> ok, I just had a repro - on a regular shutdown even.
>
> this always worked before - I'm not blaming anything yet but something in the
> pci
> shutdown code must now be freeing our irq for us (I'm not using anything
> fancy to
> autoconfigure my network here).
>
> I definately do not see this with 2.6.24 either.
can you try this patch please? It rewrites e100 to do suspend/shutdown just like
e1000e does, which is much more tested than anything else. I don't get the IRQ
message anymore - but I haven't gotten to testing suspend/resume just yet.
Auke
e100: Do suspend/shutdown like e1000
This fixes a "trying to free already free IRQ" message and simplifies
the shutdown/suspend code by re-using already existing code when going
to suspend. The code is now symmetric with e100_resume.
Signed-off-by: Auke Kok <[EMAIL PROTECTED]>
diff --git a/drivers/net/e100.c b/drivers/net/e100.c
index 36ba6dc..cdf3090 100644
--- a/drivers/net/e100.c
+++ b/drivers/net/e100.c
@@ -2782,16 +2782,13 @@ static void __devexit e100_remove(struct pci_dev *pdev)
}
}
-#ifdef CONFIG_PM
static int e100_suspend(struct pci_dev *pdev, pm_message_t state)
{
struct net_device *netdev = pci_get_drvdata(pdev);
struct nic *nic = netdev_priv(netdev);
if (netif_running(netdev))
Re: [2.6.25-rc2] e100: Trying to free already-free IRQ 11 during suspend ...
Kok, Auke wrote:
> Andrew Morton wrote:
>> On Sun, 17 Feb 2008 15:36:50 +0300 Andrey Borzenkov <[EMAIL PROTECTED]>
>> wrote:
>>
>>> ... and possibly reboot/poweroff (it flows by too fast to be legible).
>>>
>>> [ 8803.850634] ACPI: Preparing to enter system sleep state S3
>>> [ 8803.853141] Suspending console(s)
>>> [ 8805.287505] serial 00:09: disabled
>>> [ 8805.291564] Trying to free already-free IRQ 11
>>> [ 8805.291579] Pid: 6920, comm: pm-suspend Not tainted 2.6.25-rc2-1avb #2
>>> [ 8805.291628] [] free_irq+0xb7/0x130
>>> [ 8805.291675] [] e100_suspend+0xc0/0x100
>>> [ 8805.291724] [] pci_device_suspend+0x26/0x70
>>> [ 8805.291747] [] suspend_device+0x94/0xd0
>>> [ 8805.291763] [] device_suspend+0x153/0x240
>>> [ 8805.291784] [] suspend_devices_and_enter+0x4f/0xf0
>>> [ 8805.291808] [] ? freeze_processes+0x3f/0x80
>>> [ 8805.291825] [] enter_state+0xaa/0x140
>>> [ 8805.291840] [] state_store+0x8f/0xd0
>>> [ 8805.291852] [] ? state_store+0x0/0xd0
>>> [ 8805.291866] [] kobj_attr_store+0x24/0x30
>>> [ 8805.291901] [] sysfs_write_file+0xbb/0x110
>>> [ 8805.291936] [] vfs_write+0x99/0x130
>>> [ 8805.291963] [] ? sysfs_write_file+0x0/0x110
>>> [ 8805.291979] [] sys_write+0x3d/0x70
>>> [ 8805.291998] [] sysenter_past_esp+0x5f/0xa5
>>> [ 8805.292038] ===
>>> [ 8805.347640] ACPI: PCI interrupt for device :00:06.0 disabled
>>> [ 8805.361128] ACPI: PCI interrupt for device :00:02.0 disabled
>>> [ 8805.376670] hwsleep-0322 [00] enter_sleep_state : Entering sleep
>>> state [S3]
>>> [ 8805.376670] Back to C!
>>>
>>> Interface is unused normally (only for netconsole sometimes). dmesg and
>>> config
>>> attached.
>> Does reverting this:
>>
>> commit 8543da6672b0994921f014f2250e27ae81645580
>> Author: Auke Kok <[EMAIL PROTECTED]>
>> Date: Wed Dec 12 16:30:42 2007 -0800
>>
>> e100: free IRQ to remove warningwhenrebooting
>>
>> with this patch:
>>
>> --- a/drivers/net/e100.c~revert-1
>> +++ a/drivers/net/e100.c
>> @@ -2804,9 +2804,8 @@ static int e100_suspend(struct pci_dev *
>> pci_enable_wake(pdev, PCI_D3cold, 0);
>> }
>>
>> -free_irq(pdev->irq, netdev);
>> -
>> pci_disable_device(pdev);
>> +free_irq(pdev->irq, netdev);
>> pci_set_power_state(pdev, PCI_D3hot);
>>
>> return 0;
>> @@ -2848,8 +2847,6 @@ static void e100_shutdown(struct pci_dev
>> pci_enable_wake(pdev, PCI_D3cold, 0);
>> }
>>
>> -free_irq(pdev->irq, netdev);
>> -
>> pci_disable_device(pdev);
>> pci_set_power_state(pdev, PCI_D3hot);
>> }
>> _
>>
>> fix it?
>>
>>> Hmm ... after resume device has disappeared at all ...
>>>
>>> {pts/1}% cat /proc/interrupts
>>>CPU0
>>> 0:1290492XT-PIC-XTtimer
>>> 1: 6675XT-PIC-XTi8042
>>> 2: 0XT-PIC-XTcascade
>>> 3: 2XT-PIC-XT
>>> 4: 2XT-PIC-XT
>>> 5: 3XT-PIC-XT
>>> 7: 4XT-PIC-XTirda0
>>> 8: 0XT-PIC-XTrtc0
>>> 9:583XT-PIC-XTacpi
>>> 10: 2XT-PIC-XT
>>> 11: 31483XT-PIC-XTyenta, yenta, yenta, ohci_hcd:usb1, ALI
>>> 5451, pcmcia0.0
>>> 12: 28070XT-PIC-XTi8042
>>> 14: 21705XT-PIC-XTide0
>>> 15: 82123XT-PIC-XTide1
>>> NMI: 0 Non-maskable interrupts
>>> TRM: 0 Thermal event interrupts
>>> SPU: 0 Spurious interrupts
>>> ERR: 0
>> I hope that's not a separate bug...
>
> I'll take a look at this as well. thanks for reporting.
ok, I just had a repro - on a regular shutdown even.
this always worked before - I'm not blaming anything yet but something in the
pci
shutdown code must now be freeing our irq for us (I'm not using anything fancy
to
autoconfigure my network here).
I definately do not see this with 2.6.24 either.
Auke
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [2.6.25-rc2] e100: Trying to free already-free IRQ 11 during suspend ...
Andrew Morton wrote:
> On Sun, 17 Feb 2008 15:36:50 +0300 Andrey Borzenkov <[EMAIL PROTECTED]> wrote:
>
>> ... and possibly reboot/poweroff (it flows by too fast to be legible).
>>
>> [ 8803.850634] ACPI: Preparing to enter system sleep state S3
>> [ 8803.853141] Suspending console(s)
>> [ 8805.287505] serial 00:09: disabled
>> [ 8805.291564] Trying to free already-free IRQ 11
>> [ 8805.291579] Pid: 6920, comm: pm-suspend Not tainted 2.6.25-rc2-1avb #2
>> [ 8805.291628] [] free_irq+0xb7/0x130
>> [ 8805.291675] [] e100_suspend+0xc0/0x100
>> [ 8805.291724] [] pci_device_suspend+0x26/0x70
>> [ 8805.291747] [] suspend_device+0x94/0xd0
>> [ 8805.291763] [] device_suspend+0x153/0x240
>> [ 8805.291784] [] suspend_devices_and_enter+0x4f/0xf0
>> [ 8805.291808] [] ? freeze_processes+0x3f/0x80
>> [ 8805.291825] [] enter_state+0xaa/0x140
>> [ 8805.291840] [] state_store+0x8f/0xd0
>> [ 8805.291852] [] ? state_store+0x0/0xd0
>> [ 8805.291866] [] kobj_attr_store+0x24/0x30
>> [ 8805.291901] [] sysfs_write_file+0xbb/0x110
>> [ 8805.291936] [] vfs_write+0x99/0x130
>> [ 8805.291963] [] ? sysfs_write_file+0x0/0x110
>> [ 8805.291979] [] sys_write+0x3d/0x70
>> [ 8805.291998] [] sysenter_past_esp+0x5f/0xa5
>> [ 8805.292038] ===
>> [ 8805.347640] ACPI: PCI interrupt for device :00:06.0 disabled
>> [ 8805.361128] ACPI: PCI interrupt for device :00:02.0 disabled
>> [ 8805.376670] hwsleep-0322 [00] enter_sleep_state : Entering sleep
>> state [S3]
>> [ 8805.376670] Back to C!
>>
>> Interface is unused normally (only for netconsole sometimes). dmesg and
>> config
>> attached.
>
> Does reverting this:
>
> commit 8543da6672b0994921f014f2250e27ae81645580
> Author: Auke Kok <[EMAIL PROTECTED]>
> Date: Wed Dec 12 16:30:42 2007 -0800
>
> e100: free IRQ to remove warningwhenrebooting
>
> with this patch:
>
> --- a/drivers/net/e100.c~revert-1
> +++ a/drivers/net/e100.c
> @@ -2804,9 +2804,8 @@ static int e100_suspend(struct pci_dev *
> pci_enable_wake(pdev, PCI_D3cold, 0);
> }
>
> - free_irq(pdev->irq, netdev);
> -
> pci_disable_device(pdev);
> + free_irq(pdev->irq, netdev);
> pci_set_power_state(pdev, PCI_D3hot);
>
> return 0;
> @@ -2848,8 +2847,6 @@ static void e100_shutdown(struct pci_dev
> pci_enable_wake(pdev, PCI_D3cold, 0);
> }
>
> - free_irq(pdev->irq, netdev);
> -
> pci_disable_device(pdev);
> pci_set_power_state(pdev, PCI_D3hot);
> }
> _
>
> fix it?
>
>> Hmm ... after resume device has disappeared at all ...
>>
>> {pts/1}% cat /proc/interrupts
>>CPU0
>> 0:1290492XT-PIC-XTtimer
>> 1: 6675XT-PIC-XTi8042
>> 2: 0XT-PIC-XTcascade
>> 3: 2XT-PIC-XT
>> 4: 2XT-PIC-XT
>> 5: 3XT-PIC-XT
>> 7: 4XT-PIC-XTirda0
>> 8: 0XT-PIC-XTrtc0
>> 9:583XT-PIC-XTacpi
>> 10: 2XT-PIC-XT
>> 11: 31483XT-PIC-XTyenta, yenta, yenta, ohci_hcd:usb1, ALI
>> 5451, pcmcia0.0
>> 12: 28070XT-PIC-XTi8042
>> 14: 21705XT-PIC-XTide0
>> 15: 82123XT-PIC-XTide1
>> NMI: 0 Non-maskable interrupts
>> TRM: 0 Thermal event interrupts
>> SPU: 0 Spurious interrupts
>> ERR: 0
>
> I hope that's not a separate bug...
I'll take a look at this as well. thanks for reporting.
Auke
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [2.6.25-rc2] e100: Trying to free already-free IRQ 11 during suspend ...
On Monday 18 February 2008, Andrew Morton wrote:
> On Sun, 17 Feb 2008 15:36:50 +0300 Andrey Borzenkov <[EMAIL PROTECTED]> wrote:
>
> > ... and possibly reboot/poweroff (it flows by too fast to be legible).
> >
> > [ 8803.850634] ACPI: Preparing to enter system sleep state S3
> > [ 8803.853141] Suspending console(s)
> > [ 8805.287505] serial 00:09: disabled
> > [ 8805.291564] Trying to free already-free IRQ 11
> > [ 8805.291579] Pid: 6920, comm: pm-suspend Not tainted 2.6.25-rc2-1avb #2
> > [ 8805.291628] [] free_irq+0xb7/0x130
> > [ 8805.291675] [] e100_suspend+0xc0/0x100
> > [ 8805.291724] [] pci_device_suspend+0x26/0x70
> > [ 8805.291747] [] suspend_device+0x94/0xd0
> > [ 8805.291763] [] device_suspend+0x153/0x240
> > [ 8805.291784] [] suspend_devices_and_enter+0x4f/0xf0
> > [ 8805.291808] [] ? freeze_processes+0x3f/0x80
> > [ 8805.291825] [] enter_state+0xaa/0x140
> > [ 8805.291840] [] state_store+0x8f/0xd0
> > [ 8805.291852] [] ? state_store+0x0/0xd0
> > [ 8805.291866] [] kobj_attr_store+0x24/0x30
> > [ 8805.291901] [] sysfs_write_file+0xbb/0x110
> > [ 8805.291936] [] vfs_write+0x99/0x130
> > [ 8805.291963] [] ? sysfs_write_file+0x0/0x110
> > [ 8805.291979] [] sys_write+0x3d/0x70
> > [ 8805.291998] [] sysenter_past_esp+0x5f/0xa5
> > [ 8805.292038] ===
> > [ 8805.347640] ACPI: PCI interrupt for device :00:06.0 disabled
> > [ 8805.361128] ACPI: PCI interrupt for device :00:02.0 disabled
> > [ 8805.376670] hwsleep-0322 [00] enter_sleep_state : Entering sleep
> > state [S3]
> > [ 8805.376670] Back to C!
> >
> > Interface is unused normally (only for netconsole sometimes). dmesg and
> > config
> > attached.
>
> Does reverting this:
>
> commit 8543da6672b0994921f014f2250e27ae81645580
[...]
> fix it?
>
no
> > Hmm ... after resume device has disappeared at all ...
> >
> > {pts/1}% cat /proc/interrupts
> >CPU0
> > 0:1290492XT-PIC-XTtimer
> > 1: 6675XT-PIC-XTi8042
> > 2: 0XT-PIC-XTcascade
> > 3: 2XT-PIC-XT
> > 4: 2XT-PIC-XT
> > 5: 3XT-PIC-XT
> > 7: 4XT-PIC-XTirda0
> > 8: 0XT-PIC-XTrtc0
> > 9:583XT-PIC-XTacpi
> > 10: 2XT-PIC-XT
> > 11: 31483XT-PIC-XTyenta, yenta, yenta, ohci_hcd:usb1, ALI
> > 5451, pcmcia0.0
> > 12: 28070XT-PIC-XTi8042
> > 14: 21705XT-PIC-XTide0
> > 15: 82123XT-PIC-XTide1
> > NMI: 0 Non-maskable interrupts
> > TRM: 0 Thermal event interrupts
> > SPU: 0 Spurious interrupts
> > ERR: 0
>
> I hope that's not a separate bug...
>
>
this is red herring. pm-utils restart network across suspend; eth0 is not
activated automatically so it "disappears". ifconfig eth0 up brings it back.
signature.asc
Description: This is a digitally signed message part.
Re: [2.6.25-rc2] e100: Trying to free already-free IRQ 11 during suspend ...
On Sun, 17 Feb 2008 15:36:50 +0300 Andrey Borzenkov <[EMAIL PROTECTED]> wrote:
> ... and possibly reboot/poweroff (it flows by too fast to be legible).
>
> [ 8803.850634] ACPI: Preparing to enter system sleep state S3
> [ 8803.853141] Suspending console(s)
> [ 8805.287505] serial 00:09: disabled
> [ 8805.291564] Trying to free already-free IRQ 11
> [ 8805.291579] Pid: 6920, comm: pm-suspend Not tainted 2.6.25-rc2-1avb #2
> [ 8805.291628] [] free_irq+0xb7/0x130
> [ 8805.291675] [] e100_suspend+0xc0/0x100
> [ 8805.291724] [] pci_device_suspend+0x26/0x70
> [ 8805.291747] [] suspend_device+0x94/0xd0
> [ 8805.291763] [] device_suspend+0x153/0x240
> [ 8805.291784] [] suspend_devices_and_enter+0x4f/0xf0
> [ 8805.291808] [] ? freeze_processes+0x3f/0x80
> [ 8805.291825] [] enter_state+0xaa/0x140
> [ 8805.291840] [] state_store+0x8f/0xd0
> [ 8805.291852] [] ? state_store+0x0/0xd0
> [ 8805.291866] [] kobj_attr_store+0x24/0x30
> [ 8805.291901] [] sysfs_write_file+0xbb/0x110
> [ 8805.291936] [] vfs_write+0x99/0x130
> [ 8805.291963] [] ? sysfs_write_file+0x0/0x110
> [ 8805.291979] [] sys_write+0x3d/0x70
> [ 8805.291998] [] sysenter_past_esp+0x5f/0xa5
> [ 8805.292038] ===
> [ 8805.347640] ACPI: PCI interrupt for device :00:06.0 disabled
> [ 8805.361128] ACPI: PCI interrupt for device :00:02.0 disabled
> [ 8805.376670] hwsleep-0322 [00] enter_sleep_state : Entering sleep
> state [S3]
> [ 8805.376670] Back to C!
>
> Interface is unused normally (only for netconsole sometimes). dmesg and config
> attached.
Does reverting this:
commit 8543da6672b0994921f014f2250e27ae81645580
Author: Auke Kok <[EMAIL PROTECTED]>
Date: Wed Dec 12 16:30:42 2007 -0800
e100: free IRQ to remove warningwhenrebooting
with this patch:
--- a/drivers/net/e100.c~revert-1
+++ a/drivers/net/e100.c
@@ -2804,9 +2804,8 @@ static int e100_suspend(struct pci_dev *
pci_enable_wake(pdev, PCI_D3cold, 0);
}
- free_irq(pdev->irq, netdev);
-
pci_disable_device(pdev);
+ free_irq(pdev->irq, netdev);
pci_set_power_state(pdev, PCI_D3hot);
return 0;
@@ -2848,8 +2847,6 @@ static void e100_shutdown(struct pci_dev
pci_enable_wake(pdev, PCI_D3cold, 0);
}
- free_irq(pdev->irq, netdev);
-
pci_disable_device(pdev);
pci_set_power_state(pdev, PCI_D3hot);
}
_
fix it?
> Hmm ... after resume device has disappeared at all ...
>
> {pts/1}% cat /proc/interrupts
>CPU0
> 0:1290492XT-PIC-XTtimer
> 1: 6675XT-PIC-XTi8042
> 2: 0XT-PIC-XTcascade
> 3: 2XT-PIC-XT
> 4: 2XT-PIC-XT
> 5: 3XT-PIC-XT
> 7: 4XT-PIC-XTirda0
> 8: 0XT-PIC-XTrtc0
> 9:583XT-PIC-XTacpi
> 10: 2XT-PIC-XT
> 11: 31483XT-PIC-XTyenta, yenta, yenta, ohci_hcd:usb1, ALI
> 5451, pcmcia0.0
> 12: 28070XT-PIC-XTi8042
> 14: 21705XT-PIC-XTide0
> 15: 82123XT-PIC-XTide1
> NMI: 0 Non-maskable interrupts
> TRM: 0 Thermal event interrupts
> SPU: 0 Spurious interrupts
> ERR: 0
I hope that's not a separate bug...
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
