Re: [Comment] sizeof("struct tcp_sock") is above 1024 on x86 since linux-2.6.15

2006-03-24 Thread David S. Miller
From: Eric Dumazet <[EMAIL PROTECTED]>
Date: Tue, 21 Mar 2006 15:17:17 +0100

> I would like to point out that struct tcp_sock was enlarged in
> 2.6.15, and the 'TCP' kmem_cache now needs order-1 allocations
> instead of order-0

Thanks for pointing this out Eric, I'll see what I can do to
trim it down a bit.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [Comment] sizeof("struct tcp_sock") is above 1024 on x86 since linux-2.6.15

2006-03-22 Thread Andi Kleen
On Tuesday 21 March 2006 15:17, Eric Dumazet wrote:

> This is a new point of failure for x86 machines that use lot of tcp sockets, 
> I 
> learnt it the bad way and had to revert to 2.6.14 some servers that cannot 
> run 
> stock 2.6.15/2.6.16 for long because of this problem.

x86-64/ppc64/other 64bit with 4k page machines always had this problem but I'm 
not aware of 
people hitting it in practice.

> 
> Of course, we might argue the problem come from linux memory management...
> Oh well...

I'm sure there are ways to put struct sock / tcp_sock to a diet. From a quick 
look a 
lot of ints could be shorts, the function pointer callbacks could be moved
out to a different structure.

Maybe all those new hints recently added could be moved into a separate 
structure
and only be allocated if the socket has a large window.

Some fields only used by LISTEN sockets (e.g. last_synq_overflow) could be 
unioned
with ESTABLISHED data. Probably more opportunities for this.

etc.etc.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Comment] sizeof("struct tcp_sock") is above 1024 on x86 since linux-2.6.15

2006-03-21 Thread Eric Dumazet

Hi all

I would like to point out that struct tcp_sock was enlarged in 2.6.15, and the 
'TCP' kmem_cache now needs order-1 allocations instead of order-0



In 2.6.14 :

# grep "^TCP" /proc/slabinfo
TCP   64 7696041 : tunables   54   270 : 
slabdata 19 19  0


In 2.6.16 / 2.6.15 :

grep "^TCP" /proc/slabinfo
TCP   16 28   115272 : tunables   24   128 : 
slabdata  4  4  0



This is a new point of failure for x86 machines that use lot of tcp sockets, I 
learnt it the bad way and had to revert to 2.6.14 some servers that cannot run 
stock 2.6.15/2.6.16 for long because of this problem.


Of course, we might argue the problem come from linux memory management...
Oh well...

Thank you
Eric Dumazet


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [Comment] sizeof("struct tcp_sock") is above 1024 on x86 since linux-2.6.15

2006-03-21 Thread Eric Dumazet

Ismail Donmez a écrit :



This is a new point of failure for x86 machines that use lot of tcp
sockets, I learnt it the bad way and had to revert to 2.6.14 some servers
that cannot run stock 2.6.15/2.6.16 for long because of this problem.


It seems to be 1024 here, maybe its your config ?

[EMAIL PROTECTED] ~ $ grep "^TCP" /proc/slabinfo
TCP9 12   102441 : tunables   54   270 : 
slabdata  3  3  0

[EMAIL PROTECTED] ~ $ uname -a
Linux southpark 2.6.16 #7 Mon Mar 20 21:16:42 EET 2006 i686 i686 i386 
GNU/Linux


Yes, I should have mentioned my servers were SMP :)

Your kernel build is uniprocessor.

Eric
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [Comment] sizeof("struct tcp_sock") is above 1024 on x86 since linux-2.6.15

2006-03-21 Thread Ismail Donmez
Salı 21 Mart 2006 16:40 tarihinde, Eric Dumazet şunları yazmıştı: 
> Ismail Donmez a écrit :
> >> This is a new point of failure for x86 machines that use lot of tcp
> >> sockets, I learnt it the bad way and had to revert to 2.6.14 some
> >> servers that cannot run stock 2.6.15/2.6.16 for long because of this
> >> problem.
> >
> > It seems to be 1024 here, maybe its your config ?
> >
> > [EMAIL PROTECTED] ~ $ grep "^TCP" /proc/slabinfo
> > TCP9 12   102441 : tunables   54   27   
> > 0 : slabdata  3  3  0
> > [EMAIL PROTECTED] ~ $ uname -a
> > Linux southpark 2.6.16 #7 Mon Mar 20 21:16:42 EET 2006 i686 i686 i386
> > GNU/Linux
>
> Yes, I should have mentioned my servers were SMP :)

Ah, ok then.

Regards,
ismail
-- 
An eye for eye will make the whole world blind -- Gandhi


pgpvwuoCmAs9Z.pgp
Description: PGP signature


Re: [Comment] sizeof("struct tcp_sock") is above 1024 on x86 since linux-2.6.15

2006-03-21 Thread Ismail Donmez
Salı 21 Mart 2006 16:17 tarihinde şunları yazmıştınız:
> Hi all
>
> I would like to point out that struct tcp_sock was enlarged in 2.6.15, and
> the 'TCP' kmem_cache now needs order-1 allocations instead of order-0
>
>
> In 2.6.14 :
>
> # grep "^TCP" /proc/slabinfo
> TCP   64 7696041 : tunables   54   270
> : slabdata 19 19  0
>
> In 2.6.16 / 2.6.15 :
>
> grep "^TCP" /proc/slabinfo
> TCP   16 28   115272 : tunables   24   128
> : slabdata  4  4  0
>
>
> This is a new point of failure for x86 machines that use lot of tcp
> sockets, I learnt it the bad way and had to revert to 2.6.14 some servers
> that cannot run stock 2.6.15/2.6.16 for long because of this problem.

It seems to be 1024 here, maybe its your config ?

[EMAIL PROTECTED] ~ $ grep "^TCP" /proc/slabinfo
TCP9 12   102441 : tunables   54   270 : 
slabdata  3  3  0
[EMAIL PROTECTED] ~ $ uname -a
Linux southpark 2.6.16 #7 Mon Mar 20 21:16:42 EET 2006 i686 i686 i386 
GNU/Linux

Regards,
ismail

-- 
An eye for eye will make the whole world blind -- Gandhi


pgpJCHjcNryxk.pgp
Description: PGP signature