[DECNET] Fix input routing bug

2006-10-18 Thread Steven Whitehouse

This patch fixes a silly bug that has been in the input routing code
for some time. It results in trying to send to a node directly when
the origin of the packet is via the default router.

Its been tested by Alan Kemmerer [EMAIL PROTECTED] who
reported the bug and its a fairly obvious fix for a typo.

Signed-off-by: Steven Whitehouse [EMAIL PROTECTED]
Signed-off-by: Patrick Caulfield [EMAIL PROTECTED]
Cc: Alan Kemmerer [EMAIL PROTECTED]

diff --git a/net/decnet/dn_route.c b/net/decnet/dn_route.c
index dd0761e..810ab9c 100644
--- a/net/decnet/dn_route.c
+++ b/net/decnet/dn_route.c
@@ -1270,7 +1270,6 @@ #endif
goto e_inval;
 
res.type = RTN_LOCAL;
-   flags |= RTCF_DIRECTSRC;
} else {
__le16 src_map = fl.fld_src;
free_res = 1;
@@ -1341,7 +1340,7 @@ #endif
goto make_route;
 
/* Packet was intra-ethernet, so we know its on-link */
-   if (cb-rt_flags | DN_RT_F_IE) {
+   if (cb-rt_flags  DN_RT_F_IE) {
gateway = cb-src;
flags |= RTCF_DIRECTSRC;
goto make_route;
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [DECNET] Fix input routing bug

2006-10-18 Thread David Miller
From: Steven Whitehouse [EMAIL PROTECTED]
Date: Wed, 18 Oct 2006 09:38:17 +0100

 This patch fixes a silly bug that has been in the input routing code
 for some time. It results in trying to send to a node directly when
 the origin of the packet is via the default router.
 
 Its been tested by Alan Kemmerer [EMAIL PROTECTED] who
 reported the bug and its a fairly obvious fix for a typo.
 
 Signed-off-by: Steven Whitehouse [EMAIL PROTECTED]
 Signed-off-by: Patrick Caulfield [EMAIL PROTECTED]

Applied, thanks a lot.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html