[DECNET] Fix to decnet rules compare function

2006-08-11 Thread Steven Whitehouse


Here is a fix to the DECnet rules compare function where we used
32bit values rather than 16bit values. Spotted by Patrick McHardy.

Cc: Patrick McHardy [EMAIL PROTECTED]
Cc: Patrick Caulfield [EMAIL PROTECTED]
Signed-off-by: Steven Whitehouse [EMAIL PROTECTED]


diff --git a/net/decnet/dn_rules.c b/net/decnet/dn_rules.c
index 878312f..977bb56 100644
--- a/net/decnet/dn_rules.c
+++ b/net/decnet/dn_rules.c
@@ -196,10 +197,10 @@ static int dn_fib_rule_compare(struct fi
return 0;
 #endif
 
-   if (tb[FRA_SRC]  (r-src != nla_get_u32(tb[FRA_SRC])))
+   if (tb[FRA_SRC]  (r-src != nla_get_u16(tb[FRA_SRC])))
return 0;
 
-   if (tb[FRA_DST]  (r-dst != nla_get_u32(tb[FRA_DST])))
+   if (tb[FRA_DST]  (r-dst != nla_get_u16(tb[FRA_DST])))
return 0;
 
return 1;
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [DECNET] Fix to decnet rules compare function

2006-08-11 Thread David Miller
From: Steven Whitehouse [EMAIL PROTECTED]
Date: Fri, 11 Aug 2006 16:54:06 +0100

 Here is a fix to the DECnet rules compare function where we used
 32bit values rather than 16bit values. Spotted by Patrick McHardy.
 
 Cc: Patrick McHardy [EMAIL PROTECTED]
 Cc: Patrick Caulfield [EMAIL PROTECTED]
 Signed-off-by: Steven Whitehouse [EMAIL PROTECTED]

Applied, thanks a lot.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html