Re: [PATCH] [net-next] net: ip, diag: include net/inet_sock.h
From: Arnd BergmannDate: Tue, 25 Oct 2016 17:53:22 +0200 > The newly added raw_diag.c fails to build in some configurations > unless we include this header: > > In file included from net/ipv4/raw_diag.c:6:0: > include/net/raw.h:71:21: error: field 'inet' has incomplete type > net/ipv4/raw_diag.c: In function 'raw_diag_dump': > net/ipv4/raw_diag.c:166:29: error: implicit declaration of function 'inet_sk' > > Fixes: 432490f9d455 ("net: ip, diag -- Add diag interface for raw sockets") > Signed-off-by: Arnd Bergmann Applied, thanks Arnd.
Re: [PATCH] [net-next] net: ip, diag: include net/inet_sock.h
On Tue, Oct 25, 2016 at 05:53:22PM +0200, Arnd Bergmann wrote: > The newly added raw_diag.c fails to build in some configurations > unless we include this header: > > In file included from net/ipv4/raw_diag.c:6:0: > include/net/raw.h:71:21: error: field 'inet' has incomplete type > net/ipv4/raw_diag.c: In function 'raw_diag_dump': > net/ipv4/raw_diag.c:166:29: error: implicit declaration of function 'inet_sk' > > Fixes: 432490f9d455 ("net: ip, diag -- Add diag interface for raw sockets") > Signed-off-by: Arnd BergmannThank you! And sorry for this, it didn't trigger on my testing.
[PATCH] [net-next] net: ip, diag: include net/inet_sock.h
The newly added raw_diag.c fails to build in some configurations unless we include this header: In file included from net/ipv4/raw_diag.c:6:0: include/net/raw.h:71:21: error: field 'inet' has incomplete type net/ipv4/raw_diag.c: In function 'raw_diag_dump': net/ipv4/raw_diag.c:166:29: error: implicit declaration of function 'inet_sk' Fixes: 432490f9d455 ("net: ip, diag -- Add diag interface for raw sockets") Signed-off-by: Arnd Bergmann--- net/ipv4/raw_diag.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv4/raw_diag.c b/net/ipv4/raw_diag.c index ef3bea061b75..be930908bcf9 100644 --- a/net/ipv4/raw_diag.c +++ b/net/ipv4/raw_diag.c @@ -3,6 +3,7 @@ #include #include +#include #include #include -- 2.9.0