Re: [PATCH] ATM-ENI: Use kmalloc_array() in eni_start()

[David Miller]

From: SF Markus Elfring 
Date: Thu, 8 Sep 2016 14:40:06 +0200

> From: Markus Elfring 
> Date: Thu, 8 Sep 2016 14:20:17 +0200
> 
> * A multiplication for the size determination of a memory allocation
>   indicated that an array data structure should be processed.
>   Thus use the corresponding function "kmalloc_array".
> 
>   This issue was detected by using the Coccinelle software.
> 
> * Replace the specification of a data structure by a pointer dereference
>   to make the corresponding size determination a bit safer according to
>   the Linux coding style convention.
> 
> Signed-off-by: Markus Elfring 

Applied to net-next.

[PATCH] ATM-ENI: Use kmalloc_array() in eni_start()

[SF Markus Elfring]

From: Markus Elfring 
Date: Thu, 8 Sep 2016 14:20:17 +0200

* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "kmalloc_array".

  This issue was detected by using the Coccinelle software.

* Replace the specification of a data structure by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring 
---
 drivers/atm/eni.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/atm/eni.c b/drivers/atm/eni.c
index 6339efd..f2aaf9e 100644
--- a/drivers/atm/eni.c
+++ b/drivers/atm/eni.c
@@ -1845,8 +1845,9 @@ static int eni_start(struct atm_dev *dev)
/* initialize memory management */
buffer_mem = eni_dev->mem - (buf - eni_dev->ram);
eni_dev->free_list_size = buffer_mem/MID_MIN_BUF_SIZE/2;
-   eni_dev->free_list = kmalloc(
-   sizeof(struct eni_free)*(eni_dev->free_list_size+1),GFP_KERNEL);
+   eni_dev->free_list = kmalloc_array(eni_dev->free_list_size + 1,
+  sizeof(*eni_dev->free_list),
+  GFP_KERNEL);
if (!eni_dev->free_list) {
printk(KERN_ERR DEV_LABEL "(itf %d): couldn't get free page\n",
dev->number);
-- 
2.10.0